From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Chong Yidong <cyd@gnu.org>, 10650@debbugs.gnu.org
Subject: bug#10650: view-mode inconsistencies wrt special mode-class
Date: Thu, 02 Feb 2012 02:40:45 +0200 [thread overview]
Message-ID: <87ehuegj8y.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwvd39yljkd.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 01 Feb 2012 09:31:44 -0500")
>> Personally I think a separate variable controlling which modes are
>> incompatible with view-mode would be better, but I'm not going to
>> complain if the definition of special modes is extended to cover this.
>
> I'm not sure exactly what's the idea with view-mode's use of special
> mode class, but IIUC it's that we don't want to enable view-mode in
> major modes that already have view-mode-like keybindings, which might
> boil down to something along the lines of "major modes which use
> suppress-keymap".
Without using the special mode class or adding a new separate variable,
the closest condition to match modes incompatible with view-mode would be:
(and (buffer-file-name)
(or (derived-mode-p 'special-mode)
(equal (keymap-parent (current-local-map)) special-mode-map)))
What is worth to note is that these modes don't suppress the special-mode keymap,
but inherit from it and override most of its key bindings.
But this heuristics is too unreliable, so explicitly declaring
incompatible modes is better.
next prev parent reply other threads:[~2012-02-02 0:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 9:05 bug#10650: view-mode inconsistencies wrt special mode-class Glenn Morris
2012-01-30 20:10 ` Glenn Morris
2012-01-30 23:29 ` Juri Linkov
2012-01-31 0:38 ` Glenn Morris
2012-01-31 1:49 ` Stefan Monnier
2012-01-31 2:50 ` Glenn Morris
2012-01-31 6:17 ` Chong Yidong
2012-01-31 17:37 ` Stefan Monnier
2012-02-01 7:38 ` Glenn Morris
2012-02-01 8:32 ` Chong Yidong
2012-02-01 17:15 ` Glenn Morris
2012-02-01 14:31 ` Stefan Monnier
2012-02-01 17:12 ` Glenn Morris
2012-02-02 0:40 ` Juri Linkov [this message]
2012-02-02 18:49 ` Stefan Monnier
2012-02-02 20:03 ` Glenn Morris
2012-02-02 21:11 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehuegj8y.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=10650@debbugs.gnu.org \
--cc=cyd@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).