From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#12507: [debbugs-tracker] Processed: severity 12507 wishlist Date: Sat, 29 Sep 2012 17:12:40 +0200 Organization: Emacs Helm Message-ID: <87ehlkoobb.fsf@gmail.com> References: <87bogubqjy.fsf@gnu.org> <873925ebpd.fsf@gnu.org> <87ipb031aj.fsf@kwarm.red-bean.com> <87sja4t48j.fsf@gmail.com> <9D98A7802F07462887BCC67BE194243B@us.oracle.com> <87haqildr1.fsf@gmail.com> <877grduvfz.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1348931635 19793 80.91.229.3 (29 Sep 2012 15:13:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 29 Sep 2012 15:13:55 +0000 (UTC) Cc: 12507@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 29 17:14:01 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1THyjs-0003H2-9i for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Sep 2012 17:13:56 +0200 Original-Received: from localhost ([::1]:50168 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THyjm-0002I0-M9 for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Sep 2012 11:13:50 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THyjj-0002Hv-KG for bug-gnu-emacs@gnu.org; Sat, 29 Sep 2012 11:13:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THyji-0006JK-LE for bug-gnu-emacs@gnu.org; Sat, 29 Sep 2012 11:13:47 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THyji-0006JG-HI for bug-gnu-emacs@gnu.org; Sat, 29 Sep 2012 11:13:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1THyjx-0004E3-PX for bug-gnu-emacs@gnu.org; Sat, 29 Sep 2012 11:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Sep 2012 15:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12507 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12507-submit@debbugs.gnu.org id=B12507.134893159216178 (code B ref 12507); Sat, 29 Sep 2012 15:14:01 +0000 Original-Received: (at 12507) by debbugs.gnu.org; 29 Sep 2012 15:13:12 +0000 Original-Received: from localhost ([127.0.0.1]:33764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1THyj9-0004Cs-Di for submit@debbugs.gnu.org; Sat, 29 Sep 2012 11:13:12 -0400 Original-Received: from mail-wi0-f180.google.com ([209.85.212.180]:36682) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1THyj6-0004Ci-62 for 12507@debbugs.gnu.org; Sat, 29 Sep 2012 11:13:09 -0400 Original-Received: by wibhm4 with SMTP id hm4so738727wib.15 for <12507@debbugs.gnu.org>; Sat, 29 Sep 2012 08:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=CsaR6zx1OiMC51KytvnIlVOw7K/z/DjmoNWPX9ACp6o=; b=jSuRIeGcfjDYJyojDa58Bgpn1nv0wbxgbg6WX07jNecyvXcFgx6BzezK6UH5Wz4XKB XYWugC+sbPi2rW3DWclrjL+r72BwyHBltvri8a9jGATfxTTbaxqzAbSTQ6IFEFSDF/g4 o11/nxYbWOsfXPv0loZ2+kz8fVQ+9tz++U/ytkb4lN4Ekpitpu9TGQVcEPdHjT073Pca Tfg94aQVhbTxdS8iC3Q/FlLYSTMvJIg7fPsUreUZurqShploR3KblNuUxBtMpX9PP5Me ddK8EMEAARq+vj++PyA5xTGwWofxsXkvwq55UdV5tcLlb09utI3sxX6G1Qd5g2Zf2sXY 6ntg== Original-Received: by 10.216.26.138 with SMTP id c10mr5547480wea.76.1348931571690; Sat, 29 Sep 2012 08:12:51 -0700 (PDT) Original-Received: from dell-14z (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by mx.google.com with ESMTPS id w7sm5557754wiz.0.2012.09.29.08.12.49 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 29 Sep 2012 08:12:50 -0700 (PDT) In-Reply-To: (Drew Adams's message of "Sat, 29 Sep 2012 07:36:09 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65012 Archived-At: "Drew Adams" writes: >> > The question about visiting the file is still open, though. >> >> I am using now the patch I sent here yesterday and it works >> really good, faster and do backups (numered) as expected. >> Hope it will be applied here in emacs because it DTRT. >> >> I don't understand what is the problem with "visiting the file". >> See in precedent post why it is not bad visiting the file. >> In the special case of bookmark-write-file, it is really not the >> problem. > > Your question is for Stefan. > > Your patch is equivalent to the change I proposed originally: just replace > `write-region' with `write-file'. No, this is ineficient too, you write twice the same data. The important thing is writing directly to the buffer of file. For the backup thing, yes it is similar, but with unneeded steps, going straight to save-buffer is better and faster IMO (of course if you have started writing data in the file buffer) But the worst thing is the actual version with write-region: Slow and backup broken. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997