unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Achim Gratz <Stromeko@nexgo.de>
To: 14422@debbugs.gnu.org
Subject: bug#14422: 24.3; Eager Macro Expansion
Date: Thu, 30 May 2013 21:38:21 +0200	[thread overview]
Message-ID: <87ehcojm1e.fsf@Rainer.invalid> (raw)
In-Reply-To: <87hahz82rh.fsf@Rainer.invalid>

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

Stefan Monnier writes:
> I see the test fails, but that's just because the test is wrong.
[…]
> You'll see that your code behaves differently when byte-compiled.

Yes, we've already established that the original code itself had a bug.
The correct code would look like this


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: eme.el --]
[-- Type: text/x-emacs-lisp, Size: 171 bytes --]

(defvar eme-ll nil)

(defmacro one (p)
  `(progn (push ',p eme-ll)))

(defmacro two (p)
  `(let ((pp (append eme-ll ',p)))
     (progn (push pp eme-ll))))

(provide 'eme)

[-- Attachment #3: Type: text/plain, Size: 713 bytes --]


The remaining point is that the ERT test still fails in exactly the same
way when it is _not_ byte-compiled and batch-tested (like the original
case in Org), but it produces the correct result when testing in
interactive mode or in the debugger.  I guess I'm asking for a warning
for recursive macro expansions that manipulate the same variable both at
expansion and at runtime in separate macros.  Alternatively if the buggy
code would always fail in the same way that would at least ensure it can
be found more easily.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables

  reply	other threads:[~2013-05-30 19:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-19 14:26 bug#14422: 24.3; Eager Macro Expansion Achim Gratz
2013-05-21  2:11 ` Stefan Monnier
2013-05-26 15:34   ` Achim Gratz
2013-05-26 19:29     ` Stefan Monnier
2013-05-26 19:57       ` Achim Gratz
2013-05-30 17:59   ` Achim Gratz
2013-05-30 19:00     ` Stefan Monnier
2013-05-30 19:38       ` Achim Gratz [this message]
2013-05-30 21:14         ` Stefan Monnier
2013-06-03 15:29           ` Stefan Monnier
2020-08-25 11:05             ` Lars Ingebrigtsen
2020-10-13  1:47               ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ehcojm1e.fsf@Rainer.invalid \
    --to=stromeko@nexgo.de \
    --cc=14422@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).