From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 14637@debbugs.gnu.org
Subject: bug#14637: recent viper-mode regression
Date: Wed, 19 Jun 2013 23:53:07 +0300 [thread overview]
Message-ID: <87ehbx7vog.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwv38sfndwf.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 18 Jun 2013 20:28:18 -0400")
>> Grepping for `shell-command-on-region' revealed the exhaustive list
>> of the callers that are fixed now with this patch to set both args
>> OUTPUT-BUFFER and REPLACE to the same value in unison:
>
> Do all the callers need to be fixed? Most of them? A minority only?
> If it's not just a minority, then maybe the better fix is to revert
> revno:112695 (or at least change it) so that existing code doesn't need
> to be changed.
I fixed all the callers that missed the required REPLACE arg:
5 were in vi mode, and 1 in mh-e. They are just a minority
out of total 25 occurrences of `shell-command-on-region'.
next prev parent reply other threads:[~2013-06-19 20:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 22:59 bug#14637: recent viper-mode regression Jim Meyering
2013-06-18 20:25 ` Juri Linkov
2013-06-19 0:28 ` Stefan Monnier
2013-06-19 20:53 ` Juri Linkov [this message]
2013-06-20 2:02 ` Stefan Monnier
[not found] ` <handler.14637.D14637.13715874305307.notifdone@debbugs.gnu.org>
2013-06-19 8:56 ` bug#14637: closed (Re: bug#14637: recent viper-mode regression) Jim Meyering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehbx7vog.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=14637@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).