unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ivan Kanis <ivan@kanis.fr>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 16204@debbugs.gnu.org
Subject: bug#16204: proposed patch for 24.4
Date: Fri, 25 Jul 2014 11:58:59 +0200	[thread overview]
Message-ID: <87egx9zrmk.fsf@kanis.fr> (raw)
In-Reply-To: <87ob4bwj6l.fsf@violet.siamics.net>

Hi Lars,

This bug has been driving me nuts for a while. I have set shr-width many
times and it would just not work. I have then wasted time trying to find
out why it didn't work.

I would like to spare that time to users of 24.4 when it gets released.

I propose the following patch in the branch emacs-24 on bzr:

=== modified file 'lisp/net/eww.el'
--- lisp/net/eww.el     2014-03-05 18:44:58 +0000
+++ lisp/net/eww.el     2014-07-25 09:32:01 +0000
@@ -264,7 +264,6 @@
     (setq eww-current-dom document)
     (let ((inhibit-read-only t)
          (after-change-functions nil)
-         (shr-width nil)
          (shr-target-id (url-target (url-generic-parse-url url)))
          (shr-external-rendering-functions
           '((title . eww-tag-title)

=== modified file 'lisp/net/shr.el'
--- lisp/net/shr.el     2014-04-14 22:01:54 +0000
+++ lisp/net/shr.el     2014-07-25 09:25:15 +0000
@@ -196,8 +196,7 @@
   (let ((start (point))
        (shr-state nil)
        (shr-start nil)
-       (shr-base nil)
-       (shr-width (or shr-width (1- (window-width)))))
+       (shr-base nil))
     (shr-descend (shr-transform-dom dom))
     (shr-remove-trailing-whitespace start (point))))

I have tested with shr-width equal to nil and 70 and it does the
right thing ie. the former wraps at the window width and the latter at
column 70.

I can commit it if everyone is OK with this.

Ivan

-- 
The monitor needs another box of pixels.
    -- BOFH excuse #60





  parent reply	other threads:[~2014-07-25  9:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-20 17:01 bug#16204: eww does not respect shr-width customization Ivan Shmakov
2013-12-21 10:48 ` Kenjiro NAKAYAMA
2013-12-21 11:08   ` Ivan Shmakov
2013-12-21 14:49     ` Kenjiro NAKAYAMA
2013-12-21 16:59       ` Ivan Shmakov
2013-12-21 20:24       ` bug#16204: eww does not respect shr-width customization, " Ted Zlatanov
2013-12-24  8:01 ` Lars Ingebrigtsen
2014-07-25  9:58 ` Ivan Kanis [this message]
2014-08-05 17:31   ` bug#16204: proposed patch for 24.4 Lars Magne Ingebrigtsen
2014-08-06 17:34     ` Ivan Kanis
2014-08-07 14:21       ` Ivan Kanis
2014-09-18 19:19         ` Lars Magne Ingebrigtsen
2014-09-18 23:48           ` Ivan Kanis
2014-09-21 12:27             ` Lars Magne Ingebrigtsen
2014-09-22  0:31               ` Ivan Kanis
2014-10-19 22:36                 ` Lars Magne Ingebrigtsen
2014-10-20 17:40                   ` Ivan Kanis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87egx9zrmk.fsf@kanis.fr \
    --to=ivan@kanis.fr \
    --cc=16204@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).