From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#19727: 25.0.50; setting a todo item to done puts point at the end of the buffer Date: Tue, 03 Feb 2015 23:39:58 +0100 Message-ID: <87egq6bow1.fsf@gmx.net> References: <827fw5oq1k.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1423003276 9976 80.91.229.3 (3 Feb 2015 22:41:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Feb 2015 22:41:16 +0000 (UTC) Cc: 19727@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 03 23:41:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YIm9e-0007fB-Rb for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Feb 2015 23:41:10 +0100 Original-Received: from localhost ([::1]:33723 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIm9e-0000oX-9z for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Feb 2015 17:41:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIm9a-0000nl-0U for bug-gnu-emacs@gnu.org; Tue, 03 Feb 2015 17:41:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIm9W-0004h3-O5 for bug-gnu-emacs@gnu.org; Tue, 03 Feb 2015 17:41:05 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIm9W-0004gy-LA for bug-gnu-emacs@gnu.org; Tue, 03 Feb 2015 17:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YIm9W-0007Nj-9i for bug-gnu-emacs@gnu.org; Tue, 03 Feb 2015 17:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Feb 2015 22:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19727 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19727-submit@debbugs.gnu.org id=B19727.142300321028295 (code B ref 19727); Tue, 03 Feb 2015 22:41:02 +0000 Original-Received: (at 19727) by debbugs.gnu.org; 3 Feb 2015 22:40:10 +0000 Original-Received: from localhost ([127.0.0.1]:33215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YIm8g-0007MJ-FJ for submit@debbugs.gnu.org; Tue, 03 Feb 2015 17:40:10 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:60170) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YIm8e-0007M5-JL for 19727@debbugs.gnu.org; Tue, 03 Feb 2015 17:40:09 -0500 Original-Received: from rosalinde ([89.245.93.18]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LskKv-1XcncU16in-012GlK; Tue, 03 Feb 2015 23:39:59 +0100 In-Reply-To: <827fw5oq1k.fsf@gmail.com> (Robert Pluim's message of "Thu, 29 Jan 2015 11:10:47 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:0lZxKh5iBxdI+/ubSJOPNhtT97AhT0KiyD/M9DuOl5W0euI0XK6 LCZc4a38Fu+R1T43iOegvMwrzN1QWuFsrRKr2fpNv2hW8dDtVvarzW8MDWW3TTHMvqRiAIA slO7W3uOrxIeimj9VKsWhRs9Vj3P7nOwX2AK+HA6EerRAQHojgGZULyWCqNfRyq3k9OOBKE GDkTj+7bfsV/Or2PZEhvA== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99022 Archived-At: On Thu, 29 Jan 2015 11:10:47 +0100 Robert Pluim wrote: > when I set an item to done in a todo-mode buffer, point ends up at the > end of the buffer, which is somewhat surprising. Attached patch > remembers where point was, and restores it. As the todo-mode.el maintainer, sorry for not responding sooner. I guess it's reasonable to leave point where the previously not-done item was when the done items section is hidden. I take it you have no objection to the current behavior of point moving to the item just set to done when the done items section is visible, since your patch doesn't alter that. If so, then I'll install your patch as is (but with a more appropriate commit message and ChangeLog entry). Before I do that, have you submitted a copyright assignment for Emacs? If not, I'll install it as a tiny change. Thanks for the patch. Steve Berman