From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode Date: Wed, 25 Feb 2015 17:10:13 +0000 Message-ID: <87egpd3oju.fsf@violet.siamics.net> References: <87pp953q1j.fsf_-_@violet.siamics.net> <83lhjslwup.fsf@gnu.org> <87h9ug4dk1.fsf@violet.siamics.net> <87d25447e8.fsf@violet.siamics.net> <874mqf4ixf.fsf@violet.siamics.net> <83lhjrcwy6.fsf@gnu.org> <87sidu3423.fsf@violet.siamics.net> <83vbiq561x.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1424884787 3841 80.91.229.3 (25 Feb 2015 17:19:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Feb 2015 17:19:47 +0000 (UTC) To: 19903@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 25 18:19:39 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YQfcW-0000Qp-BD for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Feb 2015 18:19:36 +0100 Original-Received: from localhost ([::1]:55344 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQfcV-0000vo-Fz for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Feb 2015 12:19:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQfUK-0000Rd-M6 for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 12:11:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQfUH-0007Oa-CD for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 12:11:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQfUF-0007OM-Ml for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 12:11:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YQfUE-0006wf-6j for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 12:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Feb 2015 17:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19903 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19903-submit@debbugs.gnu.org id=B19903.142488422926659 (code B ref 19903); Wed, 25 Feb 2015 17:11:02 +0000 Original-Received: (at 19903) by debbugs.gnu.org; 25 Feb 2015 17:10:29 +0000 Original-Received: from localhost ([127.0.0.1]:58008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQfTg-0006vt-Pn for submit@debbugs.gnu.org; Wed, 25 Feb 2015 12:10:29 -0500 Original-Received: from fely.am-1.org ([78.47.74.50]:46286) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQfTe-0006ve-6K for 19903@debbugs.gnu.org; Wed, 25 Feb 2015 12:10:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=hwNEO6NGZf1d68rLR+9CJk2CJBun12xPUULhP+njcpw=; b=KxekKJGfZr/vE6d6jws8Ian6NUjjPCqEBIxMoU0jHjdfi1K6MaZB7/X3OI2Cfjv81DGsU/2PmWYwGlm6iUnWZ4/37TYWmIXQV1K+F+5/4YzWRNQ6/hmIfZi52YTHlKfoIxDNiRhUh4iWrJ/UTYS5ISbwGknuTWeh8BDGfy/uEEg=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YQfTZ-0002QQ-8p for 19903@debbugs.gnu.org; Wed, 25 Feb 2015 17:10:21 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YQfTR-0008CD-Tl for 19903@debbugs.gnu.org; Thu, 26 Feb 2015 00:10:14 +0700 Mail-Followup-To: 19903@debbugs.gnu.org In-Reply-To: <83vbiq561x.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 25 Feb 2015 18:06:50 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99810 Archived-At: >>>>> Eli Zaretskii writes: >>>>> From: Ivan Shmakov Date: Wed, 25 Feb 2015 06:20:36 +0000 >>> I don't think internal functions should cater to UI issues, unless >>> they are themselves interactive. >> I=E2=80=99m unsure where you see an UI issue here? The issue, as origi= nally >> reported, is that face-attribute fails to handle string-named faces, >> which are considered perfectly valid by the rest of Emacs >> (including, say, facep and the display engine.) > Accepting strings instead of symbols is a convenience feature > for users, so it's a UI issue. Could you please elaborate on this? Specifically, does this apply to the interactive or non-interactive use (or both) of facemenu-add-face? [=E2=80=A6] >>> If we keep this confined to interactive functions, how many such >>> functions in facemenu.el will have to be changed? If not too many, >>> I'm inclined to keep this there. >> I believe that facemenu-add-face is the only function which can be >> used to add a string-named face /interactively/, as it reads an >> arbitrary Lisp form for the face. (See also #18369.) > Yes, but how many don't? One another (facemenu-set-face) uses read-face-name, which in turn explicitly passes user input through =E2=80=98intern=E2=80=99. Then, facemenu-set-face-from-menu uses last-command-event (when called interactively), assumes it=E2=80=99s a symbol, and uses it either as a face directly /or/ (should its name begin with fg: or bg:) as the cdr for a cons cell face. (The facemenu-set-foreground and facemenu-set-background commands rely on this.) Per my reading of the code, no other command there accepts user-specified faces when used interactively. [=E2=80=A6] --=20 FSF associate member #7257 np. Coming Home =E2=80=94 Iron Maiden B6A0 230= E 334A