From: Ivan Shmakov <ivan@siamics.net>
To: 19903@debbugs.gnu.org
Subject: bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode
Date: Wed, 25 Feb 2015 17:10:13 +0000 [thread overview]
Message-ID: <87egpd3oju.fsf@violet.siamics.net> (raw)
In-Reply-To: <83vbiq561x.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 25 Feb 2015 18:06:50 +0200")
>>>>> Eli Zaretskii <eliz@gnu.org> writes:
>>>>> From: Ivan Shmakov Date: Wed, 25 Feb 2015 06:20:36 +0000
>>> I don't think internal functions should cater to UI issues, unless
>>> they are themselves interactive.
>> I’m unsure where you see an UI issue here? The issue, as originally
>> reported, is that face-attribute fails to handle string-named faces,
>> which are considered perfectly valid by the rest of Emacs
>> (including, say, facep and the display engine.)
> Accepting strings instead of symbols is a convenience feature
> for users, so it's a UI issue.
Could you please elaborate on this? Specifically, does this
apply to the interactive or non-interactive use (or both) of
facemenu-add-face?
[…]
>>> If we keep this confined to interactive functions, how many such
>>> functions in facemenu.el will have to be changed? If not too many,
>>> I'm inclined to keep this there.
>> I believe that facemenu-add-face is the only function which can be
>> used to add a string-named face /interactively/, as it reads an
>> arbitrary Lisp form for the face. (See also #18369.)
> Yes, but how many don't?
One another (facemenu-set-face) uses read-face-name, which in
turn explicitly passes user input through ‘intern’.
Then, facemenu-set-face-from-menu uses last-command-event (when
called interactively), assumes it’s a symbol, and uses it either
as a face directly /or/ (should its name begin with fg: or bg:)
as the cdr for a cons cell face. (The facemenu-set-foreground
and facemenu-set-background commands rely on this.)
Per my reading of the code, no other command there accepts
user-specified faces when used interactively.
[…]
--
FSF associate member #7257 np. Coming Home — Iron Maiden B6A0 230E 334A
next prev parent reply other threads:[~2015-02-25 17:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 17:15 bug#19903: 24.4; Emacs fails to save enriched buffer with error message `wrong-type-argument symbolp "bold"' Jorge
2015-02-19 18:48 ` bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode Ivan Shmakov
2015-02-20 8:27 ` bug#19903: 24.4; Emacs fails to save enriched buffer with error message `wrong-type-argument symbolp "bold"' Eli Zaretskii
2015-02-20 8:51 ` Jorge
2015-02-20 9:12 ` bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode Ivan Shmakov
2015-02-20 10:07 ` Eli Zaretskii
2015-02-20 17:18 ` Stefan Monnier
2015-02-20 18:56 ` Ivan Shmakov
2015-02-20 19:55 ` Stefan Monnier
2015-02-20 21:09 ` Ivan Shmakov
2015-02-21 11:12 ` Ivan Shmakov
2015-02-21 11:42 ` Eli Zaretskii
2015-02-25 6:20 ` Ivan Shmakov
2015-02-25 16:06 ` Eli Zaretskii
2015-02-25 17:10 ` Ivan Shmakov [this message]
2015-02-25 17:43 ` Eli Zaretskii
2015-02-25 17:55 ` Ivan Shmakov
2015-02-21 12:12 ` bug#19912: facemenu-add-face: does not handle 'face being set to a property list Ivan Shmakov
2015-02-25 7:05 ` Ivan Shmakov
2015-02-25 17:24 ` Ivan Shmakov
2015-02-26 18:12 ` Ivan Shmakov
2015-02-20 10:03 ` bug#19903: 24.4; Emacs fails to save enriched buffer with error message `wrong-type-argument symbolp "bold"' Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egpd3oju.fsf@violet.siamics.net \
--to=ivan@siamics.net \
--cc=19903@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).