bug#22054: Potential errors in package--builtins

bug#22054: Potential errors in package--builtins

[Jonas Bernoulli]

* `ielm' is missing from the list.  I suspect it is not detected as a
  package because the first line does not contain the summary.  Also,
  shouldn't the "interaction mode for Emacs Lisp" be located inside
  lisp/emacs-lisp/?

* `cl-preload' is listed as a separate package.  That might be
  intentional but wouldn't it make more sense to make it part of
  the `cl-lib' package?

* `eieio-compat' is listed as a separate package.  But I suspect that
  is intentional.  Not sure though.

* `sasl-scram-rfc' is listed as a separate package, but all the other
  `sasl-*' libraries are part of the `sasl' package.

This is for the `emacs-25' branch.

bug#22054: Potential errors in package--builtins

[Artur Malabarba]

2015-11-29 19:24 GMT+00:00 Jonas Bernoulli <jonas@bernoul.li>:
> * `ielm' is missing from the list.  I suspect it is not detected as a
>   package because the first line does not contain the summary.

No. It needs a version number to be considered a package. But then,
why should it be on the list? Is it also provided in one of the
archives?

> Also, shouldn't the "interaction mode for Emacs Lisp" be located inside
>   lisp/emacs-lisp/?

Last I was told, lisp/emacs-lisp is for libraries to be used by other
elisp code. But then, not all files in there perfectly fit that
description either.
So I'll let someone who cares about that continue this line of thought. =P

> * `cl-preload' is listed as a separate package.
>
> * `eieio-compat' is listed as a separate package.  But I suspect that
>   is intentional.  Not sure though.
>
> * `sasl-scram-rfc' is listed as a separate package, but all the other
>   `sasl-*' libraries are part of the `sasl' package.

Assuming you mean cl-preloadED.el... Maybe someone just fixed it but
none of these are listed as built-ins for me.

bug#22054: Potential errors in package--builtins

[Jonas Bernoulli]

Artur Malabarba <bruce.connor.am@gmail.com> writes:

> 2015-11-29 19:24 GMT+00:00 Jonas Bernoulli <jonas@bernoul.li>:
>> * `ielm' is missing from the list.  I suspect it is not detected as a
>>   package because the first line does not contain the summary.
>
> No. It needs a version number to be considered a package. But then,
> why should it be on the list? Is it also provided in one of the
> archives?

Why not?  It is a self-contained package, just like many other
self-contained packages, which are listed as individual packages.  I
cannot see a reason why these other packages should be treated as such,
but not this one.

There are other libraries which one might argue should, or should not,
be considered to be individual packages, but in this case it seems
pretty clear to me that it should be a package, because many other
libraries "just like it" are.

>> * `cl-preload' is listed as a separate package.
>>
>> * `eieio-compat' is listed as a separate package.  But I suspect that
>>   is intentional.  Not sure though.
>>
>> * `sasl-scram-rfc' is listed as a separate package, but all the other
>>   `sasl-*' libraries are part of the `sasl' package.
>
> Assuming you mean cl-preloadED.el...

Yes.

> Maybe someone just fixed it but none of these are listed as built-ins
> for me.

On the `emacs-25' branch, they all have an individual entry in
`package--builtins'.

bug#22054: Potential errors in package--builtins

[Artur Malabarba]

2015-12-03 14:46 GMT+00:00 Jonas Bernoulli <jonas@bernoul.li>:
> On the `emacs-25' branch, they all have an individual entry in
> `package--builtins'.

I see we're talking about different things then. I was looking at the
list of built-in packages in the package menu.
Indeed, the variable you're referring to lists even files without
version-numbers, so ielm should be in that list. And your initial
assessment looks correct, so I'll fix it.

Since nobody said anything about the other entries you mentioned being
intentional, I'll fix them too and we'll see if anyone yells. :)

bug#22054: Potential errors in package--builtins

[Artur Malabarba]

> Since nobody said anything about the other entries you mentioned being
> intentional, I'll fix them too and we'll see if anyone yells. :)

Fixed in emacs-25

bug#22054: Potential errors in package--builtins

[Jonas Bernoulli]

Artur Malabarba <bruce.connor.am@gmail.com> writes:

> 2015-12-03 14:46 GMT+00:00 Jonas Bernoulli <jonas@bernoul.li>:
>> On the `emacs-25' branch, they all have an individual entry in
>> `package--builtins'.
>
> I see we're talking about different things then. I was looking at the
> list of built-in packages in the package menu.
> Indeed, the variable you're referring to lists even files without
> version-numbers, so ielm should be in that list. And your initial
> assessment looks correct, so I'll fix it.
>
> Since nobody said anything about the other entries you mentioned being
> intentional, I'll fix them too and we'll see if anyone yells. :)

Thanks.

(Do you intend to do that soon?)

bug#22054: Potential errors in package--builtins

[Artur Malabarba]

It's done already on the emacs-25 branch. It'll get merged to master
when someone merges the branch to master (which is taking unusually
long due to some technicalities on this release).

2015-12-12 19:43 GMT+00:00 Jonas Bernoulli <jonas@bernoul.li>:
>
> Artur Malabarba <bruce.connor.am@gmail.com> writes:
>
>> 2015-12-03 14:46 GMT+00:00 Jonas Bernoulli <jonas@bernoul.li>:
>>> On the `emacs-25' branch, they all have an individual entry in
>>> `package--builtins'.
>>
>> I see we're talking about different things then. I was looking at the
>> list of built-in packages in the package menu.
>> Indeed, the variable you're referring to lists even files without
>> version-numbers, so ielm should be in that list. And your initial
>> assessment looks correct, so I'll fix it.
>>
>> Since nobody said anything about the other entries you mentioned being
>> intentional, I'll fix them too and we'll see if anyone yells. :)
>
> Thanks.
>
> (Do you intend to do that soon?)