unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#22843: perl-mode coloring sees too deeply into <<EOF
@ 2016-02-28 20:55 積丹尼 Dan Jacobson
  2019-07-06  3:40 ` Stefan Kangas
  2019-07-06 14:03 ` 積丹尼 Dan Jacobson
  0 siblings, 2 replies; 4+ messages in thread
From: 積丹尼 Dan Jacobson @ 2016-02-28 20:55 UTC (permalink / raw)
  To: 22843

[-- Attachment #1: Type: text/plain, Size: 47 bytes --]

After "print <<EOF;" the colors are all wrong!

[-- Attachment #2: perl file --]
[-- Type: text/plain, Size: 1219 bytes --]

#!/usr/bin/perl
# Make a sheet of my substandard size namecards
# which hopefully fit all on one printer page.
# Copyright       : http://www.fsf.org/copyleft/gpl.html
# Created On      : July 2006
# Last Modified On: Sun Feb 14 00:45:33 2016
# Update Count    : 214
use strict;
use warnings FATAL => 'all';
##use HTML::Table;
use constant ONECARD => <<\EOF;
積丹尼 Dan Jacobson<br>
http://jidanni.org/<br>
台中市東勢區慶福街1-6號<br>
0963-114343 04-25854780
EOF
print <<EOF;
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
"http://www.w3.org/TR/html4/strict.dtd">
<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta http-equiv="Content-Language" content="zh-tw">
<!-- MADE VIA ~/namecard; WILL GET OVERWRITTEN-->
<style type="text/css">
TD { text-align: center }
</style>
<title>Namecard</title></head><body>
<table border="1" cellspacing="0" cellpadding="18" summary="Name cards">
EOF
## cellpadding 17 will cause an extra page
for ( 1 .. 8 ) {
## 育才列印 was able to print 1..9 !
    print '<tr>';
    for ( 1 .. 3 ) {
        print '<th>', ONECARD, '</th>';
    }
    print "</tr>\n";
}
print "</table>\n</body></html>\n";

[-- Attachment #3: Type: text/plain, Size: 109 bytes --]

The previous print <<\EOF; doesn't have that problem.

cperl-mode gets both correct.

emacs-version "24.5.1"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#22843: perl-mode coloring sees too deeply into <<EOF
  2016-02-28 20:55 bug#22843: perl-mode coloring sees too deeply into <<EOF 積丹尼 Dan Jacobson
@ 2019-07-06  3:40 ` Stefan Kangas
  2019-07-06 14:03 ` 積丹尼 Dan Jacobson
  1 sibling, 0 replies; 4+ messages in thread
From: Stefan Kangas @ 2019-07-06  3:40 UTC (permalink / raw)
  To: 積丹尼 Dan Jacobson; +Cc: 22843

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

> After "print <<EOF;" the colors are all wrong!
>
> #!/usr/bin/perl
> # Make a sheet of my substandard size namecards
> # which hopefully fit all on one printer page.
> # Copyright       : http://www.fsf.org/copyleft/gpl.html
> # Created On      : July 2006
> # Last Modified On: Sun Feb 14 00:45:33 2016
> # Update Count    : 214
> use strict;
> use warnings FATAL => 'all';
> ##use HTML::Table;
> use constant ONECARD => <<\EOF;
> 積丹尼 Dan Jacobson<br>
> http://jidanni.org/<br>
> 台中市東勢區慶福街1-6號<br>
> 0963-114343 04-25854780
> EOF
> print <<EOF;
> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
> "http://www.w3.org/TR/html4/strict.dtd">
> <html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8">
> <meta http-equiv="Content-Language" content="zh-tw">
> <!-- MADE VIA ~/namecard; WILL GET OVERWRITTEN-->
> <style type="text/css">
> TD { text-align: center }
> </style>
> <title>Namecard</title></head><body>
> <table border="1" cellspacing="0" cellpadding="18" summary="Name cards">
> EOF
> ## cellpadding 17 will cause an extra page
> for ( 1 .. 8 ) {
> ## 育才列印 was able to print 1..9 !
>     print '<tr>';
>     for ( 1 .. 3 ) {
>         print '<th>', ONECARD, '</th>';
>     }
>     print "</tr>\n";
> }
> print "</table>\n</body></html>\n";
>
> The previous print <<\EOF; doesn't have that problem.
>
> cperl-mode gets both correct.
>
> emacs-version "24.5.1"

I tried reproducing this on the latest version of Emacs, 26.2, but was
unable to.  The colors after "print <<EOF;" seemed fine to me.

Could you please try reproducing this with the latest version of Emacs?

Please also provide more details on what colors are wrong -- on what
line, which color you see and which you would have expected instead.

Thanks,
Stefan Kangas





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#22843: perl-mode coloring sees too deeply into <<EOF
  2016-02-28 20:55 bug#22843: perl-mode coloring sees too deeply into <<EOF 積丹尼 Dan Jacobson
  2019-07-06  3:40 ` Stefan Kangas
@ 2019-07-06 14:03 ` 積丹尼 Dan Jacobson
  2019-07-07 11:33   ` Stefan Kangas
  1 sibling, 1 reply; 4+ messages in thread
From: 積丹尼 Dan Jacobson @ 2019-07-06 14:03 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: 22843

OK it looks better in 26.1. The main problem remaining is the Here Doc
uses font-lock-comment-face, making it look exactly like (nearby too)
comments! It should get its own face.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#22843: perl-mode coloring sees too deeply into <<EOF
  2019-07-06 14:03 ` 積丹尼 Dan Jacobson
@ 2019-07-07 11:33   ` Stefan Kangas
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Kangas @ 2019-07-07 11:33 UTC (permalink / raw)
  To: 積丹尼 Dan Jacobson; +Cc: 22843-done

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:
> OK it looks better in 26.1. The main problem remaining is the Here Doc
> uses font-lock-comment-face, making it look exactly like (nearby too)
> comments! It should get its own face.

OK, thanks.  The other issue you raise is Bug#23461.

Since we can't reproduce the original issue on a recent Emacs,
I'm closing this bug.

Thanks,
Stefan Kangas





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-07-07 11:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-28 20:55 bug#22843: perl-mode coloring sees too deeply into <<EOF 積丹尼 Dan Jacobson
2019-07-06  3:40 ` Stefan Kangas
2019-07-06 14:03 ` 積丹尼 Dan Jacobson
2019-07-07 11:33   ` Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).