From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Robert Cochran Newsgroups: gmane.emacs.bugs Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function Date: Tue, 12 Jul 2016 12:11:53 -0700 Message-ID: <87eg6yvfgm.fsf@cochranmail.com> References: <87k2gr49lp.fsf@cochranmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468352583 13890 80.91.229.3 (12 Jul 2016 19:43:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Jul 2016 19:43:03 +0000 (UTC) Cc: Philipp Stephani , Robert Cochran , 23957@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 12 21:42:50 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bN3Zy-0000s0-FQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jul 2016 21:42:50 +0200 Original-Received: from localhost ([::1]:43018 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN3Zx-0007eS-QE for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jul 2016 15:42:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN37J-0000AG-Fa for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 15:13:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bN37G-0004vi-9J for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 15:13:13 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN37G-0004vE-3L for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 15:13:10 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bN378-0005h7-LS for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 15:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Cochran Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2016 19:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23957-submit@debbugs.gnu.org id=B23957.146835072321788 (code B ref 23957); Tue, 12 Jul 2016 19:13:02 +0000 Original-Received: (at 23957) by debbugs.gnu.org; 12 Jul 2016 19:12:03 +0000 Original-Received: from localhost ([127.0.0.1]:48695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN36B-0005fM-2l for submit@debbugs.gnu.org; Tue, 12 Jul 2016 15:12:03 -0400 Original-Received: from mail.workgrouplinux.net ([207.195.177.82]:32997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN369-0005eo-9o for 23957@debbugs.gnu.org; Tue, 12 Jul 2016 15:12:01 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=JduiYtD6NKnjC+qXhZY0B3Gulo4=; b=ycU1+ PUM22klu4URh4JvGKi2jsXbWSYIkNZrguzthuV1Mu0iLrHx7m8nEojycobsO7k31 XaYnLPpE9K1G8Yazo2Grg2etyuhxCZ3uc13VKWB1jPhJSY+TL9+Gdh8FUDzncr+E Kc1pRltFfBNAlrIds9GE6o7LwbgmbgsZFSCjdDRg7LiKFS0E/e55J5FEREl5IdNI ejTSZ5z/mXn3bE7PXaYRz+M9zoCPYkex6S0xGO6T31UFgYft0Rhml1BdwVN7ODeD JqL3lBNCMnfI1WL892oEqHpwEOuSGpCtPcinfjtcc/UlbIoAscDOhjlYz3cDUvLM /PKD5UnJTLgq4bNOQ== Original-Received: (qmail 9195 invoked by uid 0); 12 Jul 2016 19:11:57 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=mTFntIG71Iquj892AZNJ5Q9zzJRGCJzmi3N9gCNo4q1yqWiI/nNvHSOy1shV4E9vR+gyxYeqHETpLY50k4i9Yw==; Original-Received: from 74-93-99-217-washington.hfc.comcastbusiness.net (HELO SoraLaptop) (robert@cochranmail.com@74.93.99.217) by mail.cochrantribe.org with ESMTPA; 12 Jul 2016 19:11:57 -0000 In-Reply-To: (Drew Adams's message of "Tue, 12 Jul 2016 17:49:17 +0000 (UTC)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120950 Archived-At: I didn't put too much thought into reading the FIXME; I figured that someone smarter than myself knew what they were doing when requesting the change. I'd personally argue that anyone making an explicit check for t, or anything that particularly needs t rather than any true value is just asking for lossage, but I can see why people would disagree with that assertion. FWIW, In every placed I changed occurrences of fboundp to symbol-function, both in Lisp and C, used only the truthiness of the return rather than explicitly checking for t. I also ran the test suite with and without my patch applied, and noticed no difference in the number of failing tests. Anyways, I'm willing to toss this patch and do something else if that is the general consensus. Thanks, ~Robert Cochran