From: Ted Zlatanov <tzz@lifelogs.com>
To: npostavs@users.sourceforge.net
Cc: 23945@debbugs.gnu.org
Subject: bug#23945: 25.1.50; Request for review: Gnus Cloud work in scratch/gnus-cloud
Date: Tue, 19 Jul 2016 10:50:07 -0400 [thread overview]
Message-ID: <87eg6pr8bk.fsf@lifelogs.com> (raw)
In-Reply-To: <87r3aqcz7y.fsf@users.sourceforge.net> (npostavs's message of "Mon, 18 Jul 2016 19:18:09 -0400")
On Mon, 18 Jul 2016 19:18:09 -0400 npostavs@users.sourceforge.net wrote:
>> I converted `gnus-cloud-method' to a defcustom and added the necessary
>> code to set it, resolving this question.
>>
>> Since no one has been interested in reviewing this code, I will merge it
>> tomorrow.
n> Perhaps this is partly because I'm not familiar with the code (or what
n> "Gnus Cloud" is), but it seems to me that you're missing a good summary
n> line explaining what any of these changes are for. The bug title and
n> commit message summary line mentions only "Gnus Cloud work". What
n> "work"? This feels actively reviewer-hostile.
You're right. The history of this work goes back at least 4 years in the
Gnus mailing list so I was hoping Lars or someone else familiar with
that history would jump in. You can start with the most recent log of
work I did:
http://thread.gmane.org/gmane.emacs.gnus.general/85543/focus=87091
I will write docs for the feature, but simply wasn't sure about some key
aspects of it that depended on the code.
Please note I did add docstrings for most of the functions, especially
the interactive ones. But I agree that's no excuse for a lack of good
commit messages.
n> The 2nd commit titled "Minor gnus-cloud UI improvements" is a bit better
n> (at least we can tell it's about UI), though adding 20 or so "Merge
n> branch 'master' of git.sv.gnu.org:/srv/git/emacs" in between doesn't
n> help much either.
Well, that's an issue with the source code repo. I've mentioned it
before. Here's my rant:
I merge the master branch often because I have been using the gnus-cloud
branch and want to make sure it's not broken against master. I also test
and use many other new features. I really don't want to start working
outside the master branch.
But I can't rebase and push again, because the repo doesn't support
non-fast-forward pushes. I have to delete and recreate the branch
(notification emails x2, and a little bit of manual labor). But also
every time I do a push with merges, notification e-mails come out for my
changes plus everything merged. I can't win either way.
So the bottom line for me is, I'd really like notification e-mails not
to go out for "scratch/*" branches, or to be able to do a
non-fast-forward push to my scratch branch. Since neither is possible,
I'm doing the best I can for now. I am strongly considering using Github
next time (Git supports multiple remotes for a branch, so this is not
too hard) and saving myself all this trouble.
You can use `git log --no-merges' meanwhile to filter out those merge
commits. Sorry for the inconvenience.
Ted
next prev parent reply other threads:[~2016-07-19 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 15:05 bug#23945: 25.1.50; Request for review: Gnus Cloud work in scratch/gnus-cloud Teodor Zlatanov
2016-07-13 14:20 ` Ted Zlatanov
2016-07-18 14:08 ` Ted Zlatanov
2016-07-18 23:18 ` npostavs
2016-07-19 14:50 ` Ted Zlatanov [this message]
2016-07-19 20:15 ` Ted Zlatanov
2016-07-20 1:36 ` Noam Postavsky
2016-07-20 12:55 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg6pr8bk.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=23945@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).