From: npostavs@users.sourceforge.net
To: phillip.lord@russet.org.uk (Phillip Lord)
Cc: 25360@debbugs.gnu.org
Subject: bug#25360: File mode specification errors during building
Date: Sun, 15 Jan 2017 19:27:56 -0500 [thread overview]
Message-ID: <87eg03yhkj.fsf@users.sourceforge.net> (raw)
In-Reply-To: <87fukj50lt.fsf@russet.org.uk> (Phillip Lord's message of "Mon, 16 Jan 2017 00:07:10 +0000")
phillip.lord@russet.org.uk (Phillip Lord) writes:
> npostavs@users.sourceforge.net writes:
>>>> There's nothing special about hydra builds. I quote them only because
>>>> they provide a convenient way to show a full, clean build log.
>>>>
>>>> The image-type-auto-detected-p issue persists, eg
>>>> http://hydra.nixos.org/build/46502443/log/raw
>>>>
>>>> Note this is a without-x build (image-type-auto-detected-p used to be
>>>> autoloaded in all builds).
>>>
>>> Unfortunately, I cannot reproduce this on my own machine. Exactly how is
>>> the hydra build configured? I've tried --without-x, as a guess, but I
>>> get no error.
>>
>> I can reproduce here. Did you just run 'make bootstrap' after
>> reconfiguring? I think you need 'make extraclean', because the part
>> that triggers this is not cleaned by bootstrap.
>
> To my understanding, make bootstrap is at least as clean as extraclean.
I think extraclean does some more things, but actually it might not be
relevant in this case.
>
>
>> Using insert-file-contents instead of file-file-noselect seems to fix it
>> for me:
>>
>> --- i/lisp/international/titdic-cnv.el
>> +++ w/lisp/international/titdic-cnv.el
>> @@ -1167,11 +1167,11 @@ miscdic-convert
>> (if (eq coding 'iso-2022-cn-ext) "Chinese-CNS"
>> "Chinese-GB"))
>> "\" \"" title "\" t\n")
>> - (let* ((coding-system-for-read
>> - (coding-system-change-eol-conversion coding 'unix))
>> - (dicbuf (find-file-noselect filename)))
>> - (funcall converter dicbuf name title)
>> - (kill-buffer dicbuf))
>> + (let ((coding-system-for-read
>> + (coding-system-change-eol-conversion coding 'unix)))
>> + (with-temp-buffer
>> + (insert-file-contents filename)
>> + (funcall converter (current-buffer) name title)))
>> (insert ";; Local Variables:\n"
>> ";; version-control: never\n"
>> ";; no-update-autoloads: t\n"
>
> Confused. What thing are you reproducing? The
> "image-type-auto-detected-p" or File mode specification error:
> (void-function html-mode) error?
Here is the command I found was problematic during the build (I added
the rm -f part, otherwise the file generation is skipped).
cd /home/npostavs/src/emacs/emacs-bootstrapping/leim && rm -f ../lisp/leim/quail/tsang-b5.el ../lisp/leim/quail/quick-b5.el && EMACSLOADPATH= '../src/bootstrap-emacs' --batch --no-site-file --no-site-lisp -l titdic-cnv.el -f batch-miscdic-convert -dir ./../lisp/leim/quail MISC-DIC/cangjie-table.b5
Converting cangjie-table.b5 to tsang-b5.el...
File mode specification error: (wrong-type-argument stringp image-type-auto-detected-p)
Converting cangjie-table.b5 to tsang-b5.el...done
Converting cangjie-table.b5 to quick-b5.el...
File mode specification error: (wrong-type-argument stringp image-type-auto-detected-p)
Converting cangjie-table.b5 to quick-b5.el...done
The patch I posted fixes these errors.
> The "find-file-noselect" call is responsible for the "html-mode" error,
> but that should have been fixed with this commit.
>
> commit 72c668a9042ac6475eadedfee5c87fb1e6b2d753
> Author: Phillip Lord <phillip.lord@russet.org.uk>
> Date: Fri Jan 13 13:57:51 2017 +0000
>
> But this commit also stops the image-type-auto-detected-p errors for me.
Does the following print something non-nil for you? For me it's nil
when I configure --without-x, and a byte code function value otherwise.
./bootstrap-emacs -batch -Q --eval '(message "%S" (symbol-function (quote image-type-auto-detected-p)))'
next prev parent reply other threads:[~2017-01-16 0:27 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 20:28 bug#25360: File mode specification errors during building Glenn Morris
2017-01-07 8:03 ` Eli Zaretskii
2017-01-09 13:06 ` Phillip Lord
2017-01-10 10:21 ` Phillip Lord
2017-01-10 15:13 ` Eli Zaretskii
2017-01-10 18:40 ` Phillip Lord
2017-01-10 18:48 ` Eli Zaretskii
2017-01-13 14:08 ` Phillip Lord
2017-01-13 14:19 ` Eli Zaretskii
2017-01-13 21:31 ` Phillip Lord
2017-01-14 19:09 ` Glenn Morris
2017-01-15 22:05 ` Phillip Lord
2017-01-15 23:53 ` npostavs
2017-01-16 0:07 ` Phillip Lord
2017-01-16 0:27 ` npostavs [this message]
2017-01-17 17:38 ` Glenn Morris
2017-01-17 21:49 ` Phillip Lord
2017-01-17 17:42 ` Glenn Morris
2017-01-17 22:04 ` Phillip Lord
2017-01-18 1:11 ` npostavs
2017-01-19 10:45 ` Phillip Lord
2017-01-19 16:05 ` Eli Zaretskii
2017-01-19 17:06 ` Noam Postavsky
2017-01-20 13:43 ` Phillip Lord
2017-01-21 21:11 ` Phillip Lord
2017-01-23 12:44 ` Phillip Lord
2017-01-23 14:16 ` npostavs
2017-01-24 12:42 ` Phillip Lord
2017-01-24 13:12 ` npostavs
2017-01-23 15:38 ` Eli Zaretskii
2017-01-24 12:51 ` Phillip Lord
2017-01-24 15:52 ` Eli Zaretskii
2017-02-06 10:31 ` Phillip Lord
2017-02-06 15:41 ` Eli Zaretskii
2017-02-13 2:06 ` Glenn Morris
2017-02-13 2:15 ` Glenn Morris
2017-02-13 2:22 ` Glenn Morris
2017-02-14 13:46 ` Phillip Lord
2017-02-19 0:36 ` Glenn Morris
2017-02-19 21:40 ` Phillip Lord
2017-02-22 19:08 ` Glenn Morris
2017-03-01 16:55 ` Phillip Lord
2017-03-02 15:20 ` Eli Zaretskii
2017-03-02 17:57 ` martin rudalics
2017-03-02 20:12 ` Eli Zaretskii
2017-03-04 10:02 ` Eli Zaretskii
2017-03-04 10:32 ` Phillip Lord
2017-03-04 11:11 ` Eli Zaretskii
2017-03-04 11:28 ` Eli Zaretskii
2017-03-06 15:33 ` Phillip Lord
2017-03-06 19:56 ` Noam Postavsky
2017-03-06 20:53 ` Eli Zaretskii
2017-03-06 21:10 ` Noam Postavsky
2017-03-06 21:25 ` Phillip Lord
2017-03-07 3:31 ` Eli Zaretskii
2017-03-07 12:26 ` Phillip Lord
2017-03-07 15:28 ` Phillip Lord
2017-03-07 16:01 ` Eli Zaretskii
2017-03-07 18:25 ` Noam Postavsky
2017-03-07 19:35 ` Phillip Lord
2017-03-08 12:31 ` Phillip Lord
2017-03-07 15:51 ` Eli Zaretskii
2017-03-05 18:26 ` Andy Moreton
2017-03-05 18:58 ` Phillip Lord
2017-03-05 20:08 ` Eli Zaretskii
2017-03-06 12:07 ` Andy Moreton
2017-03-06 16:31 ` Phillip Lord
2017-03-06 23:26 ` Andy Moreton
2017-03-06 16:30 ` Phillip Lord
2017-03-06 18:38 ` Eli Zaretskii
2017-01-25 22:46 ` Glenn Morris
2017-01-27 16:25 ` Phillip Lord
2017-02-13 2:07 ` Glenn Morris
2017-01-13 14:22 ` Eli Zaretskii
2017-01-13 16:47 ` Phillip Lord
2017-01-10 17:47 ` Glenn Morris
2017-01-10 18:50 ` Phillip Lord
2017-01-11 16:36 ` Richard Stallman
2017-01-13 14:05 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg03yhkj.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=25360@debbugs.gnu.org \
--cc=phillip.lord@russet.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).