From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#26360: 26.0.50; ido-mode doesn't enable IDO for C-x 4 d Date: Thu, 20 Apr 2017 23:29:53 -0400 Message-ID: <87efwmqvym.fsf@users.sourceforge.net> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1492745358 22266 195.159.176.226 (21 Apr 2017 03:29:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 21 Apr 2017 03:29:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: 26360@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 21 05:29:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1PFt-0005dM-9y for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Apr 2017 05:29:09 +0200 Original-Received: from localhost ([::1]:56893 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1PFx-0008LW-Fp for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Apr 2017 23:29:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1PFr-0008KM-Ff for bug-gnu-emacs@gnu.org; Thu, 20 Apr 2017 23:29:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d1PFm-0000kl-Jf for bug-gnu-emacs@gnu.org; Thu, 20 Apr 2017 23:29:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33152) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d1PFm-0000kd-Fj for bug-gnu-emacs@gnu.org; Thu, 20 Apr 2017 23:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d1PFm-0004sM-3i for bug-gnu-emacs@gnu.org; Thu, 20 Apr 2017 23:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Apr 2017 03:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26360 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26360-submit@debbugs.gnu.org id=B26360.149274531218704 (code B ref 26360); Fri, 21 Apr 2017 03:29:02 +0000 Original-Received: (at 26360) by debbugs.gnu.org; 21 Apr 2017 03:28:32 +0000 Original-Received: from localhost ([127.0.0.1]:59584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1PFH-0004rX-Tg for submit@debbugs.gnu.org; Thu, 20 Apr 2017 23:28:32 -0400 Original-Received: from mail-io0-f181.google.com ([209.85.223.181]:36327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1PFF-0004rE-TZ; Thu, 20 Apr 2017 23:28:30 -0400 Original-Received: by mail-io0-f181.google.com with SMTP id o22so109830779iod.3; Thu, 20 Apr 2017 20:28:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=1p2jWBSdiqLn8sxF/pghaMAXX8kUcn6ZQ4TsqkWVD+M=; b=lJ2xxDbDuNIp6BfhPq+O43KE6Yd66OOS0hjloRltU6DMbelVujWq7kup4oX/qVtwWy x1b8lYlqVKOxgvXca9vTvQluYGYkpVEXQu222goQkfurFgTorLX86dB1Sf7c7PXCdJkD JVlgRh4xQEQ/N1bC4sBAUWCaYURvLSie9Mn4LONQeLUwUPay7kJtsMp3TypuJZ95DTtp J+2jdifzPbZVIUmsd/zcswpPP9JFrf1ZhtZLN8Q1sxEImMEtWjsaA35DiGe/fcAgUISj MnHLzccrYBiPxUhKUFSKGzgdJCwJ9iDKXU8er/W3bGJqcVqkgar3AWpe4J8J9uZypwNR oWEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=1p2jWBSdiqLn8sxF/pghaMAXX8kUcn6ZQ4TsqkWVD+M=; b=qOHdQE3TWJD0USQe1N4RKfp8yYxgFTQDaxAZU/rlosIBapdmwKa+ZoIcFRJwYmQcgO tW7FQrZsIkd19ztgs/2TbsKiq/q0x6F/3pdjJ0x/+bpZB7pXh7atBftncLeKisZ8WIYr 90YC9eUwzoxNfTK6APWJDP6+8ccxEw7fsqEVbdRM/jMtjgnQZqp+qfWJoo/oWDk+gR8y Ygqzrzv+AhiqgjG5hb1qb0L0ewHj+PXU4BTmLS5yAOi1J/kzCjW6EdUejPwLJlz/OKwr fU+PXImoRnhYSW+VAqHWkQEN3ibB9iQ0/jc9AJLgwaczviy7z4EW0SV1NhsREpec76Re hraw== X-Gm-Message-State: AN3rC/4mJvgl7H6WNvRR2MTXajxfzL/CyTrX9kCv6nz8pRirhXjOZJ85 yXT/QmrNdiUrEQ== X-Received: by 10.107.59.1 with SMTP id i1mr13821861ioa.18.1492745304327; Thu, 20 Apr 2017 20:28:24 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id e8sm354454itd.3.2017.04.20.20.28.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Apr 2017 20:28:23 -0700 (PDT) In-Reply-To: (Philipp Stephani's message of "Thu, 20 Apr 2017 13:45:09 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:131810 Archived-At: tags 26360 patch quit Philipp Stephani writes: > > Here's a patch (which includes a couple of other commands). Patch looks good, except the test seems redundant to me. I don't think it's useful to test that a command is defined, or testing that specific keybindings have been set (i.e., no need to test again that `defun' or `define-key' are working). Also, it would fail if run from a non-default emacs configuration that has changed the keybindings.