From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Gemini Lasswell Newsgroups: gmane.emacs.bugs Subject: bug#27746: 26.0.50; Need a better test of whether running on Hydra than $NIX_STORE Date: Mon, 17 Jul 2017 19:03:16 -0700 Message-ID: <87eftepkm3.fsf@chinook> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1500343453 11286 195.159.176.226 (18 Jul 2017 02:04:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Jul 2017 02:04:13 +0000 (UTC) Cc: michael.albinus@gmx.de To: 27746@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 18 04:04:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXHrq-0002dB-Ax for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Jul 2017 04:04:06 +0200 Original-Received: from localhost ([::1]:53460 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXHrv-00008p-QS for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Jul 2017 22:04:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXHrp-00008Q-Rz for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2017 22:04:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXHrm-00031y-OT for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2017 22:04:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42457) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXHrm-00031q-KT for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2017 22:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dXHrl-0005oO-W6; Mon, 17 Jul 2017 22:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gemini Lasswell Original-Sender: "Debbugs-submit" Resent-CC: michael.albinus@gmx.de, bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jul 2017 02:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 27746 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: michael.albinus@gmx.de Original-Received: via spool by submit@debbugs.gnu.org id=B.150034343222323 (code B ref -1); Tue, 18 Jul 2017 02:04:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Jul 2017 02:03:52 +0000 Original-Received: from localhost ([127.0.0.1]:45132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXHrb-0005nz-SG for submit@debbugs.gnu.org; Mon, 17 Jul 2017 22:03:52 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXHrY-0005nj-VQ for submit@debbugs.gnu.org; Mon, 17 Jul 2017 22:03:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXHrS-0002sT-TC for submit@debbugs.gnu.org; Mon, 17 Jul 2017 22:03:43 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:34745) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dXHrS-0002sO-QY for submit@debbugs.gnu.org; Mon, 17 Jul 2017 22:03:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXHrR-0008PQ-LD for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2017 22:03:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXHrO-0002qa-Hy for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2017 22:03:41 -0400 Original-Received: from aibo.runbox.com ([91.220.196.211]:59058) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXHrO-0002pn-87 for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2017 22:03:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From; bh=bzV3s1bcNbb+G9lbIBRgTi2tr5qo5ZNhHMjhncrlcQ0=; b=f0icqNBbpmGWnQvSKgL4MOHNp CVUe4qCXQkzPdx4MARoxLlJHAVZZvzVBQe+loYZXEsaclXEfCsWgk/1Y8OhvXivICLk5ijpoY/ipE 52Y7zIj1cvVQ4pk4zsjhIzFnFZdWRZoSHJM923d6GA1WX+qo6VAEA3OLKtkZV0lIAgia1HBqXgy7q Gz1OJ/4z5DfUtovNwesaeQrrHgyakQGLgvI9pzj00ws/4GIvHIPvUvLMkE/jK5vUnx08BmR1jDcEJ hk+XZJfRNDrcrFtDqKaTo14ZolPpzSnfHgzIl+e9bsWO0E63p8fNVNUnwm+mCHPTVxTdzWop0eZzY TcCQHSqIg==; Original-Received: from [10.9.9.211] (helo=mailfront11.runbox.com) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1dXHrM-0004zB-97 for bug-gnu-emacs@gnu.org; Tue, 18 Jul 2017 04:03:36 +0200 Original-Received: from c-24-22-244-161.hsd1.wa.comcast.net ([24.22.244.161] helo=chinook) by mailfront11.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1dXHrB-0003V1-Ok for bug-gnu-emacs@gnu.org; Tue, 18 Jul 2017 04:03:26 +0200 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134694 Archived-At: There are places in the test code in Emacs which use the existence of the NIX_STORE environment variable to change test behavior when running on Hydra. However, Emacs should have a different and more specific test for whether it is running on Hydra, so that those behavior changes don't happen on other machines running NixOS or the Nix package manager. I noticed this because of Michael Albinus's recent addition of some NIX_STORE checks to test/Makefile.in and tramp-tests.el in an attempt to track down test failures on Hydra. Those changes cause tramp-tests.el to run much slower on my machine and spam its logfile to standard output. In addition, checks of NIX_STORE cause a few eieio tests to be skipped and ERT to print more detailed test summaries. Then there's this bit of code, found in both tramp-tests.el and filenotify-tests.el: ;; This shall happen on hydra only. (when (getenv "NIX_STORE") (add-to-list 'tramp-remote-path 'tramp-own-remote-path)) which looks a bit backwards to me because changing tramp-remote-path is necessary on my Mac to make Tramp able to talk to a NixOS (or Guix) machine. But it's not necessary to change tramp-remote-path to make Tramp on the NixOS machine remotely connect to the Mac. Presumably Hydra is always talking to another NixOS machine here, and the use of NIX_STORE should be replaced by something more specific to Hydra. But it would be more generally correct to look at the value of NIX_STORE on the machine that REMOTE_TEMPORARY_FILE_DIRECTORY points to.