From: Gemini Lasswell <gazally@runbox.com>
To: 27746@debbugs.gnu.org
Cc: michael.albinus@gmx.de
Subject: bug#27746: 26.0.50; Need a better test of whether running on Hydra than $NIX_STORE
Date: Mon, 17 Jul 2017 19:03:16 -0700 [thread overview]
Message-ID: <87eftepkm3.fsf@chinook> (raw)
There are places in the test code in Emacs which use the existence of
the NIX_STORE environment variable to change test behavior when
running on Hydra. However, Emacs should have a different and more
specific test for whether it is running on Hydra, so that those
behavior changes don't happen on other machines running NixOS or the
Nix package manager.
I noticed this because of Michael Albinus's recent addition of some
NIX_STORE checks to test/Makefile.in and tramp-tests.el in an attempt
to track down test failures on Hydra. Those changes cause
tramp-tests.el to run much slower on my machine and spam its logfile
to standard output.
In addition, checks of NIX_STORE cause a few eieio tests to be skipped
and ERT to print more detailed test summaries. Then there's this bit
of code, found in both tramp-tests.el and filenotify-tests.el:
;; This shall happen on hydra only.
(when (getenv "NIX_STORE")
(add-to-list 'tramp-remote-path 'tramp-own-remote-path))
which looks a bit backwards to me because changing tramp-remote-path
is necessary on my Mac to make Tramp able to talk to a NixOS (or Guix)
machine. But it's not necessary to change tramp-remote-path to make
Tramp on the NixOS machine remotely connect to the Mac. Presumably
Hydra is always talking to another NixOS machine here, and the use of
NIX_STORE should be replaced by something more specific to Hydra. But
it would be more generally correct to look at the value of NIX_STORE
on the machine that REMOTE_TEMPORARY_FILE_DIRECTORY points to.
next reply other threads:[~2017-07-18 2:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 2:03 Gemini Lasswell [this message]
2017-07-18 7:04 ` bug#27746: 26.0.50; Need a better test of whether running on Hydra than $NIX_STORE Michael Albinus
2017-07-18 16:56 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eftepkm3.fsf@chinook \
--to=gazally@runbox.com \
--cc=27746@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).