From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Gemini Lasswell Newsgroups: gmane.emacs.bugs Subject: bug#24402: should-error doesn't catch all errors Date: Wed, 19 Jul 2017 14:23:12 -0700 Message-ID: <87eftcglz3.fsf@runbox.com> References: <3654D8E9-D3CB-402B-922F-B132C1871E9F@runbox.com> <596E65D2-E780-43A1-A75B-603B61B6F9F4@runbox.com> <87zickhoco.fsf_-_@lylat> <877eznda7v.fsf@lylat> <874lur0zki.fsf@calancha-pc> <87o9sywtbz.fsf@lylat> <87fue3f9p8.fsf@users.sourceforge.net> <87vamyl3j3.fsf@lylat> <87tw2het1b.fsf@users.sourceforge.net> <874luhbo4l.fsf@lylat> <87lgntdswo.fsf@users.sourceforge.net> <87k23d9gvt.fsf@lylat> <87d195dmr0.fsf@users.sourceforge.net> <87lgns7y7g.fsf@lylat> <877ezbew3d.fsf@users.sourceforge.net> <87d193ljdp.fsf@lylat> <87shhxcqit.fsf@users.sourceforge.net> <87inithwi5.fsf@lylat> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1500499462 30249 195.159.176.226 (19 Jul 2017 21:24:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Jul 2017 21:24:22 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: npostavs@users.sourceforge.net, Tino Calancha , 24402@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 19 23:24:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXwRy-00074p-5k for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Jul 2017 23:24:06 +0200 Original-Received: from localhost ([::1]:35063 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXwS3-0003OT-HL for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Jul 2017 17:24:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXwRx-0003ON-Fj for bug-gnu-emacs@gnu.org; Wed, 19 Jul 2017 17:24:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXwRu-0005Yb-8x for bug-gnu-emacs@gnu.org; Wed, 19 Jul 2017 17:24:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45517) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXwRt-0005Xq-TA for bug-gnu-emacs@gnu.org; Wed, 19 Jul 2017 17:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dXwRt-0005PL-J2 for bug-gnu-emacs@gnu.org; Wed, 19 Jul 2017 17:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gemini Lasswell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jul 2017 21:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 24402-submit@debbugs.gnu.org id=B24402.150049941920756 (code B ref 24402); Wed, 19 Jul 2017 21:24:01 +0000 Original-Received: (at 24402) by debbugs.gnu.org; 19 Jul 2017 21:23:39 +0000 Original-Received: from localhost ([127.0.0.1]:48194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXwRX-0005Oi-5U for submit@debbugs.gnu.org; Wed, 19 Jul 2017 17:23:39 -0400 Original-Received: from aibo.runbox.com ([91.220.196.211]:36346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXwRU-0005OY-M2 for 24402@debbugs.gnu.org; Wed, 19 Jul 2017 17:23:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=w6zrNdaqgPLU7P/hymInqQkuR5mS2KVewcR+LGMFxZI=; b=Uo9Qk2rG0HEziglda+2Ugq4BO/ uTYjA5saX1ERGJvTA1eMB9W8mmFy3l+ZrzKu6OovrUyhWctddJcQcTrcMkbr2bbrCn2dA7HOPiYlA f8IJHLBxTLSsalXg5tTDsJ+OO2MPouk/F6LINmymsXZ7yM6wT++Ot4Cu4v+iCiJvnvu+KNeKI6lze oO1VRp9eUlTG2iaJz+voXFEouzIJufBbLAirs/gq9Nm+ERlEzCh1o/A/QStKZGradmu6IUGFV1lTV P990i0Jm7gPSZ8ddBOoI6pX70JWB/WKW4WwSKi3BVC2DgmEM0JtJo61Pe/L6FzMTBXlWL4DvxnmYg ofuMMXIw==; Original-Received: from [10.9.9.210] (helo=mailfront10.runbox.com) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1dXwRR-00086G-FU; Wed, 19 Jul 2017 23:23:33 +0200 Original-Received: from c-24-22-244-161.hsd1.wa.comcast.net ([24.22.244.161] helo=chinook) by mailfront10.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1dXwRJ-0007vq-Bx; Wed, 19 Jul 2017 23:23:25 +0200 In-Reply-To: <87inithwi5.fsf@lylat> (Alex's message of "Sat, 15 Jul 2017 21:49:06 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134766 Archived-At: --=-=-= Content-Type: text/plain Hello, First, thank you for working on this bug! I have a branch of Emacs which attempts to run all the tests under Testcover, and I've tried it with Alex's latest patch. The patch has fixed the problems with Testcover and should-error except for one weird case. Here is a file that will let you reproduce the weird case on master with the patch applied: --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=cyc-test.el (defun cyc1 (a) (let ((ls (make-list 10 a))) (nconc ls ls) ls)) (ert-deftest test-cycle-assq () (let ((c1 (cyc1 '(1)))) (should-error (assq 3 c1) :type 'circular-list))) (ert-deftest test-cycle-assoc () (let ((c1 (cyc1 '(1)))) (should-error (assoc 2 c1) :type 'circular-list))) (defvar testcover-started nil) (unless testcover-started (setq testcover-started t) (testcover-start (or load-file-name (buffer-file-name)))) --=-=-= Content-Type: text/plain This is an excerpt of test/src/fns-tests.el with a few lines added at the end to invoke Testcover. It contains two nearly identical tests which should both pass, but one passes and one fails. If you then edit the file and comment out test-cycle-assoc (the one that passes) and run the test again, then the failing test will pass. I've reproduced it both in batch mode (without TEST_LOAD_EL=no) and interactively. --=-=-=--