From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24402: should-error doesn't catch all errors Date: Mon, 07 Aug 2017 21:15:14 -0400 Message-ID: <87efsm507x.fsf@users.sourceforge.net> References: <3654D8E9-D3CB-402B-922F-B132C1871E9F@runbox.com> <596E65D2-E780-43A1-A75B-603B61B6F9F4@runbox.com> <87zickhoco.fsf_-_@lylat> <877eznda7v.fsf@lylat> <874lur0zki.fsf@calancha-pc> <87o9sywtbz.fsf@lylat> <87fue3f9p8.fsf@users.sourceforge.net> <87vamyl3j3.fsf@lylat> <87tw2het1b.fsf@users.sourceforge.net> <874luhbo4l.fsf@lylat> <87lgntdswo.fsf@users.sourceforge.net> <87k23d9gvt.fsf@lylat> <87d195dmr0.fsf@users.sourceforge.net> <87lgns7y7g.fsf@lylat> <877ezbew3d.fsf@users.sourceforge.net> <87d193ljdp.fsf@lylat> <87shhxcqit.fsf@users.sourceforge.net> <87inithwi5.fsf@lylat> <87eftcglz3.fsf@runbox.com> <87y3rk9gfa.fsf@users.sourceforge.net> <87bmoehpzm.fsf@runbox.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1502154875 12650 195.159.176.226 (8 Aug 2017 01:14:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 8 Aug 2017 01:14:35 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 24402@debbugs.gnu.org, Alex , Tino Calancha To: Gemini Lasswell Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 08 03:14:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1det64-0002GS-LS for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Aug 2017 03:14:12 +0200 Original-Received: from localhost ([::1]:40292 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1det6A-0003fw-UD for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Aug 2017 21:14:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1det5z-0003fL-2I for bug-gnu-emacs@gnu.org; Mon, 07 Aug 2017 21:14:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1det5t-0001dk-Ty for bug-gnu-emacs@gnu.org; Mon, 07 Aug 2017 21:14:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42226) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1det5t-0001dg-QD for bug-gnu-emacs@gnu.org; Mon, 07 Aug 2017 21:14:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1det5t-0007m9-KI for bug-gnu-emacs@gnu.org; Mon, 07 Aug 2017 21:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Aug 2017 01:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 24402-submit@debbugs.gnu.org id=B24402.150215482829862 (code B ref 24402); Tue, 08 Aug 2017 01:14:01 +0000 Original-Received: (at 24402) by debbugs.gnu.org; 8 Aug 2017 01:13:48 +0000 Original-Received: from localhost ([127.0.0.1]:50907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1det5g-0007lY-3N for submit@debbugs.gnu.org; Mon, 07 Aug 2017 21:13:48 -0400 Original-Received: from mail-it0-f68.google.com ([209.85.214.68]:38171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1det5c-0007lA-E9; Mon, 07 Aug 2017 21:13:44 -0400 Original-Received: by mail-it0-f68.google.com with SMTP id f16so1511199itb.5; Mon, 07 Aug 2017 18:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XGBs8tMgz/VjskFa0fp4I6jm5swU9vC+wuF30b+TGQo=; b=rc8nWGmCz5ikSPivan4+E3Pf6hEBhBtLRPoXS1kYfN4CjK7uhrsrO7Kgetdu2AsnjQ Ew2l3BsDkd20cI1CtTe77wQ1JYC9GNb21PRnbH7Vnx5Cs5c81ZBWRLpBkJ8dKiPc3WaP DPBqADWHPftVe6fUIueyw5vfAXyugnhjRlA9AsoSLptLkEqWh+EaabrxeR09QyO+7kBb vow5r3KAHZj1V63uO8HQCjWtM4TTFg0yhbroDWgW1bDlh73xZalmpTPXvX2GGH9EZt6x Dq3WKGFeN2cOdgk6ph0rt68k08pWcDIs8fsIz/AszFOvytocyQn5Ffc/XpF89wbmT3KH 8Qow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=XGBs8tMgz/VjskFa0fp4I6jm5swU9vC+wuF30b+TGQo=; b=ZEHm2vcJLPQVmZsUDWSqPcMNzL/1SE84tx18kR2GVvjlHBinEkMtjXmKooshmMOP3r uKPVN/utBOYHxk55nqAdEeRTLaOIwRQ/KrR/ucZvCF3j5pwSeMo83Lz+VbgAR2v8DDc/ VgtqxMv+/XWWxe+4w4fvOSNlsn3xVJ+6JZpNMvncwqqGc2iWzF9dccX4CqzDpzfSokpK M3fjOR+GiZb98XE1LHv6q/O29YCKUs8aFgFJ42oqPCl5AT4mdiJDFLHbXseyJuQYDevA 7rhJkPRvhUyNSspC/Hc80NRD3HN2J+I3CBBNWArY7O+TRJWk+tQv+FnlUlYoFma25o/M 1ahQ== X-Gm-Message-State: AIVw113qv7OIGV5w83eIa9kTJ/MlQ/ZQDHOTSeLqb1JVrWx8haJf2yBh wz5sAYeGcRPyfJNX X-Received: by 10.36.121.207 with SMTP id z198mr2806191itc.83.1502154818673; Mon, 07 Aug 2017 18:13:38 -0700 (PDT) Original-Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id y28sm3709973ita.2.2017.08.07.18.13.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Aug 2017 18:13:37 -0700 (PDT) In-Reply-To: <87bmoehpzm.fsf@runbox.com> (Gemini Lasswell's message of "Thu, 20 Jul 2017 12:23:25 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135559 Archived-At: tags 24402 fixed close 24402 26.1 quit Sorry for the delay, I was moving apartment, and then I got a bit distracted by my 'grep --null' mess. Gemini Lasswell writes: > npostavs@users.sourceforge.net writes: > >> The following appears to fix it, though perhaps we should use a smarter >> equal function that would consider the circular lists to actually be >> equal instead of bailing out and returning nil on circularity. > > Thanks for tracking this one down and making a patch, which looks good > to me. Does that smarter equal function already exist? It doesn't seem > worth the effort of writing one for this purpose only. Yeah, I left it as is with a TODO. We can fix it later if it turns out to cause an actual problem. > Here is a test to add to your patch, which fails without it and passes > with it: Thanks, I pushed it to master along with the others. [1: 054c198c12]: 2017-08-07 18:43:54 -0400 Catch argument and macroexpansion errors in ert http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=054c198c120c1f01a8ff753892d52710b740acc6 [2: 95a04fd26c]: 2017-08-07 18:43:55 -0400 ; Avoid test failures when running from compiled test files http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=95a04fd26c91e6c6c9191a629d26886f136e30fc [3: 0508045ed7]: 2017-08-07 18:54:44 -0400 Don't error on circular values in testcover http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0508045ed7159bce5b5ea3b5fb72cf78b8b4ee8e [4: 00f7e31110]: 2017-08-07 18:54:48 -0400 Add a test of handling of circular values to testcover-tests http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=00f7e31110a27e568529192d7441d9631b9096bc