From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: handa Newsgroups: gmane.emacs.bugs Subject: bug#30193: crash in libotf Date: Tue, 23 Jan 2018 23:30:24 +0900 Message-ID: <87efmgzlz3.fsf@gnu.org> References: <87o9lnv8oe.fsf@jidanni.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1516717988 27859 195.159.176.226 (23 Jan 2018 14:33:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 23 Jan 2018 14:33:08 +0000 (UTC) Cc: 30193@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 23 15:33:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edzd6-0006Hs-1z for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jan 2018 15:32:52 +0100 Original-Received: from localhost ([::1]:32926 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edzf6-0003CJ-GG for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jan 2018 09:34:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edzbN-00018F-Qz for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 09:31:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edzbK-0004aM-MR for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 09:31:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59564) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edzbK-0004aE-Iy for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 09:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1edzbK-0006gg-BM for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 09:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: handa Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jan 2018 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30193 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30193-submit@debbugs.gnu.org id=B30193.151671784725683 (code B ref 30193); Tue, 23 Jan 2018 14:31:02 +0000 Original-Received: (at 30193) by debbugs.gnu.org; 23 Jan 2018 14:30:47 +0000 Original-Received: from localhost ([127.0.0.1]:39228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edzb5-0006gA-Bp for submit@debbugs.gnu.org; Tue, 23 Jan 2018 09:30:47 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:46590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edzb1-0006fw-O0 for 30193@debbugs.gnu.org; Tue, 23 Jan 2018 09:30:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edzat-0004Sx-AZ for 30193@debbugs.gnu.org; Tue, 23 Jan 2018 09:30:38 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edzat-0004St-7E for 30193@debbugs.gnu.org; Tue, 23 Jan 2018 09:30:35 -0500 Original-Received: from fl1-125-192-56-244.iba.mesh.ad.jp ([125.192.56.244]:58588 helo=shatin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1edzar-00061i-N9; Tue, 23 Jan 2018 09:30:34 -0500 Original-Received: from handa by shatin with local (Exim 4.86_2) (envelope-from ) id 1edzai-0007oA-BC; Tue, 23 Jan 2018 23:30:24 +0900 In-Reply-To: <63zi57dpmv.fsf_-_@fencepost.gnu.org> (message from Glenn Morris on Sun, 21 Jan 2018 13:37:44 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142426 Archived-At: In article <63zi57dpmv.fsf_-_@fencepost.gnu.org>, Glenn Morris writes: > Eli Zaretskii wrote: > > The crash seems to be inside the libotf/libm17n-flt library; CC'ing > > Handa-san who may have comments on this. > > > > Meanwhile, please make sure you have the latest versions of these > > libraries installed. > Still crashes with emacs-26 and latest m17n libs. > (Ie libotf 0.9.13 from 2012 and the m17n 1.8 RC from 2017) Sorry for being late. I've just committed the attached fix to the CVS repository of libotf. You can get the source by: % cvs -z3 -d:pserver:anonymous@cvs.savannah.nongnu.org:/sources/m17n co libotf I am going to release the new version of libotf within a few weeks. --- K. Handa handa@gnu.org 2018-01-23 K. Handa * src/otfopen.c (read_class_def): Handle the case of f.f1.GlyphCount and f.f2.ClassRangeCount being 0 gracefully. --- otfopen.c.~1.65.~ 2015-03-27 15:14:46.000000000 +0900 +++ otfopen.c 2018-01-23 22:40:04.740168815 +0900 @@ -1040,8 +1040,6 @@ = read_glyph_ids (otf, stream, (OTF_GlyphID **) &class->f.f1.ClassValueArray, 0, -1); - if (! class->f.f1.GlyphCount) - return -1; } else if (class->ClassFormat == 2) { @@ -1049,8 +1047,6 @@ = read_range_records (otf, stream, (OTF_RangeRecord **) &class->f.f2.ClassRangeRecord); - if (! class->f.f2.ClassRangeCount) - return -1; } else OTF_ERROR (OTF_ERROR_TABLE, " (Invalid format)");