From: Nikolaus Rath <Nikolaus@rath.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: schwab@suse.de, larsi@gnus.org, 21057@debbugs.gnu.org
Subject: bug#21057: [PATCH] nnimap.el: add support for IMAP namespaces
Date: Fri, 20 Jul 2018 20:16:38 +0100 [thread overview]
Message-ID: <87effx7m5l.fsf@vostro.rath.org> (raw)
In-Reply-To: <83h8ku1bu9.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Jul 2018 12:43:42 +0300")
On Jul 20 2018, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Nikolaus Rath <nikolaus@rath.org>
>> Cc: larsi@gnus.org, schwab@suse.de, 21057@debbugs.gnu.org
>> Date: Tue, 17 Jul 2018 20:43:35 +0100
>>
>> On Sat, 7 Jul 2018, at 10:12, Eli Zaretskii wrote:
>> > > From: Nikolaus Rath <nikolaus@rath.org>
>> > > Date: Tue, 03 Jul 2018 08:40:59 +0100
>> > > Cc: Andreas Schwab <schwab@suse.de>, 21057@debbugs.gnu.org
>> > >
>> > > *ping*
>> > >
>> > > Could someone take a look at the revised patch?
>> >
>> > Sorry it takes us this long to review your contribution.
>> >
>> > Lars, any further comments? If not, I'd like to push this to the
>> > master branch.
>>
>> Anything I can do to help?
>
> I was going to just apply your changes, but that failed: first, the
> patch includes changes to lisp/ChangeLog, which we no longer have; and
> second, nnimap.el is not in lisp, it's in lisp/gnus/. I tried to edit
> the patch to fix these issues, but then "git am" still failed claiming
> that the patch wouldn't apply.
Are you sure that you tried to apply the right patch? The patches in
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=21057#37 all refer to
lisp/gnus/nnimap.el and do not contain any ChangeLog file:
$ grep diff *.patch
0001-nnimap.el-factor-out-nnimap-group-to-imap.patch:diff --git a/lisp/gnus/nnimap.el b/lisp/gnus/nnimap.el
0002-nnimap.el-Add-support-for-IMAP-namespaces.patch:diff --git a/doc/misc/gnus.texi b/doc/misc/gnus.texi
0002-nnimap.el-Add-support-for-IMAP-namespaces.patch:diff --git a/etc/NEWS b/etc/NEWS
0002-nnimap.el-Add-support-for-IMAP-namespaces.patch:diff --git a/lisp/gnus/nnimap.el b/lisp/gnus/nnimap.el
0003-Turn-nnimap-namespaces-into-a-defvoo-to-make-it-per-.patch:diff --git a/lisp/gnus/nnimap.el b/lisp/gnus/nnimap.el
Best,
-Nikolaus
--
GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F
»Time flies like an arrow, fruit flies like a Banana.«
next prev parent reply other threads:[~2018-07-20 19:16 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87si8qjhca.fsf@vostro.rath.org>
2017-01-26 19:40 ` bug#21057: [PATCH] nnimap.el: add support for IMAP namespaces Lars Ingebrigtsen
2017-09-05 15:18 ` Nikolaus Rath
2017-09-05 15:26 ` Nikolaus Rath
2017-09-05 15:36 ` Andreas Schwab
2017-09-07 16:01 ` Nikolaus Rath
2017-09-13 17:30 ` Lars Ingebrigtsen
2017-09-17 8:16 ` Nikolaus Rath
2017-12-06 14:25 ` Nikolaus Rath
2017-12-27 21:10 ` Lars Ingebrigtsen
2018-05-31 11:38 ` Nikolaus Rath
2018-07-03 7:40 ` Nikolaus Rath
2018-07-07 9:12 ` Eli Zaretskii
2018-07-17 19:43 ` Nikolaus Rath
2018-07-20 9:43 ` Eli Zaretskii
2018-07-20 19:16 ` Nikolaus Rath [this message]
2018-07-20 19:50 ` Eli Zaretskii
2018-07-22 13:31 ` Lars Ingebrigtsen
2018-07-23 6:00 ` Eric Abrahamsen
2018-07-23 7:03 ` Lars Ingebrigtsen
2018-07-23 7:22 ` Nikolaus Rath
2018-07-23 7:39 ` Lars Ingebrigtsen
2018-07-23 8:58 ` Nikolaus Rath
2018-07-23 9:00 ` Lars Ingebrigtsen
2018-07-23 9:01 ` Lars Ingebrigtsen
2018-07-23 9:53 ` Nikolaus Rath
2018-07-23 11:28 ` Robert Pluim
2018-07-23 18:00 ` Nikolaus Rath
2018-07-27 7:54 ` Nikolaus Rath
2018-08-05 9:54 ` Nikolaus Rath
2018-08-11 7:49 ` Eli Zaretskii
2018-07-23 16:47 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87effx7m5l.fsf@vostro.rath.org \
--to=nikolaus@rath.org \
--cc=21057@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).