From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#32504: [PATCH] syntax-is-{comment|string}-p Date: Thu, 30 Aug 2018 09:39:52 -0500 Message-ID: <87efefgbpj.fsf@gmail.com> References: <87o9dup3ow.fsf@gmail.com> <871sapwzbp.fsf@gmail.com> <87lg8xtexb.fsf@gmail.com> <83a7pdb2x4.fsf@gnu.org> <87d0u7n3r0.fsf@gmail.com> <87bm9ruqok.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1535640032 28862 195.159.176.226 (30 Aug 2018 14:40:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 30 Aug 2018 14:40:32 +0000 (UTC) User-Agent: mu4e 1.0; emacs 26.1 Cc: 32504@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 30 16:40:27 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvO7X-0007Px-6k for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Aug 2018 16:40:27 +0200 Original-Received: from localhost ([::1]:49287 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fvO9d-0005dQ-Jl for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Aug 2018 10:42:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fvO9S-0005AX-4t for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2018 10:42:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fvO85-0002jh-VK for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2018 10:41:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34271) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fvO85-0002jZ-Qs for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2018 10:41:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fvO85-0001bA-MU for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2018 10:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Aug 2018 14:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32504 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32504-submit@debbugs.gnu.org id=B32504.15356400036068 (code B ref 32504); Thu, 30 Aug 2018 14:41:01 +0000 Original-Received: (at 32504) by debbugs.gnu.org; 30 Aug 2018 14:40:03 +0000 Original-Received: from localhost ([127.0.0.1]:39289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvO79-0001Zm-5Z for submit@debbugs.gnu.org; Thu, 30 Aug 2018 10:40:03 -0400 Original-Received: from mail-oi0-f45.google.com ([209.85.218.45]:37186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvO77-0001Z7-Ja for 32504@debbugs.gnu.org; Thu, 30 Aug 2018 10:40:01 -0400 Original-Received: by mail-oi0-f45.google.com with SMTP id p84-v6so15836732oic.4 for <32504@debbugs.gnu.org>; Thu, 30 Aug 2018 07:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=5OJdWJFqNPoze1LiGVRHyr6DpcoAUm1T0sX9qY4nyjg=; b=R6RMGnqkJoevQ+Sn3Ilk3Tt5Nh20sByaEtgmWvDNV9ga9EGj0ie02p+r2N7eimB6HA iuWssS9WTdRCvs0H6bwuEyboHL725a4q8ryEgK9O6oloOeigOCHALAM1YPJoGMb7jKtG SKErCSRy9oCqr3O26IWH/90yErVt/euYBTUj17240VSJrHumSvKSqCthCoF/3i0FG218 UkSLzTTSL92Re8TcBRpqh6yJms7lXVccH6Ctei+xt+33KADkyeQuRtyTGxvTeaf+KVPm ht0sib70Ww7yQwQk0i3z2sS+nF0VtXUCfr1MJJq2nAOBcM9hOIeUTFiJa6OrEl/q2XsP ksIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=5OJdWJFqNPoze1LiGVRHyr6DpcoAUm1T0sX9qY4nyjg=; b=dzDJoNgYLD4tm61l1ioug3x19pliLkOSvr5rfuhZKOweiA/UWcD2rutqHOMn/qrvez f7CHtG2TyfGJ74Q93H6bWURm9cD5j1OPOKQ2dJK1b3mRtS0TCxV3U0ITsZj/QgX257+V tK8gdN3ce4MCSkN7wUKuwVHNWA88l6oWc93Oaa3VNfSCkPLqL8cgaRjN1zesE7Sd7ahU YJqfiQmLhpQXnGvBFK2JTk/8hCd+UbV0GZPlc6vF5i2FPoeidj+EH5/T0omWSecA1B5d 3KJm9IEYjlWGFpwNOovpuGFO8aj3cd9u0/57/HA7BaELJ/nlqm01X5STgMcGKp7D3rEG C6kQ== X-Gm-Message-State: APzg51A1h29qpL7r5nZ/7ne49Y9kfSsFIKYHHllMMBags+KfhoEc2pmX +L/8vB4dHGhvPu2f4FrbIRUIYzc6 X-Google-Smtp-Source: ANB0VdZh65n5UUpf7wTzIVCZH4XkC4sD/qB2FSwqodrCY/p2OFHqW/fk6LmkJRkTZmGfPWXjBORCOw== X-Received: by 2002:aca:3606:: with SMTP id d6-v6mr2952195oia.327.1535639995874; Thu, 30 Aug 2018 07:39:55 -0700 (PDT) Original-Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id f144-v6sm6593458oib.39.2018.08.30.07.39.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Aug 2018 07:39:54 -0700 (PDT) In-reply-to: <87bm9ruqok.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149880 Archived-At: > I think it would make sense to provide symbolic names for all the > elements returned by syntax-ppss, maybe like this: That makes sense to me. > (cl-defstruct (syntax-state (:constructor nil) > (:type list)) > depth list-start sexp-end > string-start comment quoted > min-depth comment-style comment-or-string-start > open-parens syntax-sequence) I'm not a big fan of the docstrings generated by this, is there a way to change them to be more helpful? For example, syntax-state-comment looks like this: syntax-state-comment is a Lisp function. (syntax-state-comment CL-X) This function has a compiler macro =E2=80=98syntax-state-comment--cmacro=E2= =80=99. Access slot "comment" of =E2=80=98(syntax-state (:constructor nil) (:type l= ist))=E2=80=99 struct CL-X. But it would be a lot better (in my eyes, anyway) if it looked something like this, had the -p suffix, and made CL-X default to point: syntax-state-comment-p is a Lisp function. (syntax-state-comment-p &optional CL-X) This function has a compiler macro =E2=80=98syntax-state-comment-p--cmacro= =E2=80=99. Return non-nil if the syntax of CL-X is a comment. CL-X defaults to point.