From: Alex Branham <alex.branham@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 32504@debbugs.gnu.org
Subject: bug#32504: [PATCH] syntax-is-{comment|string}-p
Date: Thu, 30 Aug 2018 09:39:52 -0500 [thread overview]
Message-ID: <87efefgbpj.fsf@gmail.com> (raw)
In-Reply-To: <87bm9ruqok.fsf@gmail.com>
> I think it would make sense to provide symbolic names for all the
> elements returned by syntax-ppss, maybe like this:
That makes sense to me.
> (cl-defstruct (syntax-state (:constructor nil)
> (:type list))
> depth list-start sexp-end
> string-start comment quoted
> min-depth comment-style comment-or-string-start
> open-parens syntax-sequence)
I'm not a big fan of the docstrings generated by this, is there a way to
change them to be more helpful? For example, syntax-state-comment looks
like this:
syntax-state-comment is a Lisp function.
(syntax-state-comment CL-X)
This function has a compiler macro ‘syntax-state-comment--cmacro’.
Access slot "comment" of ‘(syntax-state (:constructor nil) (:type list))’ struct CL-X.
But it would be a lot better (in my eyes, anyway) if it looked something
like this, had the -p suffix, and made CL-X default to point:
syntax-state-comment-p is a Lisp function.
(syntax-state-comment-p &optional CL-X)
This function has a compiler macro ‘syntax-state-comment-p--cmacro’.
Return non-nil if the syntax of CL-X is a comment. CL-X defaults to point.
next prev parent reply other threads:[~2018-08-30 14:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 20:05 bug#32504: [PATCH] syntax-is-{comment|string}-p Alex Branham
2018-08-23 3:12 ` Noam Postavsky
2018-08-23 13:01 ` Alex Branham
2018-08-23 13:58 ` Eli Zaretskii
2018-08-24 16:11 ` Alex Branham
2018-08-24 19:28 ` Eli Zaretskii
2018-08-24 19:49 ` Alex Branham
2018-08-26 6:33 ` Andreas Röhler
2018-08-25 2:26 ` Noam Postavsky
2018-08-30 14:39 ` Alex Branham [this message]
2018-08-31 1:21 ` Noam Postavsky
2018-08-31 2:50 ` Alex Branham
2019-07-09 0:05 ` Noam Postavsky
2019-07-11 5:11 ` Leo Liu
2018-08-23 23:18 ` Phil Sainty
2019-06-23 22:05 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efefgbpj.fsf@gmail.com \
--to=alex.branham@gmail.com \
--cc=32504@debbugs.gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).