From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#32672: 27.0.50; image resize on window resizing Date: Fri, 14 Sep 2018 02:20:15 +0300 Organization: LINKOV.NET Message-ID: <87efdxnfww.fsf@mail.linkov.net> References: <87pnxmyjgt.fsf@mail.linkov.net> <87ftyfoakb.fsf@mail.linkov.net> <5B98B33D.7000605@gmx.at> <871s9ycnjl.fsf@mail.linkov.net> <5B9A15DA.5000403@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1536880893 16873 195.159.176.226 (13 Sep 2018 23:21:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 13 Sep 2018 23:21:33 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 32672@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 14 01:21:29 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0avO-0004E6-Ip for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Sep 2018 01:21:26 +0200 Original-Received: from localhost ([::1]:45868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g0axU-0007qA-L0 for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Sep 2018 19:23:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g0axH-0007oA-1W for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2018 19:23:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g0axC-0006EK-71 for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2018 19:23:22 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35537) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g0awx-0005pN-2Y for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2018 19:23:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g0aww-0002A2-Tb for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2018 19:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Sep 2018 23:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32672 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32672-submit@debbugs.gnu.org id=B32672.15368809288208 (code B ref 32672); Thu, 13 Sep 2018 23:23:02 +0000 Original-Received: (at 32672) by debbugs.gnu.org; 13 Sep 2018 23:22:08 +0000 Original-Received: from localhost ([127.0.0.1]:39794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0aw4-00028K-8q for submit@debbugs.gnu.org; Thu, 13 Sep 2018 19:22:08 -0400 Original-Received: from pop.dreamhost.com ([64.90.62.162]:57506 helo=pdx1-sub0-mail-a31.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0aw2-00028C-4z for 32672@debbugs.gnu.org; Thu, 13 Sep 2018 19:22:06 -0400 Original-Received: from pdx1-sub0-mail-a31.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTP id 454827F979; Thu, 13 Sep 2018 16:22:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=vPoHIxaHo5ci2kvY4CY/56oeFIo=; b= Bf0vWlcJRLp27uanDjF3yddRXh3AuIoLQdz//lq2lxk8fAma2NvoTYbTJYP0eYA3 VLfHY+LjbCq9qBCkzBBuGIOk1h4UJ+R/VWyuco64vz8yACdbTFrV0+vR8txnab3m bXJtKlj5Utd9flFMKpQpTmJDYIsl7ytouFyN1tsf+GM= Original-Received: from localhost.linkov.net (m91-129-104-147.cust.tele2.ee [91.129.104.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTPSA id A8F0F7F978; Thu, 13 Sep 2018 16:22:02 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a31 X-DH-BACKEND: pdx1-sub0-mail-a31 In-Reply-To: <5B9A15DA.5000403@gmx.at> (martin rudalics's message of "Thu, 13 Sep 2018 09:46:34 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150303 Archived-At: >> It's not straightforward to find a hook that covers all cases, it seems >> at least it should be called when an image-mode buffer comes to the top >> of buffer-list, and the closest hook for that is buffer-list-update-hook. > > I still don't get why you need to know whether the image-mode buffer > comes to top in order to decide on resizing the image. For example, visit an image, type `C-h i', resize the window, type `C-x k RET' (not `q', because `q' restores previous window sizes), then the image is not updated to fit the resized window. >> It's fired every time the image-mode buffer comes to the top, even when >> calling quit-window on another buffer that gives way to the image-mode buffer. >> >> The only case when buffer-list-update-hook doesn't run is when the >> image-mode buffer comes to the top by `C-x ' (previous-buffer), >> whereas `C-x ' (next-buffer) works fine. > > This must be a bug but I don't understand how it could happen. > 'switch-to-prev-buffer' calls 'set-window-buffer-start-and-point' > which calls 'set-window-buffer' which calls 'record-window-buffer' > which should call 'buffer-list-update-hook'. Can you trace while it > fails for you? Trying to put to image-mode: (add-hook 'buffer-list-update-hook (lambda () (message "buffer-list-update-hook %S" (current-buffer))) nil t) shows in *Messages* that it's called only when navigating away from the image-mode buffer, but not when coming back to the image-mode buffer, e.g. `C-x ', then resize the window, then type `C-x ', it's not called. Also it's not called in another direction: `C-x ', then resize the window, then type `C-x '.