unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Pierre Téchoueyres" <pierre.techoueyres@free.fr>
To: 33188@debbugs.gnu.org
Subject: bug#33188: 26.1.50; [PATCH] Wishlist : Improve default mouse menu for mode from modeline
Date: Sun, 28 Oct 2018 19:25:57 +0100	[thread overview]
Message-ID: <87efcaorm2.fsf@killashandra.ballybran.fr> (raw)

[-- Attachment #1: Type: text/plain, Size: 815 bytes --]

Hello,

I would submit an enhacement for when you use the mouse to display the
menu for a mode (major or minor) from the modeline.


For now, if the mode doesn't define a custom mouse menu, the menu title
simply display the mode indicator. But sometimes this indicator isn't
really obvious.

The attached patch try to improve this by appending the full mode name
after the indicator.

For example the Smartparens minor mode has 'SP' as indicator. So his
menu is look like:
---------------------
| SP
---------------------
| Turn off minor mode
| Help for minor mode
----------------------

Whit the attached patch the menu will look like:

------------------------
| SP - Smartparens Mode
------------------------
| Turn off minor mode
| Help for minor mode
------------------------

Hope this could help.

Pierre.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: [PATCH] Wishlist : Improve default mouse menu for mode from modeline --]
[-- Type: text/x-patch, Size: 2083 bytes --]

From 8ccd620d2891eee0ec1910a002adca0ab657f7ab Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre=20T=C3=A9choueyres?= <pierre.techoueyres@free.fr>
Date: Wed, 10 Oct 2018 20:08:05 +0200
Subject: [PATCH] 'minor-mode-menu-from-indicator' now display full minor mode.

When there is no menu for a mode, display the mode name after the
indicator instead of just the indicator (which is sometime cryptic).
Ex:
before : SP
now    : SP - Smartparens Mode

* etc/NEWS: Add en entry for this new feature.
* lisp/mouse.el (minor-mode-menu-from-indicator): Append the mode name
  after the indicator when there is no menu defined by the mode.
---
 etc/NEWS      | 9 ++++++++-
 lisp/mouse.el | 5 ++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/etc/NEWS b/etc/NEWS
index ee74e86f40..739674cf3e 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -824,11 +824,18 @@ UUID at point.
 
 
 ** Interactive automatic highlighting
-
 +++
 *** 'highlight-regexp' can now highlight subexpressions.
 The now command accepts a prefix numeric argument to choose the
 subexpression.
+** Mouse display major mode menu
++++
+*** 'minor-mode-menu-from-indicator' now display full minor mode.
+When there is no menu for a mode, display the mode name after the
+indicator instead of just the indicator (which is sometime cryptic).
+Ex:
+before : SP
+now    : SP - Smartparens Mode
 
 \f
 * New Modes and Packages in Emacs 27.1
diff --git a/lisp/mouse.el b/lisp/mouse.el
index cb63ca51c5..2aba9bf458 100644
--- a/lisp/mouse.el
+++ b/lisp/mouse.el
@@ -169,7 +169,10 @@ minor-mode-menu-from-indicator
                 (mouse-menu-non-singleton menu)
               (if (fboundp mm-fun)      ; bug#20201
                   `(keymap
-                    ,indicator
+                    ,(format "%s - %s" indicator
+			     (capitalize
+			      (replace-regexp-in-string
+			       "-" " " (format "%S" minor-mode))))
                     (turn-off menu-item "Turn off minor mode" ,mm-fun)
                     (help menu-item "Help for minor mode"
                           (lambda () (interactive)
-- 
2.17.1


             reply	other threads:[~2018-10-28 18:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-28 18:25 Pierre Téchoueyres [this message]
2018-11-03  9:03 ` bug#33188: 26.1.50; [PATCH] Wishlist : Improve default mouse menu for mode from modeline Eli Zaretskii
2018-11-03 14:16   ` Pierre Téchoueyres
2018-11-03 16:02     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efcaorm2.fsf@killashandra.ballybran.fr \
    --to=pierre.techoueyres@free.fr \
    --cc=33188@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).