From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH 3/4] min_cols/rows is always 0, don't check for it Date: Mon, 01 Apr 2019 18:37:15 -0400 Message-ID: <87ef6lic84.fsf@gmail.com> References: <20190331223742.1351-1-Hi-Angel@yandex.ru> <20190331223742.1351-4-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="42383"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) Cc: 35062@debbugs.gnu.org To: Konstantin Kharlamov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 02 00:53:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hB5np-000Aus-Fa for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Apr 2019 00:53:17 +0200 Original-Received: from localhost ([127.0.0.1]:39938 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hB5no-0006ql-I8 for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Apr 2019 18:53:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hB5ZF-0004DB-I1 for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2019 18:38:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hB5ZC-0000zg-35 for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2019 18:38:13 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54713) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hB5Z4-0000rv-8U for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2019 18:38:09 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hB5Z4-0006IX-0Y for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2019 18:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Apr 2019 22:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.155415824524169 (code B ref 35062); Mon, 01 Apr 2019 22:38:01 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 1 Apr 2019 22:37:25 +0000 Original-Received: from localhost ([127.0.0.1]:40024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hB5YT-0006Hl-5M for submit@debbugs.gnu.org; Mon, 01 Apr 2019 18:37:25 -0400 Original-Received: from mail-qt1-f173.google.com ([209.85.160.173]:46926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hB5YS-0006HV-7V for 35062@debbugs.gnu.org; Mon, 01 Apr 2019 18:37:24 -0400 Original-Received: by mail-qt1-f173.google.com with SMTP id z17so12703924qts.13 for <35062@debbugs.gnu.org>; Mon, 01 Apr 2019 15:37:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=iPKFA0SI93REAGM0yPm865dhyXwXrCeBa/xnutIN/Do=; b=VK3g4BLjLaJ7W3KuVJ6u4sM5VvWB0y/2lfXFkWSqPFLzPGNOuuw1YZk9+h4gpH/yTi cnZ4RaVDujCDdJsz2HcuHepRsQspqCnZc7pAlaAuWkrc6KhGtLmWjgRhuUaBKQfnudQg ejC70t0UxGBPDipIEh21U4i8ZKzsZvc4v58viIEy25cTw0WEWIznzNg68AICE2mB9Ig3 NFeqdiOhY8xoBsKsRveU57QYd5sjW7yVPDqIJuEzLAsLNOKdIpVufveSr3z4WoPtTJcz qEkSRSk3sFwDitdcNTlVMeBEs7k4ID+48DPbt28AkT3XfTwt7VL/j3JbnFLvsAFeUcfB g3wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=iPKFA0SI93REAGM0yPm865dhyXwXrCeBa/xnutIN/Do=; b=cnD5OspYRUBFLBxRv3Ov4v3WcCkcujwLVF/5N19gRKwPvTGN44yfjEHP/Q98Wbp94m X1oLN3GUr8zYhrcPcx5LrBs3RW2MXdSyePdc4Buc0kKm10ueoczTbwObOOgVjPmKDT44 /plECXhlmEO/a+8cXegDE4C3oZP53G1PO+d/BQ4gaRhNQOjknXzd1h2uFGVflsG4vVD9 bOdJCF+t4xltE8Go1D10vD2RztJvWPMuWrfTKEuVylN9Kod7csFN/JYMaX0OJwi/WEvV 5+9hRUFcV9UOarykz0A23jbl9SqgaNFqOvxyZzkFjhFxGLL38UQeiBMM54ZXWo6CHGdk B6SQ== X-Gm-Message-State: APjAAAUso+mdkhxKVp4XIhlDBkX+7BRrj7p2aaEmcY/AqoH0j47E/+D7 Xa9woqcZjTUnD1eETo5DJEiTgQ+C X-Google-Smtp-Source: APXvYqzk69xqBJbLyK3TQxiDFVwiuAZEDf2QGyBlVur6nX2kK3sqCp9iAji1pYOe0tWx1v2WUQPuDA== X-Received: by 2002:aed:3b62:: with SMTP id q31mr36066507qte.82.1554158238497; Mon, 01 Apr 2019 15:37:18 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id g82sm5878213qkb.34.2019.04.01.15.37.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Apr 2019 15:37:16 -0700 (PDT) In-Reply-To: <20190331223742.1351-4-Hi-Angel@yandex.ru> (Konstantin Kharlamov's message of "Mon, 1 Apr 2019 01:37:41 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157052 Archived-At: Konstantin Kharlamov writes: > * src/gtkutil.c: remove unnecessary comparison > @@ -1401,7 +1401,7 @@ x_wm_set_size_hint (struct frame *f, long int flags, bool user_position) > - int min_rows = 0, min_cols = 0; > + const int min_rows = 0, min_cols = 0; > - if (min_cols > 0) --min_cols; /* We used one col in base_width = ... 1); */ > - if (min_rows > 0) --min_rows; /* We used one row in base_height = ... 1); */ > - > size_hints.base_width = base_width; > size_hints.base_height = base_height; > size_hints.min_width = base_width + min_cols * FRAME_COLUMN_WIDTH (f); If min_cols is always 0, then what use is the "+ min_cols * FRAME_COLUMN_WIDTH (f)"? (and a similar question arises for min_cols and min_rows in update_wm_hints of widget.c)