From: Noam Postavsky <npostavs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Eduardo Ochs <eduardoochs@gmail.com>, 34226@debbugs.gnu.org
Subject: bug#34226: Running (defface my-face-foo ...) just after emacs -Q creates a face whose face-id is 0
Date: Tue, 16 Apr 2019 20:14:17 -0400 [thread overview]
Message-ID: <87ef61xzc6.fsf@gmail.com> (raw)
In-Reply-To: <835zu84xd5.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 28 Jan 2019 17:26:14 +0200")
tags 34226 fixed
close 34226
quit
Eli Zaretskii <eliz@gnu.org> writes:
>> In emacs from git the faces that are created in the .emacs receive bad
>> face-ids - in particular, the first one gets face-id 0, which is the
>> same as the face-id for the "default" face.
>>
>> I discovered this bug because the first face that my .emacs creates is
>> used to make "^O"s be displayed as red stars, and in git emacs these
>> red stars were not being displayed in red.
>>
>> The shell script below creates an elisp file - with some code in its
>> comments meant be executed by hand - and loads and edits that elisp
>> file from both emacs24 and emacs-27.0.50 with "-Q" to show the (bad)
>> behaviour that I was getting from my .emacs.
>
> Thanks for the easy test case. Should be fixed now.
No further comments, assuming it is fixed.
cd06d173a6 2019-01-28T17:24:04+02:00 "Fix bug with face-id after restoring from pdump"
prev parent reply other threads:[~2019-04-17 0:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 21:42 bug#34226: Running (defface my-face-foo ...) just after emacs -Q creates a face whose face-id is 0 Eduardo Ochs
2019-01-28 15:26 ` Eli Zaretskii
2019-04-17 0:14 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef61xzc6.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=34226@debbugs.gnu.org \
--cc=eduardoochs@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).