From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#35130: 27.0.50; gnus cannot save Date: Fri, 03 May 2019 12:58:10 -0700 Message-ID: <87ef5f71kd.fsf@ericabrahamsen.net> References: <87r2aipxgj.fsf@tcd.ie> <87bm1fdn39.fsf@ericabrahamsen.net> <87imv78ctz.fsf@ericabrahamsen.net> <87bm0nxkb3.fsf@ericabrahamsen.net> <87ef5jvzwp.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="256140"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35130@debbugs.gnu.org To: James Cloos Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 03 23:14:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMfVR-0012u5-0C for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 May 2019 23:14:09 +0200 Original-Received: from localhost ([127.0.0.1]:46651 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMeKw-0007WJ-1h for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 May 2019 15:59:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMeKl-0007Vw-QH for bug-gnu-emacs@gnu.org; Fri, 03 May 2019 15:59:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMeKk-0003j6-QV for bug-gnu-emacs@gnu.org; Fri, 03 May 2019 15:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36176) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMeKk-0003io-Jz for bug-gnu-emacs@gnu.org; Fri, 03 May 2019 15:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hMeKk-0003Yl-FX for bug-gnu-emacs@gnu.org; Fri, 03 May 2019 15:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 May 2019 19:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35130 X-GNU-PR-Package: emacs Original-Received: via spool by 35130-submit@debbugs.gnu.org id=B35130.155691350213634 (code B ref 35130); Fri, 03 May 2019 19:59:02 +0000 Original-Received: (at 35130) by debbugs.gnu.org; 3 May 2019 19:58:22 +0000 Original-Received: from localhost ([127.0.0.1]:49720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMeK6-0003Xq-Ev for submit@debbugs.gnu.org; Fri, 03 May 2019 15:58:22 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:56462 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMeK2-0003XY-JG for 35130@debbugs.gnu.org; Fri, 03 May 2019 15:58:19 -0400 Original-Received: from localhost (50-251-205-17-static.hfc.comcastbusiness.net [50.251.205.17]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id CFAE4FA027; Fri, 3 May 2019 19:58:11 +0000 (UTC) In-Reply-To: (James Cloos's message of "Wed, 01 May 2019 10:58:42 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158687 Archived-At: --=-=-= Content-Type: text/plain On 05/01/19 10:58 AM, James Cloos wrote: >>>>>> "EA" == Eric Abrahamsen writes: > > EA> Well, I typed that sequence, and nothing special happened. I saw several > EA> groups I hadn't looked at in a decade or so, caught them up, and nothing > EA> happened after that. I'm not sure what I was supposed to see... > > Perhaps it is specific to nnimap? > > In any case, it is a regression. And a bug. > > The new groups were always sorted alphabetically by name when they were added. > You changes should not break that. > > Out of order makes it vastly more difficult to set them all to their new > levels. Yes, I wasn't saying this wasn't a bug, I was trying to figure out exactly what was going on. Would you try the attached patch and see if it fixes the problem? Eric --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=gnus-subscribe-alpha.diff diff --git a/lisp/gnus/gnus-start.el b/lisp/gnus/gnus-start.el index 2f8a260bf1..17ee4357e8 100644 --- a/lisp/gnus/gnus-start.el +++ b/lisp/gnus/gnus-start.el @@ -583,11 +583,11 @@ gnus-subscribe-randomly (defun gnus-subscribe-alphabetically (newgroup) "Subscribe new NEWGROUP and insert it in alphabetical order." - (let ((groups (cdr gnus-newsrc-alist)) + (let ((groups (cdr gnus-group-list)) before) (while (and (not before) groups) - (if (string< newgroup (caar groups)) - (setq before (caar groups)) + (if (string< newgroup (car groups)) + (setq before (car groups)) (setq groups (cdr groups)))) (gnus-subscribe-newsgroup newgroup before))) --=-=-=--