From: Lars Ingebrigtsen <larsi@gnus.org>
To: Tassilo Horn <tsdh@gnu.org>
Cc: 34160@debbugs.gnu.org, emacs-devel@gnu.org
Subject: bug#34160: About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bug#34160, json.el
Date: Thu, 01 Aug 2019 13:11:24 +0200 [thread overview]
Message-ID: <87ef25nns3.fsf__15281.3320093387$1564657942$gmane$org@mouse.gnus.org> (raw)
In-Reply-To: <877e7xjxjj.fsf@gnu.org> (Tassilo Horn's message of "Thu, 01 Aug 2019 06:54:08 +0200")
Tassilo Horn <tsdh@gnu.org> writes:
> It can still be a bit improved in understandability and efficiency.
>
> 1. The function passed to replace-region-contents runs on the narrowed
> buffer anyway, so no need to narrow it yourself.
>
> 2. It would be better to create a temporary buffer, json-read repeatedly
> from the original buffer, json-encode/insert to the temp one, and
> then return the temp buffer.
>
> The reason for point 2 is that if the function passed to
> replace-region-contents returns a string, it'll put that in a temporary
> buffer anyhow so that it can use replace-buffer-contents to perform the
> actual replacement (replace-region-contents is just a wrapper around
> that).
Sounds like a good idea; please go ahead.
> And we might want to cater for the situation where the region starts or
> ends inside a json object by copying the buffer substring from (point)
> to end to the temp buffer in case json-read fails. I think right now,
> we'd lose such half json objects and everything which follows them.
Yes, that sounds like a good fix.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-08-01 11:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 17:46 bug#34160: json-pretty-print deletes everything after first JSON object Albert Heinle
2019-07-09 18:41 ` Lars Ingebrigtsen
2019-07-10 8:53 ` Glenn Morris
2019-07-10 11:24 ` Lars Ingebrigtsen
[not found] ` <87ef26ac17.fsf@gnu.org>
2019-07-31 15:38 ` bug#34160: About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bug#34160, json.el Eli Zaretskii
[not found] ` <837e7yi57y.fsf@gnu.org>
2019-07-31 18:40 ` Tassilo Horn
[not found] ` <16c4954f400.27dc.69bc538c4644581689883e654f15bce0@gnu.org>
2019-07-31 18:48 ` Eli Zaretskii
2019-07-31 18:41 ` Lars Ingebrigtsen
[not found] ` <87a7cuvyg3.fsf@mouse.gnus.org>
2019-07-31 19:30 ` Tassilo Horn
[not found] ` <16c4982bea8.27dc.69bc538c4644581689883e654f15bce0@gnu.org>
2019-07-31 20:21 ` Lars Ingebrigtsen
[not found] ` <87v9vinefd.fsf@mouse.gnus.org>
2019-08-01 4:54 ` Tassilo Horn
[not found] ` <877e7xjxjj.fsf@gnu.org>
2019-08-01 11:11 ` Lars Ingebrigtsen [this message]
[not found] ` <87ef25nns3.fsf@mouse.gnus.org>
2019-08-01 12:16 ` Tassilo Horn
[not found] ` <8736iljd31.fsf@gnu.org>
2019-08-02 16:16 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87ef25nns3.fsf__15281.3320093387$1564657942$gmane$org@mouse.gnus.org' \
--to=larsi@gnus.org \
--cc=34160@debbugs.gnu.org \
--cc=emacs-devel@gnu.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).