From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#37489: 27.0.50; Make `debbugs-gnu-search' work with `repeat-complex-command' Date: Tue, 24 Sep 2019 05:00:50 +0200 Message-ID: <87ef064cv1.fsf@web.de> References: <87v9tjo7en.fsf@web.de> <87muevkutt.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="161952"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37489@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 24 05:02:43 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iCb6A-000fzm-He for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Sep 2019 05:02:42 +0200 Original-Received: from localhost ([::1]:40414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCb69-00082Q-7i for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Sep 2019 23:02:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39958) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCb5X-00080H-Lv for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2019 23:02:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCb5W-0006Zp-LM for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2019 23:02:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56779) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iCb5W-0006Zl-Ex for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2019 23:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iCb5W-0006wG-9h for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2019 23:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Sep 2019 03:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37489-submit@debbugs.gnu.org id=B37489.156929406226591 (code B ref 37489); Tue, 24 Sep 2019 03:02:02 +0000 Original-Received: (at 37489) by debbugs.gnu.org; 24 Sep 2019 03:01:02 +0000 Original-Received: from localhost ([127.0.0.1]:37367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCb4X-0006uc-PM for submit@debbugs.gnu.org; Mon, 23 Sep 2019 23:01:02 -0400 Original-Received: from mout.web.de ([217.72.192.78]:50935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCb4V-0006uL-Bh for 37489@debbugs.gnu.org; Mon, 23 Sep 2019 23:01:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1569294050; bh=4goLQ3rwUXhYlrViatBCenfWz6x1f6o0ezikKAF0INo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=gz0EVTRb8jbNhlR96Mn//KHSQITIpt5CDTVaMAjEUa7zs5G03aahz+z8xnwXZroUH iRrTNKO7KP72y4YP5I7x+ZUkKTu5/FzepUPDPFGtyBxR4y4ZHOJ6J6NceBsEIO9mGW c8r9aSqvHoskLlA7dmayftcXA0w/B+BT+gxFWWwo= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([94.216.136.59]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MY712-1ihVz82iO0-00Uuqk; Tue, 24 Sep 2019 05:00:50 +0200 In-Reply-To: <87muevkutt.fsf@gmx.de> (Michael Albinus's message of "Mon, 23 Sep 2019 15:26:06 +0200") X-Provags-ID: V03:K1:jIQ8OJUoMmii2pdZTl6uD+btUyWKx1CeC/XSyv47VRrLYSBpe7m hFOTNIgac6CiB6sQzeKFFEAaOxNFovATjB8kK0+vyt8TYTSdwHSANH8jQ1fYKMieyWCv8fW 9r93P+qYejiq3hZ65vKDZ1FmzqGIUhJGKtt7n9A41YUaWmBfS4hAL0WND8z/49tamlYsbcG SoVTdnqWKcp2FSLy50kFg== X-UI-Out-Filterresults: notjunk:1;V03:K0:E7UtZdeqyJc=:vVRy/U0UXoK8trAYGbjCfx EKmXwWJ84lusZBxGruKaleyU19ZW3Ys/Vu+VNOKGFO2sO2/AqEHNvY/JFFxIVsJbM5DKEsnlV sAQAiAhvdStK06vYwaW8tq8/Ud8BZ4Ewvmzr5NXiiNsMjqSJtaDZ6kEsSKe1kFbjZtVkoPZrm y6oFbo1FTNucDu2oHyRir+SiO1Y4RKeAxzA+oftEdgvd04dzkaNeazjh/UCKlsmqx4S6SaUD9 B8+pyd9V8yy18JhpCiPutV1L6eDsfZj/g/dy9sseX8YtprkuGTT+Bf3mgpk2ur0MnBrcG96jW YJYC3g7khfLGmCGkSFG7uvHLQAjDtA0xYZSY1dyD6bHz1hNn0Z8n+n6MxALme4qAmopkRgGJ3 rzmyojIk84/9zn+Drx9BcfNh03VTctpDKLdmIliGn5ml8O0gov4YZKCixFzQGedRU5cRIKPE7 Qpjo+CYgrFpm3eHZsAMs0tPHJcSsK3UifOZfaHME25kYW9PFwU+QQYABQ+Riuku46QEkybyUQ 4OY741TCpZccdrNeNfcZg1Qd//1D2pDKZyqBVvdlns7LfvWJ9to+Ap1pxvQi8jfFJiCzqM5XD D9ajqH5If1/sE0E02d/rP+do8xVJ/CtfufuK47rCIxjubk952BbERis7Kv4arRCDLfQtuNaOm p9ttiTa9LBfdNAJBRwARe7B6RXjaqr/5lDu3wP4dGWEKPmcrOzqYv4kohJCTGg+JvbD05aIqW lcjXsc2+DX93B4gtyAQ1XqPnf60xxKvz84HteIH6/5A7hKjpZ7kgfYBCM9+dUQegnuPFwJs+ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167060 Archived-At: Michael Albinus writes: > The appended patch shall do the job, you might test. Seems to work fine, yes, thanks. > However, I fear we will open a Pandora's box. We must set both > debbugs-gnu-current-query and debbugs-gnu-current-filter, it depends > on whether PHRASE is a string, or not. And even the allowed arguments > in both cases are different. So it is very easy to make it wrong when > editing the argument list. Even *I* would need to consult the > implementation, in order to know what's allowed, and what's > not. I don't find it this problematic. It's ok when not all combinations of arguments are allowed. But instead of consulting the implementation, it would of course be better to describe limitations in the docstring. If it gets too complicated, maybe the list of arguments could be changed to reflect the implementation even more. Anyway, the patch is all that I wanted. If the command barks the last resort is to go through the queries again, which I have to do now anyway. > I would add some further sanity checks for QUERY, before callings > debbugs-gnu. That might be appropriate, but adding some details to the docstring in addition along the way might not be wrong, too. You don't even need to explain each argument in detail (maybe you could even point to other functions' docstring for that?), just enough to let me know what would not work. FWIW, I never called the command with an empty phrase, since I didn't know that this is allowed and even then I would rather expect that the server would blacklist me :-) Regards, Michael.