From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#35564: [PATCH v5] Tweak dired warning about "wildcard" characters Date: Sun, 10 Nov 2019 22:29:34 +0200 Organization: LINKOV.NET Message-ID: <87eeyf3bg1.fsf@mail.linkov.net> References: <87zho2cd4f.fsf@gmail.com> <87wohvf22u.fsf@gmail.com> <87h88cvpkj.fsf_-_@gmail.com> <87imsinbmr.fsf_-_@gmail.com> <87o8yoign9.fsf_-_@gmail.com> <87v9sgrf29.fsf@gmail.com> <87zhhsd8eq.fsf@web.de> <87imogtqjh.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="148793"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: Michael Heerdegen , 35564@debbugs.gnu.org, Noam Postavsky , Stefan Monnier To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 10 21:57:59 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iTuHW-000cZ8-Oz for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Nov 2019 21:57:58 +0100 Original-Received: from localhost ([::1]:46090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTuHV-0003h9-GL for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Nov 2019 15:57:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50123) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTuGe-0002Or-BD for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2019 15:57:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iTuGd-0002p4-6E for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2019 15:57:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43790) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iTuGd-0002oi-1l for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2019 15:57:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iTuGc-0003Nq-Ue for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2019 15:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Nov 2019 20:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35564-submit@debbugs.gnu.org id=B35564.157341936812890 (code B ref 35564); Sun, 10 Nov 2019 20:57:02 +0000 Original-Received: (at 35564) by debbugs.gnu.org; 10 Nov 2019 20:56:08 +0000 Original-Received: from localhost ([127.0.0.1]:52601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTuFk-0003Lp-BO for submit@debbugs.gnu.org; Sun, 10 Nov 2019 15:56:08 -0500 Original-Received: from chocolate.birch.relay.mailchannels.net ([23.83.209.35]:58146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTuFf-0003LW-LZ for 35564@debbugs.gnu.org; Sun, 10 Nov 2019 15:56:04 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 46E68E0B51; Sun, 10 Nov 2019 20:56:02 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a14.g.dreamhost.com (100-96-92-150.trex.outbound.svc.cluster.local [100.96.92.150]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 5EAF6E0B40; Sun, 10 Nov 2019 20:56:01 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a14.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sun, 10 Nov 2019 20:56:02 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Supply-Whispering: 45c856c44e2380cc_1573419362029_431900614 X-MC-Loop-Signature: 1573419362029:1724492421 X-MC-Ingress-Time: 1573419362029 Original-Received: from pdx1-sub0-mail-a14.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a14.g.dreamhost.com (Postfix) with ESMTP id 008DF9633F; Sun, 10 Nov 2019 12:55:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=linkov.net; bh=jGuUAo ffFXfHp2GssE2g+FZiRM0=; b=3bcXrEjGvO+yHf6/H9j8VWWk+YUqZSBT59Ec4n RP1wZ1ULkUgcwYSzx/IA+usZl27s4RTz29dE79Rk5zDN78bbyknUq6IiNYW/H1f2 iNB2DJ8dH414QVwGvB8yz2eOxDxYQ8ZnjZQkPF0Sr83vD3cQIURZTl1dsXgZZDQT pqhqc= Original-Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a14.g.dreamhost.com (Postfix) with ESMTPSA id BB5099872B; Sun, 10 Nov 2019 12:55:50 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a14 In-Reply-To: <87imogtqjh.fsf@gmail.com> ("=?UTF-8?Q?K=C3=A9vin?= Le Gouguec"'s message of "Tue, 22 Oct 2019 23:22:18 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171392 Archived-At: > Going over for bug#28969 and bug#35564, here are the > discussion points I could identify: It seems all these points are resolved now: > - y-or-n-p propertizing its prompt rigidly: out of scope, since we use > read-multiple-choice now. y-or-n-p doesn't propertize its prompt rigidly now, but indeed this is out of scope when using read-char-from-minibuffer. > - The prompt getting too long: it's now much shorter than the > four(!)-line version I came up with in v4; it concisely spells out th= e > issue (some characters will not be substituted) and invites the user > to ask for more details if needed. Please use a shorter prompt like 1 occurrence of =E2=80=98?=E2=80=99 will not be substituted. Proceed? = (y, n or ?)=20 > - Asking the user whether they'd like to actually substitute these > characters: out of scope; not sure it's necessary, since the new > "details" buffer explains how to work around this for '?' (using > backquotes). Displaying the new "Dired help" buffer on demand is a good idea. > - Ensuring accessibility: users who cannot distinguish the 'warning' > face are now invited to add optional '^' markers. In the new "Dired help" buffer where there is enough space to add the command line with '^' markers. > - Preventing '`' being linked to the backquote macro in the docstring > for dired-do-shell-command: still no idea how to fix that, but that > can be investigated independently. Maybe use double quotes "`" as an exception. > Here are some remaining issues I can think of: > > - The code that toggles the '^' markers does not check that the command > is not wrapped/truncated (i.e. that the window is wide enough). Everything should be explained in the new "Dired help" buffer including the command line with '^' markers. > - The details window might not be tall enough, in which case maybe I > should add [f]orward-/[b]ackward-page actions like nsm.el does. Yesterday I added new keybindings C-v/M-v for scrolling the original window from the minibuffer. > - In dired--no-subst-confirm, I did my best to make the window-popping > dance as graceful as possible (unwind-protect so that the details > buffer is killed even after C-g, save-window-excursion to restore the > window configuration=E2=80=A6), but maybe it falls apart in cases I h= aven't > considered. Maybe some of the standard display-window functions can handle this, but this is a minor question. > - UI bikeshedding: maybe drop the leading "Warning:" Right, this makes the prompt shorter.