From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.bugs Subject: bug#38181: Actual height of mode-line not taken into account Date: Sat, 16 Nov 2019 00:51:19 +0100 Message-ID: <87eey8og08.fsf@bernoul.li> References: <87eeyd3ul0.fsf@bernoul.li> <83d0dt2qt6.fsf@gnu.org> <87a78xnrp0.fsf@bernoul.li> <835zjl2mzs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="78941"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.1.0; emacs 27.0.50 Cc: 38181@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 16 00:54:24 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVlPy-000KMc-Jy for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Nov 2019 00:54:22 +0100 Original-Received: from localhost ([::1]:45816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVlPw-0006Vn-RP for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2019 18:54:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36709) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVlPf-0006Vb-80 for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 18:54:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVlPe-0001Fy-4E for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 18:54:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56914) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVlPe-0001Fr-0x for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 18:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iVlPd-00075E-Us for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 18:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Nov 2019 23:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38181 X-GNU-PR-Package: emacs Original-Received: via spool by 38181-submit@debbugs.gnu.org id=B38181.157386198227154 (code B ref 38181); Fri, 15 Nov 2019 23:54:01 +0000 Original-Received: (at 38181) by debbugs.gnu.org; 15 Nov 2019 23:53:02 +0000 Original-Received: from localhost ([127.0.0.1]:37502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVlOg-00073t-C7 for submit@debbugs.gnu.org; Fri, 15 Nov 2019 18:53:02 -0500 Original-Received: from mail.hostpark.net ([212.243.197.30]:58052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVlOe-00073U-Do for 38181@debbugs.gnu.org; Fri, 15 Nov 2019 18:53:01 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id F174D16618; Sat, 16 Nov 2019 00:52:58 +0100 (CET) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id iWgy6QbeR9HN; Sat, 16 Nov 2019 00:51:24 +0100 (CET) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 26F83165F1; Sat, 16 Nov 2019 00:51:24 +0100 (CET) In-reply-to: <835zjl2mzs.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171689 Archived-At: Eli Zaretskii writes: > Why the need to use advising? Your recipe shows that calling > redisplay before fit-window-to-buffer also solves the problem. Can't > you do something like that only when you add such tall images to the > mode line? This is about packages like powerline, spaceline, doom-modeline and my moody. These packages add images to the global mode-line-format to make them prettier. These packages do not create any buffers of their own and they never call fit-window-to-buffer themselves, but whenever that function is called for a new buffer redisplay has to be run first, so the advice is needed. > An alternative would be to scale the image so that it doesn't enlarge > the mode line, btw. Is that possible in your use cases? No because enlarging the mode-line is one of the things I did in order to make it prettier (imo). It's a goal not a means or side-effect. You can see a screenshot on https://github.com/tarsius/moody. Many other "mode-line prettifiers" also increase its height.