From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#24176: Confusing interaction between define-derived-mode and font-lock-add-keywords Date: Sun, 17 Nov 2019 07:59:53 +0100 Message-ID: <87eey7dm3a.fsf@gnus.org> References: <1b9e5891-9843-a9d7-c29f-7b9544a72a12@live.com> <0a87c159-8bd5-3fda-0b03-d1426e6a26d0@live.com> <87k2f5u0sk.fsf_-_@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="211101"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel , Stefan Monnier , 24176@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 17 08:01:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iWEYc-000sc3-Fh for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Nov 2019 08:01:14 +0100 Original-Received: from localhost ([::1]:52296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWEYa-000259-QA for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Nov 2019 02:01:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47486) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWEYR-00022J-So for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 02:01:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWEYQ-0002tL-Ez for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 02:01:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59477) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iWEYQ-0002tF-7g for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 02:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iWEYQ-0001Pa-4o for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 02:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Nov 2019 07:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24176 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 24176-submit@debbugs.gnu.org id=B24176.15739740071916 (code B ref 24176); Sun, 17 Nov 2019 07:01:02 +0000 Original-Received: (at 24176) by debbugs.gnu.org; 17 Nov 2019 07:00:07 +0000 Original-Received: from localhost ([127.0.0.1]:40065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWEXW-0000UN-CN for submit@debbugs.gnu.org; Sun, 17 Nov 2019 02:00:06 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:43312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWEXT-0000RO-Ds for 24176@debbugs.gnu.org; Sun, 17 Nov 2019 02:00:04 -0500 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWEXK-0004Gs-KX; Sun, 17 Nov 2019 07:59:57 +0100 In-Reply-To: <87k2f5u0sk.fsf_-_@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Wed, 24 Aug 2016 20:53:15 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171761 Archived-At: npostavs@users.sourceforge.net writes: > Cl=C3=A9ment Pit--Claudel writes: > >> Sorry, the original report had a confusing example; here is a fixed copy. >> >> (define-derived-mode ~/a fundamental-mode "~/a" >> (font-lock-add-keywords nil `(("a" 0 'font-lock-keyword-face)))) >> (define-derived-mode ~/b ~/a "~/b" >> (font-lock-add-keywords nil `(("b" 0 'font-lock-builtin-face)))) >> (define-derived-mode ~/c ~/b "~/c" >> (font-lock-add-keywords nil `(("c" 0 'font-lock-constant-face)))) >> >> Explicitly calling (setq font-lock-major-mode major-mode) before >> calling font-lock-add-keywords yields the expected behaviour. > > Yeah, it seems `font-lock-set-defaults' (called from > `font-lock-add-keywords') deletes the parent mode's added keywords since > they were not from the "correct" mode. > > (defun font-lock-set-defaults () > "Set fontification defaults appropriately for this mode. > Sets various variables using `font-lock-defaults' and > `font-lock-maximum-decoration'." > ;; Set fontification defaults if not previously set for correct maj= or mode. > (unless (and font-lock-set-defaults > (eq font-lock-major-mode major-mode)) > (setq font-lock-major-mode major-mode) > (setq font-lock-set-defaults t) > ... Stefan, is this working as designed? If so, the behaviour should perhaps be mentioned in the doc for font-lock-add-keywords and/or define-derived-mode? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no