From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Federico Tedin Newsgroups: gmane.emacs.bugs Subject: bug#38317: Buffer-local variables don't work as history for read-from-minibuffer Date: Thu, 21 Nov 2019 22:30:29 +0100 Message-ID: <87eey0lxxm.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="200425"; mail-complaints-to="usenet@blaine.gmane.org" To: 38317@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 21 22:31:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXu2h-000q1Q-EE for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 22:31:11 +0100 Original-Received: from localhost ([::1]:45962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXu2g-0008T4-55 for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 16:31:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50487) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXu2a-0008Sv-Js for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:31:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXu2Z-0005qF-Eh for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:31:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44606) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXu2Z-0005q8-Al for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:31:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXu2Z-0003Nd-33 for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:31:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Federico Tedin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Nov 2019 21:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 38317 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.157437184012963 (code B ref -1); Thu, 21 Nov 2019 21:31:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Nov 2019 21:30:40 +0000 Original-Received: from localhost ([127.0.0.1]:53427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXu2B-0003Mz-4X for submit@debbugs.gnu.org; Thu, 21 Nov 2019 16:30:40 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:45444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXu29-0003Mr-0E for submit@debbugs.gnu.org; Thu, 21 Nov 2019 16:30:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50399) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXu27-0008Hl-IT for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:30:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXu26-0005V4-20 for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:30:35 -0500 Original-Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:53236) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXu25-0005UT-R8 for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:30:33 -0500 Original-Received: by mail-wm1-x344.google.com with SMTP id l1so5349190wme.2 for ; Thu, 21 Nov 2019 13:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=qFbrTqmLD646wttdLR1cSbiAqpUHPNnPNfymsxOE7Mg=; b=CJDmOpFpIqyz0z91OznGZ8u0lQ+5Amcp2Ap8po2g3Md7PMD3dQOhz9OXLkFcYCa+/B ahjlU8rPJEWqoQqpB+YRIviYndMIw3a11mNozPWLVKO5lnhuvMMP44R64R/3Iohef2NZ Bd36zOXv+wfO4yXVKqHl61cJo4A0c4u6Ti64UsZfrNvYNl2GvbWpvd9GqDTcoe5umqVq 5Io3GGcCSnfE4qnTTgYcIX7pEPcQMTsXecDQF3It9lRRGCN8p53cd5IZmoAbYcNDrn3a KwFQqpemQsKz4/KCDbM+w4lOTfUkb0E0ir6f6ydaWgiSye/iL8/ASRNa4CgL86S7IiPQ pBLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=qFbrTqmLD646wttdLR1cSbiAqpUHPNnPNfymsxOE7Mg=; b=Oobm6bY9lQe4K29lwewHAhFotrhhwAtayI7R7uvMrLxgn+m96vn6jgnYiBHQlUmAn6 wUpMlS23R+qjF1P2YqGi9izaIyP2qSDNcWInjuFJJCzjKnaBmVVlUFcXp5IcMJhng9gg ++WjOF5CUnpnQ/r3NOK9uQ6aaLtUJEnFFYymvdayTRdyam3VuL6ymO2ncZUMQsQ9lqm0 CX0s1BDB3BpYo4O63mkXz5f8ELzjXkRNfSCfgkUTrXNeawef664LAg2Xnwppw5fq3LQE XSmxcXiPoEc1aWirYDq4WCKhvLTSXjl5ED/FkavwE/AY0YrSlNNtYdckh2chLYl/v+ng DzKQ== X-Gm-Message-State: APjAAAXEehYRVKsJ+0GT2QD3cSLrug9gjWyZJQsCqbNO59Mj8Y5x/yc4 dEUvbY1bDPBU+EwcdWnrW3QgAy4A X-Google-Smtp-Source: APXvYqz853X/alnB9wAAGFOdEzS+mZ6BrtwgeoHJ9P8OIiox/5b1j6E9pxU/C+w8yetz50Z9+U5CVw== X-Received: by 2002:a1c:de88:: with SMTP id v130mr13290747wmg.89.1574371831344; Thu, 21 Nov 2019 13:30:31 -0800 (PST) Original-Received: from lead ([2a02:8109:8ac0:2ff0:d17f:44c3:a5fa:4c03]) by smtp.gmail.com with ESMTPSA id o10sm606118wmc.42.2019.11.21.13.30.29 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Nov 2019 13:30:30 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172167 Archived-At: I was recently trying to modify `goto-line' so that it uses a buffer-local variable as input history for the minibuffer (so that line numbers don't get mixed up with other inputted values, and each buffer has its own input history) (see: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38282). First, I modified `read-number' and added a new HIST parameter. Then I just forwarded that value to `read-from-minibuffer'. Then, in simple.el, I added a new buffer-local variable `goto-line--hist' and passed it to `read-number' in `goto-line'. I also added I call to `add-to-history` to record the value read. All of this did not work as expected: the input history for all buffers was shared for all uses of `goto-line'. Inspecting `goto-line--hist' with M-: showed the correct list of values, however. The shortest way I've found of reproducing the problem is: (defvar-local local-hist nil) (defun my-command () (interactive) (add-to-history 'local-hist (read-from-minibuffer "> " nil nil nil 'local-hist))) In this case, the variable `local-hist' will end up containing all the inputted values (per buffer), but trying to use M-p or M-n to step through the input history after invoking `my-command' will not work ("no preceding item"). So to summarize, `read-from-minibuffer' doesn't seem to work correctly when HIST is buffer-local. Related: https://emacs.stackexchange.com/questions/53892/buffer-local-input-history-for-read-from-minibuffer/53898#53898