From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Newsgroups: gmane.emacs.bugs Subject: bug#40695: [PATCH] ; Fix some typos and doc issues Date: Sat, 18 Apr 2020 17:31:18 +0200 Message-ID: <87eesk7qux.fsf@gmail.com> References: <20200418113735.34298-1-stepnem@gmail.com> <833691asgx.fsf@gnu.org> <87mu796io8.fsf@gmail.com> <83wo6caot5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="1071"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 40695-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 18 17:31:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jPpR2-0000Bm-1d for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Apr 2020 17:31:12 +0200 Original-Received: from localhost ([::1]:58908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPpR1-00062k-4Z for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Apr 2020 11:31:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40478) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPpQt-00062P-EN for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2020 11:31:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jPpQs-0004CD-5I for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2020 11:31:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60108) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jPpQs-0004C5-1N for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2020 11:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jPpQr-00048g-W7 for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2020 11:31:01 -0400 Resent-From: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Apr 2020 15:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 40695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 40695@debbugs.gnu.org, stepnem@gmail.com, stepnem@gmail.com Original-Received: via spool by 40695-done@debbugs.gnu.org id=D40695.158722384515884 (code D ref 40695); Sat, 18 Apr 2020 15:31:01 +0000 Original-Received: (at 40695-done) by debbugs.gnu.org; 18 Apr 2020 15:30:45 +0000 Original-Received: from localhost ([127.0.0.1]:43419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPpQb-000488-5W for submit@debbugs.gnu.org; Sat, 18 Apr 2020 11:30:45 -0400 Original-Received: from mail-wm1-f65.google.com ([209.85.128.65]:35122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPpQZ-00047s-0X for 40695-done@debbugs.gnu.org; Sat, 18 Apr 2020 11:30:44 -0400 Original-Received: by mail-wm1-f65.google.com with SMTP id r26so6150841wmh.0 for <40695-done@debbugs.gnu.org>; Sat, 18 Apr 2020 08:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=NB9MJLrcrMhCiLaOdgy3oDAZy8QbbTySFfPCe0yiEyM=; b=RxINgkPvaOHF6787/Zod2c7Y653BSfFrK+Voah9Ff3jbLKC5ujXOxiuUny+/6+IlJe 5PFUOU/GbTq0CyigvkIGrset3qIKIR/1GBP3uSiXitJSTyY/mnaJehqcMfo0ZjMSQ5PZ gK7w8ny9/5NlR2WXbt/dHmVvUjqZyhJT2Q4xFuQCKtrGRv0oZvTP4B2eNz/mX8WqZxcI jMm5QwIqo+YU4rcls9HURa3L0GY8LS9l5gxNjYVSj+Yr3sOfPb7pejKjSltFuuttCglq kYvnL9I700h3vX4DLt9GBLghfgzSrHJDbJELIQJarsPHi8En64zWd5KUT7aOYI10QqWD Isig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=NB9MJLrcrMhCiLaOdgy3oDAZy8QbbTySFfPCe0yiEyM=; b=VIpdxQlrUllDIoov3yglyBdFI2Cue1IxT90jLpzgjB2K1tefdFyRVaAEzoY+I+4SV2 XVDYsbroWNnZJYGAykBqND8s0Ive1d0wycMnOco7NvsSAX89lXypj1EhPnfxHnjRjEoF PE3a2Wr31KOYQeJimBSp1U772HwBaGL18FuLvPADUoiMwZ5N6yT5oGhIwWt++GZcObDt nJXgbW6tgH/5RDgSpGmdgrf4qkw0QokCkxpKCp/5mSL4V5ade0p3nxiySF3nAWEuvBft aSIxCklY34o0UrpadftmTs36a2DAk77zWVFfS0e0BglPNHJ+5gAK+I46ChY1SVrXoaHo uHkg== X-Gm-Message-State: AGi0PuZMwXi969N6soctosz8w/O6/pJuXUeJ8R3IA3dk/y1zo7MjKTus rgE2d8WfdtfgkYoFYMBv5Pk= X-Google-Smtp-Source: APiQypJ0O8ddaFGvbxcgFQnKOO3tG2jEIwsdg8fW0qW67kc4MtHR9x2ll3JSILyBHKTdqxBv70Gshw== X-Received: by 2002:a05:600c:22d6:: with SMTP id 22mr8576650wmg.121.1587223837059; Sat, 18 Apr 2020 08:30:37 -0700 (PDT) Original-Received: from localhost ([185.112.167.47]) by smtp.gmail.com with ESMTPSA id j10sm12404681wmi.18.2020.04.18.08.30.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2020 08:30:36 -0700 (PDT) In-Reply-To: <83wo6caot5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Apr 2020 16:47:18 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178576 Archived-At: On Sat, 18 Apr 2020 16:47:18 +0300 Eli Zaretskii wrote: >> If you prefer to limit the changes to only those necessary for >> unsplitting the already split occurences, I'll do that. > > Either the split already occurs or is close (i.e. the offending text > is close to the edge of a line. Otherwise we will have to put all of > them in @w{..}, and that seems too much. I rechecked the occurences and tried to remove some of the added @w{}s, and notably failed with ispell-kill-ispell and ispell-change-dictionary, both of which are as far from the edges as one can get (the case of ispell-message was already mentioned in the bug#6411 message), so I can only reiterate that that rule doesn't seem to be a good one (when applied to the texi source). > The "signalled" thing is UK English, and we use US English, so your > changes are okay. Yes, my hesitation didn't concern validity of the change, but whether such changes outweigh the cost to commit history clarity (it's often inconvenient to have to filter out the typo fixes, let alone mere grammar changes, when going after substantial changes during blaming etc.). > Something like > > List of functions to apply to atomic forms. > These are transformer functions applied in the CPS context. Thanks, adapted as=20 "List of functions to apply to atomic forms. These are transformer functions applied to atomic forms evaluated in CPS context." >> The original sentence sounds weird to me (what does the function really >> return?), while the new version should be quite clear IMO. There's also >> checkdoc nagging about `form' not being upper case. > > Well, double negation is also to be avoided. So how about > > Return nil if FORM can yield, non-nil otherwise. Done, thank you. Pushed to emacs-27: 2020-03-01T18:50:14+01:00!stepnem@gmail.com 067b070598 (; Fix some typos and doc issues (bug#40695)) https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3D067b070598 --=20 =C5=A0t=C4=9Bp=C3=A1n