unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Štěpán Němec" <stepnem@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 40695-done@debbugs.gnu.org
Subject: bug#40695: [PATCH] ; Fix some typos and doc issues
Date: Sat, 18 Apr 2020 17:31:18 +0200	[thread overview]
Message-ID: <87eesk7qux.fsf@gmail.com> (raw)
In-Reply-To: <83wo6caot5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Apr 2020 16:47:18 +0300")

On Sat, 18 Apr 2020 16:47:18 +0300
Eli Zaretskii wrote:

>> If you prefer to limit the changes to only those necessary for
>> unsplitting the already split occurences, I'll do that.
>
> Either the split already occurs or is close (i.e. the offending text
> is close to the edge of a line.  Otherwise we will have to put all of
> them in @w{..}, and that seems too much.

I rechecked the occurences and tried to remove some of the added @w{}s,
and notably failed with ispell-kill-ispell and ispell-change-dictionary,
both of which are as far from the edges as one can get (the case of
ispell-message was already mentioned in the bug#6411 message), so I can
only reiterate that that rule doesn't seem to be a good one (when
applied to the texi source).

> The "signalled" thing is UK English, and we use US English, so your
> changes are okay.

Yes, my hesitation didn't concern validity of the change, but whether
such changes outweigh the cost to commit history clarity (it's often
inconvenient to have to filter out the typo fixes, let alone mere
grammar changes, when going after substantial changes during blaming
etc.).

> Something like
>
>     List of functions to apply to atomic forms.
>   These are transformer functions applied in the CPS context.

Thanks, adapted as 

  "List of functions to apply to atomic forms.
These are transformer functions applied to atomic forms evaluated
in CPS context."

>> The original sentence sounds weird to me (what does the function really
>> return?), while the new version should be quite clear IMO. There's also
>> checkdoc nagging about `form' not being upper case.
>
> Well, double negation is also to be avoided.  So how about
>
>   Return nil if FORM can yield, non-nil otherwise.

Done, thank you.

Pushed to emacs-27:

2020-03-01T18:50:14+01:00!stepnem@gmail.com
067b070598 (; Fix some typos and doc issues (bug#40695))
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=067b070598

-- 
Štěpán





  reply	other threads:[~2020-04-18 15:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-18 11:37 bug#40695: [PATCH] ; Fix some typos and doc issues Štěpán Němec
2020-04-18 12:28 ` Eli Zaretskii
2020-04-18 13:13   ` Štěpán Němec
2020-04-18 13:47     ` Eli Zaretskii
2020-04-18 15:31       ` Štěpán Němec [this message]
2020-04-18 15:38         ` Eli Zaretskii
2020-04-18 16:04           ` Štěpán Němec
2020-04-18 16:17             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eesk7qux.fsf@gmail.com \
    --to=stepnem@gmail.com \
    --cc=40695-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).