From: Pip Cet <pipcet@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: valizadeh.ho@gmail.com, 41005@debbugs.gnu.org, nicholasdrozd@gmail.com
Subject: bug#41005: problem with rendering Persian text in Emacs 27
Date: Fri, 05 Jun 2020 08:41:19 +0000 [thread overview]
Message-ID: <87eeqt3nww.fsf@gmail.com> (raw)
In-Reply-To: <83ftbaaql5.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 Jun 2020 11:01:42 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Pip Cet <pipcet@gmail.com>
>> Cc: valizadeh.ho@gmail.com, 41005@debbugs.gnu.org, nicholasdrozd@gmail.com
>> Date: Thu, 04 Jun 2020 19:52:42 +0000
>>
>> > As for script and language, for now adding them would just waste
>> > memory, since we don't yet have any meaningful support for
>> > buffer-local, let-alone paragraph-local, scripts and languages. When
>> > we added HarfBuzz support, I considered adding some functionality to
>> > determine language and/or script from the codepoints, but decided that
>> > it made little sense, since HarfBuzz already does exactly that in
>> > hb_buffer_guess_segment_properties. So I think we should add to the
>> > FIXME in hbfont.c the fact that when we do support those internally in
>> > Emacs, we should add these attributes to cached gstrings, but not yet
>> > actually add them for now.
>>
>> We're going to have to change the lgstring structure, though, right?
>
> I think so. We should probably add one more element to the vector in
> LGSTRING_HEADER, because the header is the hash key of the composition
> cache.
Do we have to maintain compatibility? If so, I suggest we change
[FONT-OBJECT CHAR ...]
to
[FONT-OBJECT [CHAR ...] DIRECTION], and use ARRAYP (AREF (..., 2)) to
decide whether the new format is in effect. I actually thought about
suggesting the format be [FONT-OBJECT STRING DIRECTION], but that would
make debugging harder when pretty-printing the string in a failed
composition re-attempts that composition.
But of course it would be easier not to maintain compatibility, and then
we could order the elements any way we choose.
>> Could we maybe get away with just doing so once? My suggestion would be
>> to add a single field to gstrings which would currently be L2R or R2L
>> but might become an alist or something when we get around to adding
>> those features?
>
> We could add an element that would currently be a symbol or an
> integer, but could later become a vector of several elements. Is that
> what you had in mind?
Yes, a vector was what I meant by "or something".
> (I think we should prefer vectors to lists in
> this case, because consing them is slightly faster, and the number of
> elements is known in advance and fixed.)
No argument there, though harfbuzz features, if we ever add them,
probably should be added as a list inside the vector. I'm talking about
things like "kern=0" passed to hb_feature_from_string, then to hb_shape,
to disable kerning.
next prev parent reply other threads:[~2020-06-05 8:41 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 18:02 bug#41005: problem with rendering Persian text in Emacs 27 hossein valizadeh
2020-05-01 18:51 ` Eli Zaretskii
[not found] ` <CAMyfNNp7FiFgAN5EVcVauawiy8ZB7U+eKY7qOeqZOnbMQfs5iQ@mail.gmail.com>
2020-06-03 14:34 ` Eli Zaretskii
2020-06-03 17:24 ` Nicholas Drozd
2020-06-03 18:01 ` Eli Zaretskii
2020-06-04 2:39 ` hossein valizadeh
2020-06-04 3:01 ` hossein valizadeh
2020-06-04 4:01 ` Eli Zaretskii
2020-06-04 4:10 ` Eli Zaretskii
2020-06-04 6:27 ` hossein valizadeh
2020-06-04 8:28 ` Pip Cet
2020-06-04 13:15 ` Eli Zaretskii
2020-06-04 19:52 ` Pip Cet
2020-06-05 4:46 ` hossein valizadeh
2020-06-05 6:21 ` Eli Zaretskii
2020-06-05 11:07 ` Basil L. Contovounesios
2020-06-05 12:32 ` hossein valizadeh
2020-06-05 12:53 ` Eli Zaretskii
2020-06-05 13:05 ` Pip Cet
2020-06-05 14:13 ` Eli Zaretskii
2020-06-06 8:38 ` Pip Cet
2020-06-06 9:04 ` Eli Zaretskii
2020-06-06 9:11 ` Pip Cet
2020-06-06 9:24 ` Eli Zaretskii
2020-06-06 13:09 ` Pip Cet
2020-06-05 14:23 ` hossein valizadeh
2020-06-05 14:25 ` Eli Zaretskii
2020-06-05 6:39 ` Pip Cet
2020-06-05 8:01 ` Eli Zaretskii
2020-06-05 8:41 ` Pip Cet [this message]
2020-06-05 11:42 ` Eli Zaretskii
2020-07-21 12:40 ` Amin Bandali
2020-07-21 13:34 ` Robert Pluim
2020-07-21 17:53 ` Amin Bandali
2020-07-21 18:27 ` Eli Zaretskii
2020-07-22 2:12 ` Amin Bandali
2020-07-22 14:20 ` Eli Zaretskii
2020-07-24 4:11 ` Amin Bandali
2020-07-24 6:09 ` Eli Zaretskii
2020-07-25 4:19 ` Amin Bandali
2020-07-25 6:48 ` Eli Zaretskii
2020-07-25 15:53 ` Amin Bandali
2020-07-25 16:28 ` Eli Zaretskii
2020-07-25 16:44 ` Amin Bandali
2020-07-25 16:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eeqt3nww.fsf@gmail.com \
--to=pipcet@gmail.com \
--cc=41005@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=nicholasdrozd@gmail.com \
--cc=valizadeh.ho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).