From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#41742: 28.0.50; Derive gnus-edit-form-mode from lisp-data-mode Date: Sat, 06 Jun 2020 13:25:13 -0700 Message-ID: <87eeqsrlg6.fsf@ericabrahamsen.net> References: <87wo4kroaf.fsf@ericabrahamsen.net> <87r1usq7rh.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="130643"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41742@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 06 22:26:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhfON-000Xsn-4O for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Jun 2020 22:26:11 +0200 Original-Received: from localhost ([::1]:44898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhfOL-0004C1-Gh for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Jun 2020 16:26:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhfOE-0004An-NM for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2020 16:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41017) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhfOE-0001Bx-Dd for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2020 16:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jhfOE-0003pE-Ar for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2020 16:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jun 2020 20:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41742 X-GNU-PR-Package: emacs Original-Received: via spool by 41742-submit@debbugs.gnu.org id=B41742.159147512414659 (code B ref 41742); Sat, 06 Jun 2020 20:26:02 +0000 Original-Received: (at 41742) by debbugs.gnu.org; 6 Jun 2020 20:25:24 +0000 Original-Received: from localhost ([127.0.0.1]:52563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhfNb-0003oM-NR for submit@debbugs.gnu.org; Sat, 06 Jun 2020 16:25:23 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:59430 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhfNZ-0003o8-Go for 41742@debbugs.gnu.org; Sat, 06 Jun 2020 16:25:22 -0400 Original-Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 61FD3FA0E2; Sat, 6 Jun 2020 20:25:15 +0000 (UTC) In-Reply-To: <87r1usq7rh.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 06 Jun 2020 21:06:10 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181635 Archived-At: "Basil L. Contovounesios" writes: > Eric Abrahamsen writes: > >> Hopefully this is fairly uncontroversial: Gnus has a gnus-edit-form-mode >> for editing group parameters and other things, which presents the data >> as elisp forms and is a perfect use-case for lisp-data-mode -- turning >> on paredit or what have you. This patch derives the former from the >> latter. > > LGTM, FWIW. > > While there, would you mind cleaning up how gnus-edit-form-mode-map is > defined? It currently does a defvar+unless+setq dance, whereas it > should ideally only be a defvar+let, as per the last few paragraphs of > (info "(elisp) Tips for Defining"). Huh, the last few paragraphs of that info page make it look like it's _okay_ to do defvar+unless+setq, am I misreading this? Granted it only says to do it so you can get the docstring closer to the defvar, and there's no docstring in this case, but it does seem acceptable. I wonder what the point of writing it this way is, otherwise?