From: Stephen Berman <stephen.berman@gmx.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 23966@debbugs.gnu.org
Subject: bug#23966: 25.1.50; Frame resizing due to tool bar + Gnus
Date: Mon, 20 Jul 2020 11:10:48 +0200 [thread overview]
Message-ID: <87eep6a6w7.fsf@rub.de> (raw)
In-Reply-To: <87wo2zmr20.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 19 Jul 2020 18:02:15 +0200")
On Sun, 19 Jul 2020 18:02:15 +0200 Lars Ingebrigtsen <larsi@gnus.org> wrote:
> OK, I'm trying to reproduce this in Emacs 28, and... I'm getting all
> kinds of strangeness.
>
> I usually don't use tool bars, but if I just enter a summary mode buffer
> and say M-x tool-bar-mode, then I don't actually get a tool bar -- I
> just get a ~10-pixel high grey stripe at the top.
>
> This may be because gnus-summary-tool-bar is
> 'gnus-summary-tool-bar-retro?
>
> If, on the other hand, I switch tool-bar-mode on before starting Gnus,
> then I do get a tool bar, and that variable is
> 'gnus-summary-tool-bar-gnome.
>
> This is because
>
> (defcustom gnus-summary-tool-bar (if (eq gmm-tool-bar-style 'gnome)
> 'gnus-summary-tool-bar-gnome
> 'gnus-summary-tool-bar-retro)
>
> and
>
> (defcustom gmm-tool-bar-style
> (if (and (boundp 'tool-bar-mode)
> tool-bar-mode
> (not (memq (display-visual-class)
> (list 'static-gray 'gray-scale
> 'static-color 'pseudo-color))))
> 'gnome
> 'retro)
> "Preferred tool bar style."
> :type '(choice (const :tag "GNOME style" gnome)
> (const :tag "Retro look" retro))
> :group 'gmm)
>
> so that's set at load time, and depends on whether you've switched tool
> bar mode on or not before loading the file. Which seems less than
> optimal...
>
> Anyway, is this a different bug than what you were all talking about?
> :-)
It seems like the same bug, or at least related. In any case, when I
run the test code Martin posted in <578754F3.9060800@gmx.at> on a
currentish (2020-07-01) build from master, I get similar but not
identical results to those I got two years ago:
Emacs started; frame pixel height: 612 toolbar height: 41
Gnus started; frame pixel height: 612 toolbar height: 41
Opening nnfolder server on archive...done
Subscribe newsgroup: nnfolder+archive:sent
Subscribe newsgroup: nnfolder+archive:##
Subscribe newsgroup: nnfolder+archive:emacs-personal
3 new newsgroups have arrived
Checking new news...
Reading active file via nnnil...done
Reading active file from archive via nnfolder...done
Checking new news...done
Opening nndoc server on /home/steve/tool-bar-Gnus-frame-bug...done
Tool bar disabled; frame pixel height: 612 toolbar height: 0
Entered Summary buffer; frame pixel height: 612 toolbar height: 0
Tool bar enabled; frame pixel height: 646 toolbar height: 7
Other buffer; frame pixel height: 646 toolbar height: 41
Back to Summary buffer; frame pixel height: 680 toolbar height: 7
Final; frame pixel height: 680 toolbar height: 41
Moreover, I get these exact same results regardless of whether
frame-resize-pixelwise it nil or t, which is different from two years
ago, and also when I set gmm-tool-bar-style to 'gnome or
gnus-summary-tool-bar to 'gnus-summary-tool-bar-gnome before evaluating
the test code.
Steve Berman
next prev parent reply other threads:[~2020-07-20 9:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 12:16 bug#23966: 25.1.50; Frame resizing due to tool bar + Gnus Stephen Berman
2016-07-13 17:34 ` martin rudalics
2016-07-13 19:21 ` Stephen Berman
2016-07-14 9:01 ` martin rudalics
2016-07-14 9:55 ` Stephen Berman
2016-07-14 17:33 ` martin rudalics
2016-07-14 19:14 ` Stephen Berman
2018-04-12 15:01 ` Lars Ingebrigtsen
2018-04-13 9:16 ` Stephen Berman
2020-07-19 16:02 ` Lars Ingebrigtsen
2020-07-20 9:10 ` Stephen Berman [this message]
2020-07-20 9:31 ` Lars Ingebrigtsen
2020-07-20 9:50 ` Stephen Berman
2020-07-23 15:25 ` Lars Ingebrigtsen
2020-07-20 9:33 ` Lars Ingebrigtsen
2020-07-20 9:43 ` Lars Ingebrigtsen
2020-08-04 9:29 ` Lars Ingebrigtsen
[not found] ` <87mu3arc6u.fsf@gnus.org>
2022-04-30 16:18 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eep6a6w7.fsf@rub.de \
--to=stephen.berman@gmx.net \
--cc=23966@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).