unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Joost Kremers <joostkremers@fastmail.fm>
Cc: 22009@debbugs.gnu.org
Subject: bug#22009: PATCH: Use `window-total-width' in `window-splittable-p'
Date: Mon, 07 Sep 2020 18:48:13 +0200	[thread overview]
Message-ID: <87eend5y9e.fsf@gnus.org> (raw)
In-Reply-To: <87io4qgrcg.fsf@fastmail.fm> (Joost Kremers's message of "Wed, 25 Nov 2015 14:07:27 +0100")

Joost Kremers <joostkremers@fastmail.fm> writes:

> Following discussion on emacs-devel (thread "Window splitting issues
> with margins"), this patch replaces the call to `window-width' in
> `window-splittable-p' with `window-total-width'. This takes the window
> margins into account when determining if a window can be split
> horizontally.

[...]

> -	       (>= (window-width window)
> +	       (>= (window-total-width window)

[...]

>>> I'm not sure that would be able to handle cases where different modes
>>> use the margins for different purposes.
>>
>> I think this is the actual challenge in this bug report: design a way
>> that would make it possible.
>
> Yes. We discussed a possible way of doing this in the thread on
> emacs-devel. I'll start a new thread there with a summary of the issues
> and a proposal on how to solve them.

Skimming this bug report, I think everybody pretty much agreed that this
patch was better than the current behaviour, but that this new behaviour
isn't completely correct (especially for those mode that use the margins
to display useful information).

Did the discussion on emacs-devel come to any sort of useful conclusion?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  parent reply	other threads:[~2020-09-07 16:48 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 13:07 bug#22009: PATCH: Use `window-total-width' in `window-splittable-p' Joost Kremers
2015-11-25 17:48 ` martin rudalics
2015-11-25 18:04   ` Eli Zaretskii
2015-11-25 18:14     ` martin rudalics
2015-11-25 19:15       ` Eli Zaretskii
2015-11-26  8:23         ` martin rudalics
2015-11-26 15:46           ` Eli Zaretskii
2015-11-26 16:58             ` martin rudalics
2015-11-26 17:25               ` Eli Zaretskii
2015-11-26 18:06                 ` martin rudalics
2015-11-26 18:36                   ` Eli Zaretskii
2015-11-27  8:27                     ` martin rudalics
2015-11-27 20:51                       ` Eli Zaretskii
2015-11-28 10:26                         ` martin rudalics
2015-11-28 14:49                           ` Eli Zaretskii
2015-11-28 15:49                             ` martin rudalics
2015-12-01 12:47                           ` Joost Kremers
2015-11-27  1:16 ` Joost Kremers
2015-11-27  8:28   ` martin rudalics
2015-12-01 14:11     ` Joost Kremers
2015-11-27 20:56   ` Eli Zaretskii
2015-12-01 12:59     ` Joost Kremers
2015-12-01 15:44       ` Eli Zaretskii
2015-12-01 17:31         ` Joost Kremers
2020-09-07 16:48 ` Lars Ingebrigtsen [this message]
2020-09-08  8:50   ` Joost Kremers
2020-09-08 10:05     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eend5y9e.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=22009@debbugs.gnu.org \
    --cc=joostkremers@fastmail.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).