From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#19032: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Date: Wed, 09 Sep 2020 21:58:03 +0300 Organization: LINKOV.NET Message-ID: <87eena6b30.fsf@mail.linkov.net> References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17479"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, Stefan Monnier , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Lars Ingebrigtsen , Sean Whitton To: OGAWA Hirofumi Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 09 21:12:54 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kG5WW-0004Qb-Mp for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Sep 2020 21:12:52 +0200 Original-Received: from localhost ([::1]:59498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kG5WV-00050u-PD for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Sep 2020 15:12:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kG5Oy-0000ty-1i for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2020 15:05:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kG5Ox-00023W-M9 for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2020 15:05:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kG5Ox-0005RY-HU for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2020 15:05:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Sep 2020 19:05:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19032 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 19032-submit@debbugs.gnu.org id=B19032.159967825220822 (code B ref 19032); Wed, 09 Sep 2020 19:05:03 +0000 Original-Received: (at 19032) by debbugs.gnu.org; 9 Sep 2020 19:04:12 +0000 Original-Received: from localhost ([127.0.0.1]:34719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG5O8-0005Pl-6u for submit@debbugs.gnu.org; Wed, 09 Sep 2020 15:04:12 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:54501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG5O6-0005PI-0E; Wed, 09 Sep 2020 15:04:11 -0400 X-Originating-IP: 91.129.97.241 Original-Received: from mail.gandi.net (m91-129-97-241.cust.tele2.ee [91.129.97.241]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id C83D7E0002; Wed, 9 Sep 2020 19:03:59 +0000 (UTC) In-Reply-To: <87y2ljcaml.fsf@mail.parknet.co.jp> (OGAWA Hirofumi's message of "Wed, 09 Sep 2020 23:01:22 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187695 Archived-At: >> +(defun icomplete-ret () >> + "Exit minibuffer for icomplete." >> + (interactive) >> + (if (and icomplete-show-matches-on-no-input >> + (car completion-all-sorted-completions) >> + (eql (icomplete--field-end) (icomplete--field-beg))) >> + (icomplete-force-complete-and-exit) >> + (exit-minibuffer))) > > This changed the behavior of RET from `minibuffer-complete-and-exit' to > `exit-minibuffer'. Was that intention? What I noticed is the following. I confirm that this change broke icomplete-mode. Here is a test case that shows regression: M-x icomplete-mode RET M-x rgr RET Lisp error: (error "‘rgr’ is not a valid command name") Until yesterday it used to run 'rgrep'.