From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#6227: Color isearch regexp submatches differently Date: Sun, 20 Sep 2020 11:41:10 +0200 Message-ID: <87eemwss3t.fsf@gnus.org> References: <87bpca15ja.fsf@mail.jurta.org> <87wruv1ohr.fsf@mail.jurta.org> <877hmvtn9t.fsf@mail.jurta.org> <874ohyppfs.fsf@mail.jurta.org> <8739ww1tjp.fsf@mail.jurta.org> <87d3vyaodq.fsf@mail.jurta.org> <87hbla4nl4.fsf@mail.jurta.org> <87mu1llak3.fsf@gnus.org> <83lfh50zxa.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37379"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: lennart.borgman@gmail.com, 6227@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 20 11:42:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJvrG-0009cY-O8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Sep 2020 11:42:10 +0200 Original-Received: from localhost ([::1]:54768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJvrF-0005jT-M4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Sep 2020 05:42:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJvr8-0005hj-1P for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 05:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37188) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJvr7-0003rR-NR for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 05:42:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJvr7-0006y5-LW for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 05:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Sep 2020 09:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6227 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6227-submit@debbugs.gnu.org id=B6227.160059488326740 (code B ref 6227); Sun, 20 Sep 2020 09:42:01 +0000 Original-Received: (at 6227) by debbugs.gnu.org; 20 Sep 2020 09:41:23 +0000 Original-Received: from localhost ([127.0.0.1]:48734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJvqU-0006xE-PJ for submit@debbugs.gnu.org; Sun, 20 Sep 2020 05:41:22 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:58184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJvqS-0006x0-E3 for 6227@debbugs.gnu.org; Sun, 20 Sep 2020 05:41:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=W8r+o9Vf/3CTI7dY/vaYywgZp4LRwNMlJ6RXjwFnouY=; b=nEO+EWWigJZ6hbQXdgcsupE3ZF SFOeEhwy2IuH3iy/0iHHt1xbzvX7c8Yo+N2fuV6uyRurCVbwDw9qR8b3mpc8wzm4vs47X1MeHs7Nd bM/Ux8TtSVLR31nH1aw/F406k8TisB/cB09ZuFMgNVlKmnoa4gmketD7vy5zlfm36Z7o=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJvqJ-0005l2-M3; Sun, 20 Sep 2020 11:41:14 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEX8/P3U19a7xcyp u8yVoqlpZ1OIhnGZrsR6kKJKSDY2MiUsKBr///9fa0aiAAAAAWJLR0QMgbNRYwAAAAd0SU1FB+QJ FAkKHHJV3scAAAGoSURBVDjLpdJBT8IwFADgdgG5roKJR5EL3oRi5lFjRfBMlwwvHmAJR7OY+ANI wLs16e47rPwCtz/n6zZgHcGL79BDv76+vNcitA0bHQlC7GNgndrIthHBCBtgdWi75rpzl3NeSsZN Smn7hM9934BmAPu0X+d5bAEP1g8a3nJw/QKs0XIUUAfgKgN/B0sGMICrxvlNswIwgL6JOkWJbQZi jGUw4J40in+wpwxuOZcQe+iyVQ5CH5fc3cJ5ATcir7GDBsvaoO+y0mBjqcGhYylMsDIY0M8q4HU2 qkNAo8DROYsD+KAUchxPChDQHXTziXhSqdjIaBUTmSqlRBkax8CC7eDS4iFAVAYc0D4hNR5N8yJ7 WPUwISdciArof2jjOr+fPCsFcFH6PnjWO+P3dj0xMwjBQ9eff7U7jz9GDQD4af53i40j4yobaeBs KBLowyvVQBgOvrxOZ2EMr14BL/xiVqjiCkgRqk3Ugt5lWAZLwmhV6MESmxDrQalELxVQ+7guQ2l/ c/c/SP7MSNKkCjjrwIXX3VQywjRNo8lwkcReamTwfRjT/Xf8AmV088BEgwQVAAAAJXRFWHRkYXRl OmNyZWF0ZQAyMDIwLTA5LTIwVDA5OjEwOjI4KzAwOjAwMTL32gAAACV0RVh0ZGF0ZTptb2RpZnkA MjAyMC0wOS0yMFQwOToxMDoyOCswMDowMEBvT2YAAAAASUVORK5CYII= X-Now-Playing: Andrew Poppy's _On Zang Tuum Tumb (2): Alphabed (a mystery dance)_: "East Fragment" In-Reply-To: <83lfh50zxa.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Sep 2020 08:39:45 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188475 Archived-At: Eli Zaretskii writes: >> Anybody else got any comments on this? > > Comment #1: Do we really want to turn this feature on by default? I don't see why not. It's just a more detailed visualisation. >> +(defface isearch-2 >> + '((((class color) (min-colors 88) (background light)) >> + :background "magenta1" :foreground "lightskyblue1") >> + (((class color) (min-colors 88) (background dark)) >> + :background "palevioletred4" :foreground "brown4")) >> + "Used for displaying the second matching subexpression.") > > Comment #2: This seems to effectively disable the feature on displays > that have fewer than 88 colors. Is that intentional? If so, why > doesn't the documentation say so? I'm guessing it's just cargo-culting off of the isearch face: (defface isearch '((((class color) (min-colors 88) (background light)) > Comment #3: What about NEWS and the manual? Those would have to be added, of course. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no