From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: lennart.borgman@gmail.com, 6227@debbugs.gnu.org
Subject: bug#6227: Color isearch regexp submatches differently
Date: Sun, 20 Sep 2020 11:41:10 +0200 [thread overview]
Message-ID: <87eemwss3t.fsf@gnus.org> (raw)
In-Reply-To: <83lfh50zxa.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Sep 2020 08:39:45 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> Anybody else got any comments on this?
>
> Comment #1: Do we really want to turn this feature on by default?
I don't see why not. It's just a more detailed visualisation.
>> +(defface isearch-2
>> + '((((class color) (min-colors 88) (background light))
>> + :background "magenta1" :foreground "lightskyblue1")
>> + (((class color) (min-colors 88) (background dark))
>> + :background "palevioletred4" :foreground "brown4"))
>> + "Used for displaying the second matching subexpression.")
>
> Comment #2: This seems to effectively disable the feature on displays
> that have fewer than 88 colors. Is that intentional? If so, why
> doesn't the documentation say so?
I'm guessing it's just cargo-culting off of the isearch face:
(defface isearch
'((((class color) (min-colors 88) (background light))
> Comment #3: What about NEWS and the manual?
Those would have to be added, of course.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-09-20 9:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 11:01 bug#6227: Color isearch regexp submatches differently Lennart Borgman
2010-05-20 13:21 ` Drew Adams
2010-05-20 13:28 ` Lennart Borgman
2010-05-20 13:33 ` Drew Adams
2010-05-20 15:02 ` Drew Adams
2010-05-21 0:07 ` Juri Linkov
2010-05-21 1:19 ` Lennart Borgman
2010-05-22 23:44 ` Juri Linkov
2010-05-23 0:51 ` Lennart Borgman
2010-05-23 0:54 ` Juri Linkov
2010-05-23 10:04 ` Lennart Borgman
2010-05-23 16:12 ` Juri Linkov
2010-05-23 16:40 ` Lennart Borgman
2010-06-08 13:37 ` Lennart Borgman
2010-06-09 8:36 ` Juri Linkov
2010-06-09 9:14 ` Lennart Borgman
2010-06-10 15:28 ` Juri Linkov
2010-06-10 15:52 ` Lennart Borgman
2010-06-10 20:52 ` Juri Linkov
2010-06-10 21:41 ` Lennart Borgman
2010-06-11 0:44 ` Stefan Monnier
2010-06-11 8:17 ` Juri Linkov
2020-09-19 21:29 ` Lars Ingebrigtsen
2020-09-19 22:19 ` Drew Adams
2020-09-20 5:39 ` Eli Zaretskii
2020-09-20 9:41 ` Lars Ingebrigtsen [this message]
2020-09-20 9:53 ` Eli Zaretskii
2020-09-20 10:04 ` Lars Ingebrigtsen
2020-09-20 13:47 ` Lars Ingebrigtsen
2020-09-20 14:18 ` Eli Zaretskii
2020-09-20 19:45 ` Lars Ingebrigtsen
2020-09-20 20:25 ` Drew Adams
2020-09-21 2:25 ` Eli Zaretskii
2020-09-21 13:48 ` Lars Ingebrigtsen
2020-09-20 16:41 ` Drew Adams
2020-09-20 16:45 ` Eli Zaretskii
[not found] <<AANLkTikUlBKGt388RPJkU8tM6A_fpMPsTkvo6cbI3D56@mail.gmail.com>
[not found] ` <<87bpca15ja.fsf@mail.jurta.org>
[not found] ` <<AANLkTilV0TlRQRCC7-uAuspGAwTYhMySTbh4dOjKIDM0@mail.gmail.com>
[not found] ` <<87wruv1ohr.fsf@mail.jurta.org>
[not found] ` <<AANLkTimRAHa4K6FlX_952j3s2saDmcXMIbDOYx9xk8Fh@mail.gmail.com>
[not found] ` <<877hmvtn9t.fsf@mail.jurta.org>
[not found] ` <<AANLkTiljPa2oALTtTabtFb3_KHhPB9NNqnKzXZWIh_v4@mail.gmail.com>
[not found] ` <<874ohyppfs.fsf@mail.jurta.org>
[not found] ` <<AANLkTilPUyzW5lCEdQv-WD6_0WdVbDiofmN34UHMVLNA@mail.gmail.com>
[not found] ` <<AANLkTileYK0D0RTKAePLbax_9o9JbgNlpuNXbLBzBssY@mail.gmail.com>
[not found] ` <<8739ww1tjp.fsf@mail.jurta.org>
[not found] ` <<AANLkTilwC3QBYmtzPg3zrDoD44deoBsD5rxxP-dNhxnH@mail.gmail.com>
[not found] ` <<87d3vyaodq.fsf@mail.jurta.org>
[not found] ` <<87hbla4nl4.fsf@mail.jurta.org>
[not found] ` <<87mu1llak3.fsf@gnus.org>
[not found] ` <<83lfh50zxa.fsf@gnu.org>
[not found] ` <<87eemwss3t.fsf@gnus.org>
[not found] ` <<834kns22q2.fsf@gnu.org>
[not found] ` <<87sgbcrcgd.fsf@gnus.org>
[not found] ` <<874knso90e.fsf@gnus.org>
[not found] ` <<83pn6gzg3j.fsf@gnu.org>
[not found] ` <<87363ckza5.fsf@gnus.org>
[not found] ` <<835z87zx16.fsf@gnu.org>
2020-09-21 4:49 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eemwss3t.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=6227@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=lennart.borgman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).