From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 43489@debbugs.gnu.org
Subject: bug#43489: [PATCH] Don't signal scan-error when moving by sexp interactively
Date: Wed, 23 Sep 2020 15:40:01 +0200 [thread overview]
Message-ID: <87eemsd32m.fsf@gnus.org> (raw)
In-Reply-To: <EDCED21D-8DE6-4587-A4A2-5AAC4877A564@acm.org> ("Mattias Engdegård"'s message of "Wed, 23 Sep 2020 11:17:35 +0200")
Mattias Engdegård <mattiase@acm.org> writes:
> But my personal flaws should not impede progress. How about I push
> what I've got (latest patch attached for reference) since we seem to
> agree that it's an improvement over what's in master, and if then you
> or anyone else want to further adjust the messages then I have no
> objections.
Sure. The only thing is this:
> -(defun backward-sexp (&optional arg)
> +obstacle. If NOERROR is non-nil, as it is interactively,
> +do not signal an error."
> + (interactive "^p\nd")
> + (if noerror
> + (condition-case _
> + (forward-sexp arg nil)
> + (scan-error (user-error (if (> arg 0)
> + "No next sexp"
> + "No previous sexp"))))
The parameter is NOERROR, but now it does signal an error. :-)
So perhaps the parameter should be USER-ERROR/TERSE-ERROR or something
and the doc strings adjusted?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-09-23 13:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 11:31 bug#43489: [PATCH] Don't signal scan-error when moving by sexp interactively Mattias Engdegård
2020-09-18 13:13 ` Lars Ingebrigtsen
2020-09-18 13:18 ` Dmitry Gutov
2020-09-18 13:42 ` Lars Ingebrigtsen
2020-09-18 13:48 ` Dmitry Gutov
2020-09-18 15:13 ` Mattias Engdegård
2020-09-18 15:23 ` Lars Ingebrigtsen
2020-09-18 16:01 ` Mattias Engdegård
2020-09-19 14:13 ` Lars Ingebrigtsen
2020-09-20 17:33 ` Mattias Engdegård
2020-09-20 19:54 ` Lars Ingebrigtsen
2020-09-21 10:55 ` Mattias Engdegård
2020-09-21 14:47 ` Lars Ingebrigtsen
2020-09-21 17:12 ` Mattias Engdegård
2020-09-22 14:32 ` Lars Ingebrigtsen
2020-09-23 9:17 ` Mattias Engdegård
2020-09-23 13:40 ` Lars Ingebrigtsen [this message]
2020-09-23 14:33 ` Mattias Engdegård
2020-09-23 14:45 ` João Távora
2020-09-23 16:24 ` Mattias Engdegård
2020-09-23 16:37 ` João Távora
2020-09-24 15:50 ` Mattias Engdegård
2020-09-24 15:58 ` João Távora
2020-09-24 17:32 ` Stefan Monnier
2020-09-24 19:23 ` João Távora
2020-09-28 17:05 ` Stefan Monnier
2020-09-20 21:39 ` Dmitry Gutov
2020-09-21 11:21 ` Mattias Engdegård
2020-09-21 12:36 ` Dmitry Gutov
2020-09-21 17:12 ` Mattias Engdegård
2020-09-21 17:49 ` Dmitry Gutov
2020-09-21 8:49 ` João Távora
2020-09-21 14:43 ` Lars Ingebrigtsen
2020-09-21 17:12 ` Mattias Engdegård
2020-09-21 17:25 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eemsd32m.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=43489@debbugs.gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).