unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Alex Branham <alex.branham@gmail.com>
Cc: 34787@debbugs.gnu.org
Subject: bug#34787: New defcustom to govern TAB completion
Date: Wed, 14 Oct 2020 07:29:52 +0200	[thread overview]
Message-ID: <87eem1z86n.fsf@gnus.org> (raw)
In-Reply-To: <87ftrxqi68.fsf@gmail.com> (Alex Branham's message of "Fri, 08 Mar 2019 13:29:03 -0600")

Alex Branham <alex.branham@gmail.com> writes:

> On Fri 08 Mar 2019 at 12:21, Alex Branham <alex.branham@gmail.com> wrote:
>
>> @@ -139,7 +161,8 @@ prefix argument is ignored."
>>     (t
>>      (let ((old-tick (buffer-chars-modified-tick))
>>            (old-point (point))
>> -	  (old-indent (current-indentation)))
>> +	  (old-indent (current-indentation))
>> +          (syn (syntax-after (point))))
>              ^^^^^ should be (syn `(,(syntax-after (point))))
>
> I accidentally sent the wrong patch; this part needs to be quoted.

I played around with this a bit, and it seems to work very well, and
quite naturally.  So I've applied this to Emacs 28.

Noam made the suggestion of making this a list of values like (word
paren) instead of word-or-paren, and that does seem like a good idea,
but either works.  I guess somebody might want (word punct) and not
word-and-paren-and-punct, for instance?  So if somebody were to change
this to work that way instead, I wouldn't mind, but I think it's
probably fine as is.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-10-14  5:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-08 18:21 bug#34787: New defcustom to govern TAB completion Alex Branham
2019-03-08 19:29 ` Alex Branham
2020-10-14  5:29   ` Lars Ingebrigtsen [this message]
2019-05-25 13:05 ` Alex Branham
2019-05-25 13:37   ` Noam Postavsky
2019-05-25 13:43     ` Alex Branham
2019-06-05  1:50       ` Noam Postavsky
2020-08-24 19:22         ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eem1z86n.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=34787@debbugs.gnu.org \
    --cc=alex.branham@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).