unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: mvar <mvar.40k@gmail.com>
Cc: 39277@debbugs.gnu.org, Hadrien Lacour <hadrien.lacour@posteo.net>
Subject: bug#39277: 26.3; Tcl font lock does not understand quoting
Date: Tue, 27 Oct 2020 09:51:17 +0100	[thread overview]
Message-ID: <87eelkcare.fsf@igel.home> (raw)
In-Reply-To: <87lffs1zvw.fsf@cnu407c2zx.nsn-intra.net> (mvar's message of "Mon, 26 Oct 2020 22:44:03 +0200")

On Okt 26 2020, mvar wrote:

> diff --git a/lisp/progmodes/tcl.el b/lisp/progmodes/tcl.el
> index 33aad2d39f..5dd02c1367 100644
> --- a/lisp/progmodes/tcl.el
> +++ b/lisp/progmodes/tcl.el
> @@ -410,7 +410,8 @@ tcl-font-lock-keywords
>  (defconst tcl-syntax-propertize-function
>    (syntax-propertize-rules
>     ;; Mark the few `#' that are not comment-markers.
> -   ("[^;[{ \t\n][ \t]*\\(#\\)" (1 ".")))
> +   ("[^;[{ \t\n][ \t]*\\(#\\)" (1 "."))
> +   ((concat "\\_<" (regexp-opt tcl-builtin-list t) "\\_>" "\s*{\\([^}].*\\)}") (2 "_")))
>    "Syntactic keywords for `tcl-mode'.")
>  
>  ;; FIXME need some way to recognize variables because array refs look
> @@ -506,6 +507,7 @@ tcl-set-font-lock-keywords
>           ;; number of "namespace::" qualifiers.  A leading "::" refers
>           ;; to the global namespace.
>           '("\\${\\([^}]+\\)}" 1 font-lock-variable-name-face)
> +         '("{\\([^}]+\\)}" 1 font-lock-string-face)

That mishandles nested or quoted braces.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."





  parent reply	other threads:[~2020-10-27  8:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-25 10:00 bug#39277: 26.3; Tcl font lock does not understand quoting Hadrien Lacour
2020-01-25 10:12 ` bug#39277: tcl-mode " Hadrien Lacour
2020-01-25 10:53 ` Hadrien Lacour
2020-10-26 20:44 ` bug#39277: 26.3; Tcl font lock " mvar
2020-10-27  8:31   ` bug#39277: (no subject) Lars Ingebrigtsen
2020-10-27  8:51   ` Andreas Schwab [this message]
2020-10-27  8:56     ` bug#39277: 26.3; Tcl font lock does not understand quoting Lars Ingebrigtsen
2020-10-27 13:27   ` Stefan Monnier
2020-10-27 17:45     ` Lars Ingebrigtsen
2020-10-27 20:42       ` mvar
2020-10-27 20:47         ` Lars Ingebrigtsen
2020-10-27 22:48         ` Stefan Monnier
2020-10-29 17:39           ` Stefan Monnier
2020-10-30 12:02             ` Lars Ingebrigtsen
2020-10-31 11:01             ` mvar
2020-10-31 13:20               ` Stefan Monnier
2020-11-03 19:47                 ` mvar
2020-11-03 21:45                   ` Stefan Monnier
2020-11-05 12:38                     ` mvar
2020-10-27 15:24 ` bug#39277: Hadrien Lacour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eelkcare.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=39277@debbugs.gnu.org \
    --cc=hadrien.lacour@posteo.net \
    --cc=mvar.40k@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).