unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 44932@debbugs.gnu.org
Subject: bug#44932: 28.0.50; MINIBUF 'nomini' for window-in-direction
Date: Mon, 30 Nov 2020 22:49:12 +0200	[thread overview]
Message-ID: <87eekaa8au.fsf@mail.linkov.net> (raw)
In-Reply-To: <5dbd99a5-a51e-318f-0c9d-81dae921af96@gmx.at> (martin rudalics's message of "Mon, 30 Nov 2020 10:05:41 +0100")

>>> One day we should make up our mind whether we want this arg to be called
>>> MINI, MINIBUF or MINIBUFFER.  I have no personal preference but the
>>> current state (in particular on the C-level) confuses the hell out of
>>> me.
>>
>> I think MINIBUF is the shortest that is still unambiguous.
>
> It gives the impression that it stands for a buffer where it means a
> window that may also display the echo area.  'resize-mini-windows' and
> 'max-mini-window-height' tried to establish the "mini-windows (the
> minibuffer and the echo area)" nomenclature and we now take a step back
> in the other direction?

I don't know why MINI-WINDOW would be better than MINIBUF.
Is this distinction significant here?

Anyway, what I did is made all window functions consistent
in regard to their MINIBUF arg.  So now they are all have
the same arg name MINIBUF:

(defun walk-window-tree (fun &optional frame any MINIBUF)
(defun window-with-parameter (parameter &optional value frame any MINIBUF)
(defun walk-windows (fun &optional MINIBUF all-frames)
(defun window-in-direction (direction &optional window ignore sign wrap MINIBUF)
(defun get-window-with-predicate (predicate &optional MINIBUF all-frames default)
(defun get-buffer-window-list (&optional buffer-or-name MINIBUF all-frames)
(defun count-windows (&optional MINIBUF all-frames)

>> Now at least renaming in window-in-direction is pushed to master.
>
> And left MINI in the .texi file.  I spent some time trying to make
> manual and doc-strings congruent in this regard ...

Sorry, will update the manual soon.





  reply	other threads:[~2020-11-30 20:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-28 20:40 bug#44932: 28.0.50; MINIBUF 'nomini' for window-in-direction Juri Linkov
2020-11-29  8:22 ` martin rudalics
2020-11-29 19:49   ` Juri Linkov
2020-11-30  9:05     ` martin rudalics
2020-11-30 20:49       ` Juri Linkov [this message]
2020-11-30 21:09         ` Drew Adams
2020-12-01  3:24           ` Eli Zaretskii
2020-12-01  9:34         ` martin rudalics
     [not found] <<87r1odtdtx.fsf@mail.linkov.net>
     [not found] ` <<342c23a3-e379-452c-6c5e-29dab7592c28@gmx.at>
     [not found]   ` <<87h7p8zeim.fsf@mail.linkov.net>
     [not found]     ` <<5dbd99a5-a51e-318f-0c9d-81dae921af96@gmx.at>
     [not found]       ` <<87eekaa8au.fsf@mail.linkov.net>
     [not found]         ` <<27c3eec9-5675-47ae-937e-b5440becf6b6@default>
     [not found]           ` <<83sg8qi4yy.fsf@gnu.org>
2020-12-01  3:49             ` Drew Adams
2020-12-01 15:38               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eekaa8au.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=44932@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).