From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#45818: 28.0.50; Test solar-sunrise-sunset fails Date: Tue, 12 Jan 2021 22:09:05 +0000 Message-ID: <87eeiphkou.fsf@tcd.ie> References: <871reqp1ax.fsf@tcd.ie> <28AECF36-B916-427E-A0EC-633AED7CB9BF@acm.org> <87ft35j4xl.fsf@tcd.ie> <59D8F21E-DA21-4F8E-AB91-550B3C154985@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11782"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Kangas , 45818@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 12 23:10:34 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzRs1-0002wT-Rf for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jan 2021 23:10:33 +0100 Original-Received: from localhost ([::1]:44224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzRs0-0004O8-Ug for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jan 2021 17:10:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzRrW-0004Mu-RF for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 17:10:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50221) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzRrW-0006XQ-JE for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 17:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kzRrW-000541-Cb for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 17:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jan 2021 22:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45818 X-GNU-PR-Package: emacs Original-Received: via spool by 45818-submit@debbugs.gnu.org id=B45818.161048935819383 (code B ref 45818); Tue, 12 Jan 2021 22:10:02 +0000 Original-Received: (at 45818) by debbugs.gnu.org; 12 Jan 2021 22:09:18 +0000 Original-Received: from localhost ([127.0.0.1]:33532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzRqo-00052Z-9W for submit@debbugs.gnu.org; Tue, 12 Jan 2021 17:09:18 -0500 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:35710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzRqj-000522-Qk for 45818@debbugs.gnu.org; Tue, 12 Jan 2021 17:09:14 -0500 Original-Received: by mail-wm1-f51.google.com with SMTP id e25so3545853wme.0 for <45818@debbugs.gnu.org>; Tue, 12 Jan 2021 14:09:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=+dUaKp3u309XD56S49fEmzRtgs8XMIKa6Nueyz1u7pY=; b=ecyZfweUXR/W1NUHz0X3mZQakH37mbAQhd2dI1w7/R47kLyxUvHCmb6BTbhxXbuaxl XUyteHAqnWJXgUJ/F0pjQqGcTT6uqy3Gpfk/BQHrx+N4Xsmuk10doANT4O/tRbu3kkvs XD0Wok9PfW/r1UGZjs2rJk4R1Odr4oKJVpifC/CbhPFIN1U8K16YsBdQStdsj9tFzbli ZU8Ok1lYtzln7F4H0BUAxvz0FCzayg5MIVFTlNRwlKIVKZ0RrysiOlDG6ZT8NIgNbbGI xxNqtqvDn8BvEkmiumKRO+lLQsVsEVJWX+0d8q4mt9ZbZHXCtqt8ZOL7VfGZypmTf8tf Jckw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=+dUaKp3u309XD56S49fEmzRtgs8XMIKa6Nueyz1u7pY=; b=az19AmRzArDi0zf3rIhD0nNkC8WtycMmB6c97EfcxZaw8Uhp1I4fwmjBL6uva1i5x9 CqcuOan5WxbWpnp1Ns2aHVVf8mpOoCwsrX2Jx1lcf0AXhywWZAEuRDzSDtvQiHakkcR9 FDZukJ0fUj9AyrC1SSL08Sn4o683vbMJOiWL0CLjhLbF4jQVbVPPWVBsSqfAviM2qtef WnlrzP1TvikdoAr1eFg/2uELyP4rhALvu7r0jcDDetpyBvNizeGLNPo4kK2uI5oSz8An HW9AbXBZKgN/Xl90MScp8p7t/WgmkqTf8dXqE8PU8gR1E9xDNAEu3LG7CbUlP6/WrtB0 whiQ== X-Gm-Message-State: AOAM532J7zV4vUt2BZkBB8zK+A4aj7n8L1ALhCaamWbw63bS/tf61oiz Qx3VdJ/cAJ0OtZTv82FzUuoX1A== X-Google-Smtp-Source: ABdhPJzomnFQ56+29Pj2sq2LSlYsl2ywjjeVe6qltPQ4Sg/oIF/ZYvOmIleUDdr8ELFMh6e/Kz3nyA== X-Received: by 2002:a1c:e3c4:: with SMTP id a187mr1200308wmh.58.1610489348111; Tue, 12 Jan 2021 14:09:08 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id m14sm6945605wrh.94.2021.01.12.14.09.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 14:09:06 -0800 (PST) In-Reply-To: <59D8F21E-DA21-4F8E-AB91-550B3C154985@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Tue, 12 Jan 2021 22:02:15 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197864 Archived-At: Mattias Engdeg=C3=A5rd writes: > 12 jan. 2021 kl. 21.06 skrev Basil L. Contovounesios : > >> So I'm guessing dst-adjust-time adjusts for DST in my locale (based on >> some cache), but not yours? The following change lets the test succeed >> for me: > > Thank you, and I agree that it's probably the pragmatic choice. Much as I= would > have liked to track down and explain the exact reason for the observed > phenomenon, I gave up and pushed your suggested patch. > > If I would hazard a guess, it's related to the fact that Ireland uses day= light > saving in winter (with opposite adjustment) rather than in summer; this m= ay > trigger a daylight-saving adjustment for the dates in question (late > December). The fact that IST is used for both Irish and Indian time may be > significant or a mere coincidence; it certainly didn't help matters. > > Date and time calculations can be both infuriatingly and delightfully mes= sy, but > in this case the code didn't really help either, with way too many implic= it > input parameters -- global variables, caches, system settings, time-zone = files, > and so on. Not something to make a test writer happy! Agreed. If this is the sort of stuff that gets you (or Stefan, CCed) out of bed in the morning, then you might also be interested in looking at lunar-test-phase-list. I tried applying the same calendar-daylight-savings-starts trick in with-lunar-test, but that just brought down the difference in actual vs expected times from 2hrs to 1hr. My guess as to why this happens is because calendar-dst-find-data (or similar) calls current-time-zone without an explicit time zone argument, meaning tests can't truly specify a time zone other than the system's in general. Is this new wishlist bug report material, or are we happy to leave lunar-test-phase-list marked as unstable and forget about this? > Thanks again for the report, and for persevering! Thanks for writing the test and making it more robust! That's two of my 'make check' failures fixed in one day, only one to go :). --=20 Basil