From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#46374: 28.0.50; Ask me to save buffers only if they are under callers dir Date: Wed, 28 Apr 2021 22:35:02 +0200 Message-ID: <87eeeu172h.fsf@gmail.com> References: <878s7z4ihk.fsf@gmail.com> <87a6sdzeh6.fsf@mail.linkov.net> <87ft16g0u2.fsf@gmail.com> <87tupmisel.fsf@mail.linkov.net> <1952f2d9-51b6-a4ba-6c9e-98594222f017@gmail.com> <87r1kpemnr.fsf@mail.linkov.net> <87mtv6yloe.fsf@gmail.com> <871rcgr4qp.fsf@mail.linkov.net> <87zgz3gfqo.fsf@mail.linkov.net> <87blbhhghk.fsf@mail.linkov.net> <87pmzsgzh3.fsf@gmail.com> <87o8fc5jq0.fsf@mail.linkov.net> <87wnsz7jmy.fsf@gmail.com> <87tunvnxfo.fsf@linkov.net> <87h7jq1a0i.fsf@gmail.com> <87zgxigpbc.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7833"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46374@debbugs.gnu.org, Stefan Monnier , =?UTF-8?Q?Qu=C3=A1ch_?= =?UTF-8?Q?M=E1=BB=B9_?= =?UTF-8?Q?Uy=C3=AAn?= Nhi To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 28 22:36:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbquu-0001tq-Va for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Apr 2021 22:36:16 +0200 Original-Received: from localhost ([::1]:51080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbqut-0001ZV-U8 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Apr 2021 16:36:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbqug-0001Ys-Ib for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 16:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42626) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbquf-0005MR-UE for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 16:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lbquf-0008LK-RX for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 16:36:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <878s7z4ihk.fsf@gmail.com> Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Apr 2021 20:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46374 X-GNU-PR-Package: emacs Original-Received: via spool by 46374-submit@debbugs.gnu.org id=B46374.161964211332003 (code B ref 46374); Wed, 28 Apr 2021 20:36:01 +0000 Original-Received: (at 46374) by debbugs.gnu.org; 28 Apr 2021 20:35:13 +0000 Original-Received: from localhost ([127.0.0.1]:54172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbqtt-0008K6-G8 for submit@debbugs.gnu.org; Wed, 28 Apr 2021 16:35:13 -0400 Original-Received: from mail-wm1-f44.google.com ([209.85.128.44]:53020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbqtq-0008Jh-GW for 46374@debbugs.gnu.org; Wed, 28 Apr 2021 16:35:12 -0400 Original-Received: by mail-wm1-f44.google.com with SMTP id g65so5403281wmg.2 for <46374@debbugs.gnu.org>; Wed, 28 Apr 2021 13:35:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:message-id:mime-version; bh=14hCLY1HcYVs1REhDQGTkHubrisiAzVMr4nHuRsUDiQ=; b=HVF63IMhpgZWx/Q1TKD4kPD1Gwu9Ej/42RSjSAtTKKI+p9n558iEr/aYE+Y/JmKGIQ 6JFA+OiZdhOjRmpnBlezBD4+aAf3xoXFjcTyuKt/sX/ZtcOhs3H0v7wzI93ILB88F5h0 y6d/XnAI+iGPLGsTRZR10eTil5vbUvRSGz5BnbaSBW6mj9v1Udp+pGbigNn+qyUtpLPu jgP/e9eNwqXVZ9+K8obWN1LGcPrDm7qRmciL1ORbbzLwDffG6iS1CAZfbEmgBtegLgHK IuSmLuSKmioAn2zEjih8cveboKYb94mBQxJ3iXJ9fGW2CNjtKEOk8t8wqjGQ2nk7BKfP FbMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:message-id :mime-version; bh=14hCLY1HcYVs1REhDQGTkHubrisiAzVMr4nHuRsUDiQ=; b=ZJ2yfbUnErB4oUOw24o3KwuqRHF8Krmac0uwC4Ekz6xC6uOSx8iet1vT34wd3zRWcV j1w7+5lcgHNeE36hBci27+hJF3ajBlIBgaLuyjHZgnK+tMtkRWQclpX7YZ3uX9TrdHJM HI2Rh5r2InVa4zbilIL/0pKxLVjN6AW1ggC1XFLW0PcFgIoiICp8MJj2WOdTSPSUjy26 knTJ63Fs9QyaP57+BfcPwKfgQXwF5e9yQFFEu+zUcwdbHa0LGftchc3meW5lNA+cVrAQ Om4hX93ppNkyNLUs464P6B5OjTlJLXyOg1Fc8nn/BahOu1+8MlLBYSHrQ9HIFQM8ljAg x1qg== X-Gm-Message-State: AOAM530tgkIhZ+Mne3pLqesZ/7GNQhVG3gW5k90IDLTkXYnQGcDWRmfm 2hBYtPNjzyPo8i4HCe5GBlI= X-Google-Smtp-Source: ABdhPJwKLBzLPhC3SCG/Vi49ZwXMWOwNErLwbBV1IC8HKREeTnsx2lDBJRU1PUMJmVawVX5lz5QkwA== X-Received: by 2002:a05:600c:d5:: with SMTP id u21mr32883084wmm.153.1619642104662; Wed, 28 Apr 2021 13:35:04 -0700 (PDT) Original-Received: from localhost.example.com ([31.7.242.222]) by smtp.gmail.com with ESMTPSA id z7sm1311483wrl.11.2021.04.28.13.35.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 13:35:03 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205140 Archived-At: Juri Linkov writes: > (defun save-some-buffers-fun () > (funcall save-some-buffers-default-predicate)) > > I see a problem in save-some-buffers-fun: what if > save-some-buffers-default-predicate is still customized to nil? I assumed we were OK with the backward incompatible change; I mean, with requiring from now on `save-some-buffers-default-predicate' to be a function generating the predicate. > This value is currently allowed. It seems it should check > if it's a function, then call it. Also needs to check if the function > doesn't return another lambda, then return its original value. We can do that; but it seems to me that the spirit of the FIXME comment is in the line to not accept `nil' as a valid value, just functions. BYW, thanks for testing the patch.