unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Andrea Corallo <akrl@sdf.org>
Cc: 48221@debbugs.gnu.org
Subject: bug#48221: 28.0.50; defsubsts aren't native compiled?
Date: Wed, 05 May 2021 11:36:02 +0200	[thread overview]
Message-ID: <87eeel7cal.fsf@gnus.org> (raw)
In-Reply-To: <xjflf8uv63t.fsf@sdf.org> (Andrea Corallo's message of "Tue, 04 May 2021 16:03:34 +0000")

Andrea Corallo <akrl@sdf.org> writes:

> AFAIR having the defsubst non native compiled is what we want as we need
> the bytecode definition to have the inline to be performed.  Actually
> the test is verifying that the defsubst is *not* native compiled.
>
> I tried to reproduce here (0c993ed1d3) but for me the test is passing,
> that's odd...

Hm, odd.  The two tests here are:

----
(ert-deftest help-fns-test-lisp-defun ()
  (let ((regexp (if (boundp 'comp-ctxt)
                    "a native compiled Lisp function in .+subr\\.el"
                  "a compiled Lisp function in .+subr\\.el"))
        (result (help-fns-tests--describe-function 'last)))
    (should (string-match regexp result))))

(ert-deftest help-fns-test-lisp-defsubst ()
  (let ((regexp (if (boundp 'comp-ctxt)
                    "a native compiled Lisp function in .+subr\\.el"
                  "a compiled Lisp function in .+subr\\.el"))
        (result (help-fns-tests--describe-function 'posn-window)))
    (should (string-match regexp result))))
----

Unless I'm really misreading something here, they both seem to expect
the native-compiled results?

(A related question -- is (boundp 'comp-ctxt) really the best way to
test for whether we have a native-compiled Emacs?  That's just a defvar
in comp-cstr.el...)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2021-05-05  9:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-04  9:59 bug#48221: 28.0.50; defsubsts aren't native compiled? Lars Ingebrigtsen
2021-05-04 16:03 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-05  9:36   ` Lars Ingebrigtsen [this message]
2021-05-05 14:57     ` Eli Zaretskii
2021-05-05 14:59       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-05 15:03         ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-05 15:10           ` Eli Zaretskii
2021-05-05 15:13             ` Eli Zaretskii
2021-05-05 15:23               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-05 15:31                 ` Lars Ingebrigtsen
2021-05-05 15:46                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-05 16:09                     ` Eli Zaretskii
2021-05-05 16:08                 ` Eli Zaretskii
2021-05-05 20:33                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-06  4:49                     ` Eli Zaretskii
2021-05-06  7:59                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-06  8:09                         ` Eli Zaretskii
2021-05-05 15:00       ` Lars Ingebrigtsen
2021-05-05 15:15     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-05 15:21       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eeel7cal.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=48221@debbugs.gnu.org \
    --cc=akrl@sdf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).