From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Francesco =?UTF-8?Q?Potort=C3=AC?= Newsgroups: gmane.emacs.bugs Subject: bug#47408: Etags support for Mercury [v0.5] Date: Thu, 10 Jun 2021 19:05:37 +0200 Organization: The GNU project Message-ID: <87eed9myzi.fsf@tucano.isti.cnr.it> References: <70503251-f8ea-9006-b7e7-b13b93bb71de@gmail.com> <838s4gxurw.fsf@gnu.org> <53162dfb-0715-3077-78d1-3a8340943f2f@gmail.com> <838s3y6kaq.fsf@gnu.org> <83k0n7iarj.fsf@gnu.org> <65f059b1-149d-146d-3b8d-36db60ff1044@gmail.com> <87o8cin9fb.fsf@tucano.isti.cnr.it> <39f683d3-65d7-a7d9-18b1-cf6dfa7d254a@gmail.com> <83fsxthnye.fsf@gnu.org> <87lf7kmxuk.fsf@tucano.isti.cnr.it> <83bl8gfuhy.fsf@gnu.org> <87k0n4msku.fsf@tucano.isti.cnr.it> <834ke5ddnb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7303"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47408@debbugs.gnu.org To: fabrice nicol Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 10 19:06:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lrO8G-0001lo-0O for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Jun 2021 19:06:16 +0200 Original-Received: from localhost ([::1]:58222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrO8E-0004lL-Ek for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Jun 2021 13:06:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrO82-0004is-Fl for bug-gnu-emacs@gnu.org; Thu, 10 Jun 2021 13:06:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54357) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lrO82-0008O4-8Y for bug-gnu-emacs@gnu.org; Thu, 10 Jun 2021 13:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lrO82-00066i-3t for bug-gnu-emacs@gnu.org; Thu, 10 Jun 2021 13:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Francesco =?UTF-8?Q?Potort=C3=AC?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Jun 2021 17:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47408-submit@debbugs.gnu.org id=B47408.162334474123447 (code B ref 47408); Thu, 10 Jun 2021 17:06:02 +0000 Original-Received: (at 47408) by debbugs.gnu.org; 10 Jun 2021 17:05:41 +0000 Original-Received: from localhost ([127.0.0.1]:37670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lrO7h-000666-AP for submit@debbugs.gnu.org; Thu, 10 Jun 2021 13:05:41 -0400 Original-Received: from plesklin7.if2.ehiweb.it ([79.98.45.17]:41881 helo=plesklin7.if1.ehiweb.it) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lrO7g-00065x-3g for 47408@debbugs.gnu.org; Thu, 10 Jun 2021 13:05:40 -0400 Original-Received: from tucano.isti.cnr.it (tucano.isti.cnr.it [146.48.81.102]) by plesklin7.if1.ehiweb.it (Postfix) with ESMTPSA id 8BDEE10730F; Thu, 10 Jun 2021 19:05:37 +0200 (CEST) In-Reply-To: (fabrnicol@gmail.com) X-fingerprint: 4B02 6187 5C03 D6B1 2E31 7666 09DF 2DC9 BE21 6115 X-PPP-Message-ID: <20210610170537.6564.78208@plesklin7.if1.ehiweb.it> X-PPP-Vhost: potorti.it X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208332 Archived-At: >:- some [T] pred unravel_univ(univ::in, T::out) is det. > >Your fix incorrectly outputs such quantified predicates. For example on >tagging univ.m (attached), your commit version yields: > >:- some [T] pred unravel_univ(^?[T] pred unravel_univ^A141,4333 > >whilst my original code yields the correct tag: > >:- some [T] pred unravel_univ(^?141,4333 The first tag is a named tag, as described in etc/ETAGS.EBNF. Why do you say it is incorrect? Does etags.el behave badly with that tag? While the automatically generated explicit tag name should do no harm, if you generate a moreappropriate tag name that should improve functionality. In this case, I suspect that the tag name should be in fact "unravel_univ" rather than "pred unravel_univ". In short: 1) the first tag is anamed tag, and should behave essentially like the second, probably providing more resilience against code changes, so it shuld be the preferred way to generate a tag 2) this can be further improved with knowledge of the tagged langage: rather than relying on etags to autometically generate a name, the code should ideally provide the correct name